From: Stefano Brivio <sbrivio@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v11 00/10] Add vhost-user support to passt. (part 3)
Date: Wed, 13 Nov 2024 10:22:40 +0100 [thread overview]
Message-ID: <20241113102240.3715ab59@elisabeth> (raw)
In-Reply-To: <20241113080411.476646-1-lvivier@redhat.com>
On Wed, 13 Nov 2024 09:03:59 +0100
Laurent Vivier <lvivier@redhat.com> wrote:
> v11:
> - rebase
> - address comments from David on v10
Are my comments from before v10 and the peek_offset_cap issue addressed
now, or should I rather wait reviewing this? Or should I have another
look at that issue...?
> v10:
> - rebase v9 on top of my changes
> - remove last 4 patches from v9 as
> 'tcp: Pass TCP header and payload separately to tcp_fill_headers[46]()'
> introduces a regression in "make check" for me.
> - addressed comments from David
> - I tried to cleanup iov management, but I was not able to remove the
> update of the first iov to point to the header or to the data
> - upd_vu_hdrlen()/tcp_vu_hdrlen() includes now the size of the
> virtio-net header
> - I didn't address comments from Stefano.
> - I didn't fix the bug with seek_offset_cap
--
Stefano
next prev parent reply other threads:[~2024-11-13 9:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 8:03 [PATCH v11 00/10] Add vhost-user support to passt. (part 3) Laurent Vivier
2024-11-13 8:04 ` [PATCH v11 01/10] packet: replace struct desc by struct iovec Laurent Vivier
2024-11-13 8:04 ` [PATCH v11 02/10] vhost-user: introduce virtio API Laurent Vivier
2024-11-13 8:04 ` [PATCH v11 03/10] vhost-user: introduce vhost-user API Laurent Vivier
2024-11-13 8:04 ` [PATCH v11 04/10] udp: Prepare udp.c to be shared with vhost-user Laurent Vivier
2024-11-13 8:04 ` [PATCH v11 05/10] tcp: Export headers functions Laurent Vivier
2024-11-13 8:04 ` [PATCH v11 06/10] passt: rename tap_sock_init() to tap_backend_init() Laurent Vivier
2024-11-13 8:04 ` [PATCH v11 07/10] vhost-user: add vhost-user Laurent Vivier
2024-11-13 8:04 ` [PATCH v11 08/10] test: Add tests for passt in vhost-user mode Laurent Vivier
2024-11-13 8:04 ` [PATCH v11 09/10] tcp_vu: Share more header construction between IPv4 and IPv6 paths Laurent Vivier
2024-11-13 8:04 ` [PATCH v11 10/10] tcp: Move tcp_l2_buf_fill_headers() to tcp_buf.c Laurent Vivier
2024-11-13 9:22 ` Stefano Brivio [this message]
2024-11-13 9:48 ` [PATCH v11 00/10] Add vhost-user support to passt. (part 3) Laurent Vivier
2024-11-15 11:54 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241113102240.3715ab59@elisabeth \
--to=sbrivio@redhat.com \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).