From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=erK/+qh4; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 94EE45A061E for ; Wed, 13 Nov 2024 10:22:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731489765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GeR5Z3lx1+lyih9ZRcdT7nZryjtBixiihkE8se3TvDw=; b=erK/+qh4/yQoNZL3RlNRiuX9Q0Wvv6bPYk2QW0iJYM3YPGQ3XrxdK468JrwRFCvcd9jOCD zGGW0qIpxb75ZstK61xMVITwjBIDMRjpRfMpgaSbgNw54w7obSrKZ4Br+iMtx27FEgtIWh 1uvmanuSm3ha7nnFHHhXHFip17XCCH0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-jdx_3EiiPImPs6mZ2COWIA-1; Wed, 13 Nov 2024 04:22:44 -0500 X-MC-Unique: jdx_3EiiPImPs6mZ2COWIA-1 X-Mimecast-MFC-AGG-ID: jdx_3EiiPImPs6mZ2COWIA Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4316e2dde9eso61450245e9.2 for ; Wed, 13 Nov 2024 01:22:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731489762; x=1732094562; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GeR5Z3lx1+lyih9ZRcdT7nZryjtBixiihkE8se3TvDw=; b=OwuYPkTqep0RR47emAWHrgXv0eDb7B0SU9m/f6Nre7gub9Zi/THw/IROzknifYIvGr DZdSaO3Q6TINTy8BZZqljzaojfWZSme/PCbuhJfTWKOFU9apWz27hwXg94sHsh0VunPu wodgYqvfxyh/cGLfv8t54TGnXIoN5cngKWL/RVuA9wjtYmI72SZ8FlpZRzOj5xmrkmFL Xpf6yKoYJmK3eZ6kuhUbt0gKlYOAyREJCVjnMT/WUSkFWGxEv5DM8TOFZ3OEQU5wgN0K Qe4QsirlLHUa7JJ0I2Yp3kBa4CPQWSsWryGJ9tNJCygagw6Uh/KGXt+1Q5qm2TfqzQr3 E1FQ== X-Gm-Message-State: AOJu0YwcaF+TxNVRK3cEJR8eCTV8jaS2YNtIad0qovTm0gwhCTMRGuuC zlR1Xa3lMVv/Pcp9QvowQgdMYFwQsUNhRlqWgvT50l4vezbuRrjX6gCgNQfDHKC7BcoXIoWGmJU lFKd7zm5DcUErJi1lPeikzWDEu7ELxF/gXSHGwzdL7DhAhRW0NwKHuCk+FNWQq8eVeSSSLJ1/jC LrjhMDhGKJsbqABEEQcg8pCNHBwiexyik8 X-Received: by 2002:a05:600d:3:b0:432:bb4d:cd77 with SMTP id 5b1f17b1804b1-432bb4dcea1mr196972515e9.19.1731489762563; Wed, 13 Nov 2024 01:22:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IEzYq3VDOKvRCCIBTFQwc0EeRK4DiY567FxK0JyUQr1ZItuLfTMxwpNy9ejhC+WxeO8S7jnhg== X-Received: by 2002:a05:600d:3:b0:432:bb4d:cd77 with SMTP id 5b1f17b1804b1-432bb4dcea1mr196972255e9.19.1731489762158; Wed, 13 Nov 2024 01:22:42 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed970d89sm18221889f8f.8.2024.11.13.01.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2024 01:22:41 -0800 (PST) Date: Wed, 13 Nov 2024 10:22:40 +0100 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v11 00/10] Add vhost-user support to passt. (part 3) Message-ID: <20241113102240.3715ab59@elisabeth> In-Reply-To: <20241113080411.476646-1-lvivier@redhat.com> References: <20241113080411.476646-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zmEvPGqBDutul7IF1Fmi6fJJxaH6felI-0-OrhaBlss_1731489763 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: YEE463QSMASYLIXXEU42PN36NW7SWJNS X-Message-ID-Hash: YEE463QSMASYLIXXEU42PN36NW7SWJNS X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 13 Nov 2024 09:03:59 +0100 Laurent Vivier wrote: > v11: > - rebase > - address comments from David on v10 Are my comments from before v10 and the peek_offset_cap issue addressed now, or should I rather wait reviewing this? Or should I have another look at that issue...? > v10: > - rebase v9 on top of my changes > - remove last 4 patches from v9 as > 'tcp: Pass TCP header and payload separately to tcp_fill_headers[46]()' > introduces a regression in "make check" for me. > - addressed comments from David > - I tried to cleanup iov management, but I was not able to remove the > update of the first iov to point to the header or to the data > - upd_vu_hdrlen()/tcp_vu_hdrlen() includes now the size of the > virtio-net header > - I didn't address comments from Stefano. > - I didn't fix the bug with seek_offset_cap -- Stefano