public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 0/8] ndp: Unsolicited RAs
Date: Thu, 14 Nov 2024 14:33:02 +1100	[thread overview]
Message-ID: <20241114033310.2926316-1-david@gibson.dropbear.id.au> (raw)

The default route a guest obtains via NDP has an expiry.  We set this
to the maximum allowed, 65535s (about 18 hours).  We missed, however,
that after that expiry, the guest won't send a new Router
Solicitation.  Instead it expects an unsolicited Router Advertisement
to have come at some point before the expiry.  This means that on an
IPv6 setup, the default will disappear after 18 hours.

Correct this by sending unsolicited Router Advertisements as required
by RFC 4861.  Along the way we make a number of small cleanups to the
NDP code.

Link: https://github.com/kubevirt/kubevirt/issues/13191

v2:
 * Some minor stylistic fixes
 * Use srandom()
 * Better explanation of the random requirements for the RAs

David Gibson (8):
  ndp: Remove redundant update to addr_seen
  ndp: Add ndp_send() helper
  ndp: Split out helpers for sending specific NDP message types
  ndp: Use struct assignment in preference to memcpy() for IPv6
    addresses
  ndp: Make route lifetime a #define
  util: Add general low-level random bytes helper
  passt: Seed libc's pseudo random number generator
  ndp: Send unsolicited Router Advertisements

 ip.h    |   9 +++
 ndp.c   | 219 +++++++++++++++++++++++++++++++++++++-------------------
 ndp.h   |   7 +-
 passt.c |  42 ++++-------
 util.c  |  54 ++++++++++++++
 util.h  |   2 +
 6 files changed, 228 insertions(+), 105 deletions(-)

-- 
2.47.0


             reply	other threads:[~2024-11-14  3:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14  3:33 David Gibson [this message]
2024-11-14  3:33 ` [PATCH v2 1/8] ndp: Remove redundant update to addr_seen David Gibson
2024-11-14  3:33 ` [PATCH v2 2/8] ndp: Add ndp_send() helper David Gibson
2024-11-14  3:33 ` [PATCH v2 3/8] ndp: Split out helpers for sending specific NDP message types David Gibson
2024-11-14  3:33 ` [PATCH v2 4/8] ndp: Use struct assignment in preference to memcpy() for IPv6 addresses David Gibson
2024-11-14  3:33 ` [PATCH v2 5/8] ndp: Make route lifetime a #define David Gibson
2024-11-14  3:33 ` [PATCH v2 6/8] util: Add general low-level random bytes helper David Gibson
2024-11-14  3:33 ` [PATCH v2 7/8] passt: Seed libc's pseudo random number generator David Gibson
2024-11-14  3:33 ` [PATCH v2 8/8] ndp: Send unsolicited Router Advertisements David Gibson
2024-11-14 18:18 ` [PATCH v2 0/8] ndp: Unsolicited RAs Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241114033310.2926316-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).