From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202410 header.b=pCKtvDpX; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 5FB7E5A004E for ; Tue, 19 Nov 2024 02:22:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202410; t=1731979314; bh=bFk/6E9sQuMkLSsfeoTaXRum2yFWBJ4b8NZOZCwI7Uo=; h=From:To:Cc:Subject:Date:From; b=pCKtvDpXubbVA6e7iMXW+7QkQPwge+Ojjl6ZYDJfWmSzVNwG/UoiQCfKCbLmDypAE Qc4TTKiwv1iuST0WHjTrPmKoyvbhmyV/2tAqKNALfrAYFS1w6IPWz87MlYNMXhSE0d vTyUapaKvh8RlXyx9cPLOxrNI7g9+IN+xHpz67PTPsqcG4gb9rSYRVEiqA3zGQ4QdA 5X8VpomHH1vyZgI2qW/auYDc4dL91iwK/KbZ/30+n/GVnqmzdNC62fi59FXdLnTSsu XtyktYmCwxIh0qKA1p2p6ZYXkre9Mq1dTImewlSG+fxgTroOTJxGfmTxiaDU1akwZV K8qaw03yncI2Q== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4XsmtV6khfz4xfp; Tue, 19 Nov 2024 12:21:54 +1100 (AEDT) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH] ndp: Don't send unsolicited RAs if NDP is disabled Date: Tue, 19 Nov 2024 12:21:56 +1100 Message-ID: <20241119012156.1827870-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: MOUUCP3WFNTLIBSQT5XW26UOU27HYI2F X-Message-ID-Hash: MOUUCP3WFNTLIBSQT5XW26UOU27HYI2F X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We recently added support for sending unsolicited NDP Router Advertisement packets. While we (correctly) disable this if the --no-ra option is given we incorrectly still send them if --no-ndp is set. Fix the oversight. Fixes: 6e1e44293ef9 ("ndp: Send unsolicited Router Advertisements") Signed-off-by: David Gibson --- passt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/passt.c b/passt.c index a51a4e1..06e0a33 100644 --- a/passt.c +++ b/passt.c @@ -109,7 +109,8 @@ static void post_handler(struct ctx *c, const struct timespec *now) flow_defer_handler(c, now); #undef CALL_PROTO_HANDLER - ndp_timer(c, now); + if (!c->no_ndp) + ndp_timer(c, now); } /** -- 2.47.0