From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NaWg9nn0; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 9A6FC5A061B for ; Tue, 19 Nov 2024 21:43:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732049012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sovqbRu7xYMFG3nFe8IoboQLEotAipCM4TuTdpSA+K8=; b=NaWg9nn0iYlXsQXSc3cHicoOQrI0Muob9bU5QbIMuX8oBKayQi28ddnoAY8YF+PMjdqlNq K0VodN+vNFFglYA8wAXCeD+0scDVk/a3FzCQ8EPB70a4sgUeyPFx1lyEtFsjCS8TQudLGX gC+SbgyW/Xp5ophjsCt2QymXDJYE+28= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-B2vHLhWkNPyHYQY50trEyg-1; Tue, 19 Nov 2024 15:43:31 -0500 X-MC-Unique: B2vHLhWkNPyHYQY50trEyg-1 X-Mimecast-MFC-AGG-ID: B2vHLhWkNPyHYQY50trEyg Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-382342b66f5so2076641f8f.1 for ; Tue, 19 Nov 2024 12:43:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732049009; x=1732653809; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sovqbRu7xYMFG3nFe8IoboQLEotAipCM4TuTdpSA+K8=; b=wGT6vP/tKxrjHJS0ei+eJm81rIOLEDfVPhLDhVoYHsQXEBhlF/32/SClSLjZJto99V xt0YzkOCidIGyEDuOP3SWRzaSIQkPRqpbv+v0n92L/EFDe4Xh2+H/3AOq7Vgf+/4Oovt iU7O2MLuNUkVv0oHgdurB0x3Bs00EXpUANIIxFYga8BGdnVWGKQeAEX8uWbHxWcytiHI Jih0gAkXyCn47C4GD/CCJa/nn9I47KjjJ1u3Ty+kskbI5tcjFyd1OkloaCj9JwM+78QW sNPrn5hiHSHD1IoBehziQTtfao9Jae1NE7f1XPFh4cMulwFDwS5zkHCflAizaQtDtY8z d1dg== X-Gm-Message-State: AOJu0Yz0MXLEogvNnCT9o8LynrMWNkysd57lDpIoAlM1i6hnppmgfKi0 SzS5BGfpivl/EkEv3MxoMUAheaPVck11TPqzV8mXM0QHB6tC2qbtS2ZhZ/7pFX7KcEmHlzWJvqL yzmM3YptP9dci5+yB2u36rnxTouCJjcXit0BMx79kgF0r6VU6te5Gh4aK8Q== X-Received: by 2002:a05:6000:2b09:b0:382:383e:84e2 with SMTP id ffacd0b85a97d-38254b1646cmr104156f8f.46.1732049009417; Tue, 19 Nov 2024 12:43:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IHpO9UhmAkdtE1RdMpQdxgVN5iouayFbfck2d7G3iCN+bFf9U79w82LAHzQQ1OVtIlyVFrkjQ== X-Received: by 2002:a05:6000:2b09:b0:382:383e:84e2 with SMTP id ffacd0b85a97d-38254b1646cmr104144f8f.46.1732049008899; Tue, 19 Nov 2024 12:43:28 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825490cdf7sm262531f8f.42.2024.11.19.12.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2024 12:43:28 -0800 (PST) Date: Tue, 19 Nov 2024 21:43:26 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] ndp: Don't send unsolicited RAs if NDP is disabled Message-ID: <20241119214326.1f543260@elisabeth> In-Reply-To: <20241119012156.1827870-1-david@gibson.dropbear.id.au> References: <20241119012156.1827870-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: F8q4EYJVZRPqWfxAeV5dHHMUyZKxlMwabr33mGx0JLk_1732049010 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: IXARZKUNGM6AA4NR2N5SFWECTP5WSEGA X-Message-ID-Hash: IXARZKUNGM6AA4NR2N5SFWECTP5WSEGA X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 19 Nov 2024 12:21:56 +1100 David Gibson wrote: > We recently added support for sending unsolicited NDP Router Advertisement > packets. While we (correctly) disable this if the --no-ra option is given > we incorrectly still send them if --no-ndp is set. Fix the oversight. > > Fixes: 6e1e44293ef9 ("ndp: Send unsolicited Router Advertisements") > > Signed-off-by: David Gibson > --- > passt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied. -- Stefano