* [PATCH] ndp: Don't send unsolicited RAs if NDP is disabled
@ 2024-11-19 1:21 David Gibson
2024-11-19 20:43 ` Stefano Brivio
0 siblings, 1 reply; 2+ messages in thread
From: David Gibson @ 2024-11-19 1:21 UTC (permalink / raw)
To: Stefano Brivio, passt-dev; +Cc: David Gibson
We recently added support for sending unsolicited NDP Router Advertisement
packets. While we (correctly) disable this if the --no-ra option is given
we incorrectly still send them if --no-ndp is set. Fix the oversight.
Fixes: 6e1e44293ef9 ("ndp: Send unsolicited Router Advertisements")
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
passt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/passt.c b/passt.c
index a51a4e1..06e0a33 100644
--- a/passt.c
+++ b/passt.c
@@ -109,7 +109,8 @@ static void post_handler(struct ctx *c, const struct timespec *now)
flow_defer_handler(c, now);
#undef CALL_PROTO_HANDLER
- ndp_timer(c, now);
+ if (!c->no_ndp)
+ ndp_timer(c, now);
}
/**
--
@@ -109,7 +109,8 @@ static void post_handler(struct ctx *c, const struct timespec *now)
flow_defer_handler(c, now);
#undef CALL_PROTO_HANDLER
- ndp_timer(c, now);
+ if (!c->no_ndp)
+ ndp_timer(c, now);
}
/**
--
2.47.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ndp: Don't send unsolicited RAs if NDP is disabled
2024-11-19 1:21 [PATCH] ndp: Don't send unsolicited RAs if NDP is disabled David Gibson
@ 2024-11-19 20:43 ` Stefano Brivio
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Brivio @ 2024-11-19 20:43 UTC (permalink / raw)
To: David Gibson; +Cc: passt-dev
On Tue, 19 Nov 2024 12:21:56 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> We recently added support for sending unsolicited NDP Router Advertisement
> packets. While we (correctly) disable this if the --no-ra option is given
> we incorrectly still send them if --no-ndp is set. Fix the oversight.
>
> Fixes: 6e1e44293ef9 ("ndp: Send unsolicited Router Advertisements")
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> passt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied.
--
Stefano
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-19 20:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-19 1:21 [PATCH] ndp: Don't send unsolicited RAs if NDP is disabled David Gibson
2024-11-19 20:43 ` Stefano Brivio
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).