From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LBdfh6Iq; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 146FB5A061B for ; Tue, 19 Nov 2024 21:43:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732049030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZRq1pieKwoDtss4kIEhxCINOnXQ5x60iaUkO6/Ooico=; b=LBdfh6Iq2ktshI8twohmT89QStFci56uLw6Xk/spDMt9B5XV7JvxwgXKIaHDLQxJJX1siv MYQjT3nuP+M9gpsiXDqgxK4MOgYCqhNJD39vzi0dLy4xTf2dpzThD0SjILgLzuGJRiXfro DSptMUhgYmlaz0ufDjyuqN/XfP/QHN0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-Oz_YylpBPNmlKgaui9qm-g-1; Tue, 19 Nov 2024 15:43:49 -0500 X-MC-Unique: Oz_YylpBPNmlKgaui9qm-g-1 X-Mimecast-MFC-AGG-ID: Oz_YylpBPNmlKgaui9qm-g Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4316e350d6aso26257975e9.3 for ; Tue, 19 Nov 2024 12:43:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732049027; x=1732653827; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZRq1pieKwoDtss4kIEhxCINOnXQ5x60iaUkO6/Ooico=; b=iWRA2jz5gw5zC08IlwKLBlSQNBjzXnuSRcdkLHl3i88D80z7zr8/4cSSVH6LEBl1J7 TN1g/oBx1XJ1Q2DTeTa6DsA2ilgyi7vQ763qmQS8CZ0dX9+whTJbeQngrsIVoiSnmKz3 UsFXf6BKAfGt6AvfnXy/QDME4NENw/5N82GbRL8XZbXfQIp7vUj9rJ9NWQOBlo15wD6m tsDJ0CEwgr8goSvB/knvF3Xv7ATBxkcl5A4uwtb67ukUJHAENHynVt+OIGHBJ8ORMx/J Fn1KLucgYOaSlsLoT8gllfb4HMOpT0q2fxIhHl+Iagv6eFHF+Ob852R0gXoE41eEBv9f jR/w== X-Gm-Message-State: AOJu0YxOsHX6vtIkBZLKWPqK4oKpiLx8FlghMGAbuziHJeMVnfZ0Emnb DD8/owI0Z4bYswL7eGZuhesBw1kUBU5dJI0nGS7kGwfxcYQo/+WgoTgtB6jP3VrSI715yIfBFIP tD+NkbUEcG0ttizOal//mcvK12OKPmwnxKcX6n7wtKTJ9QIXN0rJmiqyWlw== X-Received: by 2002:a5d:584d:0:b0:382:4a7a:403e with SMTP id ffacd0b85a97d-38254add094mr167736f8f.3.1732049027377; Tue, 19 Nov 2024 12:43:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFEslpueX5vISx05HEzyieFvyRIJm4QSAf7z/Ne7Br7oUbnPxR59ZKsMH/uqlVtelZ0Uoa+jQ== X-Received: by 2002:a5d:584d:0:b0:382:4a7a:403e with SMTP id ffacd0b85a97d-38254add094mr167723f8f.3.1732049027065; Tue, 19 Nov 2024 12:43:47 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825493f36fsm231080f8f.97.2024.11.19.12.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2024 12:43:46 -0800 (PST) Date: Tue, 19 Nov 2024 21:43:44 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 1/2] test: Don't require 64-bit prefixes in perf tests Message-ID: <20241119214344.6b4a5b3a@elisabeth> In-Reply-To: <20241106014415.1765896-2-david@gibson.dropbear.id.au> References: <20241106014415.1765896-1-david@gibson.dropbear.id.au> <20241106014415.1765896-2-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: C9EaZDLdfKFjRgjXJ_MvDRT3PDNhvQWrpxS5P3kYiNQ_1732049028 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: PI5IJOH4ZHS4IHCK7JXP3MDMLFEYRGAJ X-Message-ID-Hash: PI5IJOH4ZHS4IHCK7JXP3MDMLFEYRGAJ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 6 Nov 2024 12:44:14 +1100 David Gibson wrote: > When determining the namespace's IPv6 address in the perf test setup, we > explicitly filter for addresses with a 64-bit prefix length. There's no > real reason we need that - as long as it's a global address we can use it. > I suspect this was copied without thinking from a similar example in the > NDP tests, where the 64-bit prefix length _is_ meaningful (though it's not > entirely clear if the handling is correct there either). So, I'm not sure why we had those filters, I also suspect a copy and past, but: > Signed-off-by: David Gibson > --- > test/perf/pasta_tcp | 2 +- > test/perf/pasta_udp | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/test/perf/pasta_tcp b/test/perf/pasta_tcp > index d1ccf7d..88284b2 100644 > --- a/test/perf/pasta_tcp > +++ b/test/perf/pasta_tcp > @@ -211,7 +211,7 @@ tr TCP throughput over IPv6: host to ns > iperf3s ns 10002 > > nsout IFNAME ip -j link show | jq -rM '.[] | select(.link_type == "ether").ifname' > -nsout ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname == "__IFNAME__").addr_info[] | select(.scope == "global" and .prefixlen == 64).local' > +nsout ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname == "__IFNAME__").addr_info[] | select(.scope == "global").local' > bw - > bw - > bw - > diff --git a/test/perf/pasta_udp b/test/perf/pasta_udp > index 544bf17..3d07091 100644 > --- a/test/perf/pasta_udp > +++ b/test/perf/pasta_udp > @@ -196,7 +196,7 @@ tr UDP throughput over IPv6: host to ns > iperf3s ns 10002 > > nsout IFNAME ip -j link show | jq -rM '.[] | select(.link_type == "ether").ifname' > -nsout ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname == "__IFNAME__").addr_info[] | select(.scope == "global" and .prefixlen == 64).local' > +nsout ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname == "__IFNAME__").addr_info[] | select(.scope == "global").local' ...these cause failures on a "typical" pasta-in-passt-in-passt setup, because in the guest we typically have two addresses, one assigned via SLAAC, and one assigned via DHCPv6, say: inet6 2a01:4f8:222:904::2/128 scope global noprefixroute valid_lft forever preferred_lft forever inet6 2a01:4f8:222:904:5054:ff:fe7c:cea1/64 scope global mngtmpaddr noprefixroute valid_lft forever preferred_lft forever and, whoops: ns$ ip -j -6 addr show|jq -rM '.[] | select(.ifname == "ens3").addr_info[] | select(.scope == "global").local' 2a01:4f8:222:904:5054:ff:fe7c:cea1 2a01:4f8:222:904::2 I guess we should come up with a jq expression selecting the longest prefix. Any address will do, but it's probably better to keep this consistent. On the subject, see also: https://github.com/siderolabs/talos/issues/9725#issuecomment-2478509622 ...or should we just pick the first one as we do elsewhere? -- Stefano