public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH] passt.1: Fix "default" note about --map-guest-addr
Date: Mon, 25 Nov 2024 11:43:19 +0100	[thread overview]
Message-ID: <20241125104319.156626-1-sbrivio@redhat.com> (raw)

It's not true that there's no mapping by default: there's no mapping
in the --map-guest-addr sense, by default, but in that case
the default --map-host-loopback behaviour prevails.

While at it, fix a typo.

Fixes: 57b7bd2a48a1 ("fwd, conf: Allow NAT of the guest's assigned address")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
 passt.1 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/passt.1 b/passt.1
index f5cf8a4..8d1d860 100644
--- a/passt.1
+++ b/passt.1
@@ -381,14 +381,14 @@ Translate \fIaddr\fR in the guest to be equal to the guest's assigned
 address on the host.  That is, packets from the guest to \fIaddr\fR
 will be redirected to the address assigned to the guest with \fB-a\fR,
 or by default the host's global address.  This allows the guest to
-access services availble on the host's global address, even though its
+access services available on the host's global address, even though its
 own address shadows that of the host.
 
 If \fIaddr\fR is 'none', no address is mapped.  Only one IPv4 and one
 IPv6 address can be translated, and if the option is specified
 multiple times, the last one for each address type takes effect.
 
-Default is no mapping.
+By default, mapping happens as described for the \-\-map-host-loopback option.
 
 .TP
 .BR \-4 ", " \-\-ipv4-only
-- 
@@ -381,14 +381,14 @@ Translate \fIaddr\fR in the guest to be equal to the guest's assigned
 address on the host.  That is, packets from the guest to \fIaddr\fR
 will be redirected to the address assigned to the guest with \fB-a\fR,
 or by default the host's global address.  This allows the guest to
-access services availble on the host's global address, even though its
+access services available on the host's global address, even though its
 own address shadows that of the host.
 
 If \fIaddr\fR is 'none', no address is mapped.  Only one IPv4 and one
 IPv6 address can be translated, and if the option is specified
 multiple times, the last one for each address type takes effect.
 
-Default is no mapping.
+By default, mapping happens as described for the \-\-map-host-loopback option.
 
 .TP
 .BR \-4 ", " \-\-ipv4-only
-- 
2.43.0


             reply	other threads:[~2024-11-25 10:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25 10:43 Stefano Brivio [this message]
2024-11-26  0:40 ` [PATCH] passt.1: Fix "default" note about --map-guest-addr David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241125104319.156626-1-sbrivio@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).