public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] test/passt/ndp: Add delay in SLAAC prefix test before looking for kernel_ra address
Date: Tue, 26 Nov 2024 07:18:00 +0100	[thread overview]
Message-ID: <20241126071800.6ca6f55e@elisabeth> (raw)
In-Reply-To: <Z0UyRs-wXgJC3qUq@zatzit>

On Tue, 26 Nov 2024 13:28:22 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Mon, Nov 25, 2024 at 11:37:19AM +0100, Stefano Brivio wrote:
> > I'm not exactly sure why we need this delay, but commit 9a0e544f05bf
> > ("test: Improve test for NDP assigned prefix") broke the tests for me.
> > 
> > I think it's because the kernel (at least all the versions I'm testing
> > with) might not mark an address as 'kernel_ra' right away, so the jq
> > expression doesn't return any result when we check.
> > 
> > Fixes: 9a0e544f05bf ("test: Improve test for NDP assigned prefix")
> > Signed-off-by: Stefano Brivio <sbrivio@redhat.com>  
> 
> This will do the job, but I think we can do better.  There's logic
> above this to explicitly wait for DAD which doesn't seem to be
> working.  Having another look at it, I think that's just because the
> conditions I used are a bit sloppy.  I'm about to send a patch which
> improves them, which I hope will fix the problem you're seeing.

Ah, right, thanks, I missed the fact that the filter on the previous
wait didn't actually match the filter for ADDR6. Your new patch fixes
the issue, so I'm discarding this one of course.

-- 
Stefano


      reply	other threads:[~2024-11-26  6:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25 10:37 [PATCH] test/passt/ndp: Add delay in SLAAC prefix test before looking for kernel_ra address Stefano Brivio
2024-11-26  2:28 ` David Gibson
2024-11-26  6:18   ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241126071800.6ca6f55e@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).