From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Qeiqd1U2; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id B169F5A004E for ; Tue, 26 Nov 2024 07:18:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732601888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1iMxmfmY2x730cksl4VnrT4l/rCkVFQMtxxbONoCWEo=; b=Qeiqd1U2pKoLxyuYMYkXM2ObQIHexUiwvp6Qu6WvfmB/Txp+lBGja4hFAb7Fe45WMKqnYV pZ3mhn/SisU6Xyt5bmhRgCqAZJAe38OgZZ5Nl10WflhJKNvlgclL1GjWavFVtdPWfFyPmm sVHP37CotAzOox3nk+emnbYIXQlccDo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-iAWw-knfN-SBuVUZNA_0Ww-1; Tue, 26 Nov 2024 01:18:05 -0500 X-MC-Unique: iAWw-knfN-SBuVUZNA_0Ww-1 X-Mimecast-MFC-AGG-ID: iAWw-knfN-SBuVUZNA_0Ww Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-382450d158fso2572504f8f.1 for ; Mon, 25 Nov 2024 22:18:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732601883; x=1733206683; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1iMxmfmY2x730cksl4VnrT4l/rCkVFQMtxxbONoCWEo=; b=RO1laM7+5mCh3p0LG6OmosKPitoCRxC6S32vZEm9iSUMRCV3w+n5RujjwciTvRZcCD HoWqWirYlWkyKF2gR63y/9wKYNCh74q58jvSuVfD1q3wkBIJKUyv/WmWxCcCsoot/46x OjsyfqyAAzLAOATIQquB6aEH88ybMXY2H5NjUoM/R/0XSDIh5X0xyhynY78O5TBfvrlV U/VwTgAYcI9aNmGBZqPDB+7l6A7uHdGuyvwbQhyc6ONwp8a0Q+M+JAANCQInd8GqGhle +KTCv8ElNBr+50X5ix13V7eJG3UvWx66aUi/tXN0p62Efcz4e2tlBqMQTTKRX0U/2j8N pBsg== X-Gm-Message-State: AOJu0YwyYbeWkhgq5Ce7G8lgLerEMO2OI/SGo3y6jt0sFM8sWMVY22ok mACzLdnR0zib/5Ad4XAxCAPZOq9mdbp15kHinR1sdY67oOzdF97KWmBSJVM7+5auDhkuK7KVGgd EU3A6qZXZ6smydrx6P0ypDanNtbnFIVgZrVHdReuXZH25uru4ZoiLR6UIHQ== X-Gm-Gg: ASbGnctIPxQXaLKj2IeuWiHPUogwtOdtbcQV73qduFAnqNdpyZ/7TuN87IwIQQmg+6G jynSQe5gsmZ2zF3SIH054vQqRse85Pt3Fw9bixc2Z+EhSrnnIzPEtIBL9ZgxQdVTC4W5k8CfVvX 1zD+uMV8xbd/osoak0YUV5e0dQ+G/uDdXfpiDfZp+Es5Qs50+fkgpl1UhUtzduioThNslC2wrhN IAZru31YsFCN11oIlBfTFslRglsTQwkT7FTGPmlMfY/YhUjzZyCjBvrWw3SeQ== X-Received: by 2002:a05:6000:4904:b0:382:4eef:28a with SMTP id ffacd0b85a97d-38260bce857mr13509247f8f.43.1732601883113; Mon, 25 Nov 2024 22:18:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGTnf7js3slJttvLTbMkd1UxSRn9mcEk+ANCBdRVjpGdMr0jWLbw4mEcTBTkOKRxOeWOAT6rQ== X-Received: by 2002:a05:6000:4904:b0:382:4eef:28a with SMTP id ffacd0b85a97d-38260bce857mr13509224f8f.43.1732601882501; Mon, 25 Nov 2024 22:18:02 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fafe207sm12382717f8f.36.2024.11.25.22.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2024 22:18:01 -0800 (PST) Date: Tue, 26 Nov 2024 07:18:00 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] test/passt/ndp: Add delay in SLAAC prefix test before looking for kernel_ra address Message-ID: <20241126071800.6ca6f55e@elisabeth> In-Reply-To: References: <20241125103719.154760-1-sbrivio@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lpcLu151_eAYFtZ7h1VT4tFDtJfYjVSK1cAv3OykONE_1732601884 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 5FLXZZTD4L65RXHSX22MQUY5G2TU362E X-Message-ID-Hash: 5FLXZZTD4L65RXHSX22MQUY5G2TU362E X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 26 Nov 2024 13:28:22 +1100 David Gibson wrote: > On Mon, Nov 25, 2024 at 11:37:19AM +0100, Stefano Brivio wrote: > > I'm not exactly sure why we need this delay, but commit 9a0e544f05bf > > ("test: Improve test for NDP assigned prefix") broke the tests for me. > > > > I think it's because the kernel (at least all the versions I'm testing > > with) might not mark an address as 'kernel_ra' right away, so the jq > > expression doesn't return any result when we check. > > > > Fixes: 9a0e544f05bf ("test: Improve test for NDP assigned prefix") > > Signed-off-by: Stefano Brivio > > This will do the job, but I think we can do better. There's logic > above this to explicitly wait for DAD which doesn't seem to be > working. Having another look at it, I think that's just because the > conditions I used are a bit sloppy. I'm about to send a patch which > improves them, which I hope will fix the problem you're seeing. Ah, right, thanks, I missed the fact that the filter on the previous wait didn't actually match the filter for ADDR6. Your new patch fixes the issue, so I'm discarding this one of course. -- Stefano