From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bwmkerak; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 089105A004E for ; Tue, 26 Nov 2024 08:49:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732607390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+wbuUb85Aqh71AIOp/rmlCOwk4W0LgHCV5EWvnBQk1Q=; b=bwmkerakrLGxbCKQlMEiPshfiz6mDE4eOWqZudoviFHC5ZVsfHu6c1CWTCXSleVJzdm2IL B/TGvyLzp/pCxGdWAeJDsL0lSLu5rt17QZ9mYXo+Mt0CHpaYSvl9C9nwbI2KBy2p+9ul2k KEeHCdNIQaZkYAUZ+SdslQ4bFt+2oZ8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-573--JJ5_G40M6uz5-IHOaBKZA-1; Tue, 26 Nov 2024 02:49:47 -0500 X-MC-Unique: -JJ5_G40M6uz5-IHOaBKZA-1 X-Mimecast-MFC-AGG-ID: -JJ5_G40M6uz5-IHOaBKZA Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-38256bf4828so2686145f8f.1 for ; Mon, 25 Nov 2024 23:49:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732607386; x=1733212186; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+wbuUb85Aqh71AIOp/rmlCOwk4W0LgHCV5EWvnBQk1Q=; b=iOYBT9BiEv0MN4rUjCv8AAi7V6twPlxa0y7N6d0hU1MVayFmiLwNy0uisnaH24c7Fw vz1uhzztAdsDyiRxyOkx7XP0E4c5lpkXJ29v6paXOQ1Oi7t2Bi0bM4GX6TPPOp18h5ey v+Wx78gNa5dmQosKuBCfO7dq9MqG0KQUtEKUvhWnwUr+R2hz0w4P1+g/vxAnCUNOcRj4 D5IrK//rdi9XEd2PteDvby5l3WknPdaB46XxWQbOsHt32f+QEkoooi7sIDG34/f04H10 kB2nEcFUyyafYGe9meN28B4/W4aX/A418hpsLVV/7W2PGQ5eml+FbrsPs78KF69y+dXS 4f2w== X-Gm-Message-State: AOJu0YzgdWjYC6dLu+AXCUwvZ3yGXyJUBXAEjvUQuN0rnF8LwyAkJLUb 4z3R5ruPaUjOsoMmqAEq4b8x6G+Xrw4qNdo/s8U6B4+U0dzR5d5/dv9BtvjL0IW5IZr8jYFtMuY Y+6Fvvvf9h5j8Dj1/Bh8Twhw7299khZtmma9aMZFIChdyWCS415D+otU8og== X-Gm-Gg: ASbGncuc0XLJWTtTKfCwh7ctv2/upEdx0ekSvwfSVYvIdxlZJjNUC+ssbXzVDDmdCsg ks498LOLmhueTZv6WfoUFfIv5QZFO6SlPGI+CYAIzg6CUHpg3FIMeEf1X811VVn7kU+0Q2sDrT0 jNS6sD8yWoFcAk1gT+8ZMsrVwk2pxTXq+5nazUM/bxVoN0fJiZKyAr0qiDE34YdaK8y6dHs4qxo 1qkZK3Vwg8OcAI7fv/mwRHp5+Q2KM7Ed4ni99rst/RENqknQzIWaGp5ftxWUg== X-Received: by 2002:a5d:6c66:0:b0:382:485b:f976 with SMTP id ffacd0b85a97d-385bfaf1e19mr1670538f8f.15.1732607385754; Mon, 25 Nov 2024 23:49:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IHR4rEgvGSiuHu2hc52HjwSXjl/cyL8buIwJps206STFsuTdxaThGrrUlfIVoNiC0ct60XU0g== X-Received: by 2002:a5d:6c66:0:b0:382:485b:f976 with SMTP id ffacd0b85a97d-385bfaf1e19mr1670528f8f.15.1732607385415; Mon, 25 Nov 2024 23:49:45 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fad62fasm12470002f8f.15.2024.11.25.23.49.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2024 23:49:44 -0800 (PST) Date: Tue, 26 Nov 2024 08:49:43 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] test: Improve logic for waiting for SLAAC & DAD to complete in NDP tests Message-ID: <20241126084943.00c8b56c@elisabeth> In-Reply-To: <20241126032727.607881-1-david@gibson.dropbear.id.au> References: <20241126032727.607881-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cSMSsc4Ocg2TNs_xX7WEyhHxKp03BYt6jUm6iQj9B0I_1732607386 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: LXYWZ4NDULXFTD6YD67XO2YRL4PK2V7C X-Message-ID-Hash: LXYWZ4NDULXFTD6YD67XO2YRL4PK2V7C X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 26 Nov 2024 14:27:27 +1100 David Gibson wrote: > Since 9a0e544f05bf the NDP tests attempt to explicitly wait for DAD to > complete, rather than just having a hard coded sleep. However, the > conditions we use are a bit sloppy and allow for a number of possible cases > where it might not work correctly. Stefano seems to be hitting one of > these (though I'm not sure which) with some later patches. > > - We wait for *lack* of a tentative address, so if the first check occurs > before we have even a tentative address it will bypass the delay > - It's not entirely clear if the permanent address will always appear > as soon as the tentative address disappears > - We weren't filtering on interface > - We were doing the filtering with ip-address options rather than in jq. > However in at least in some circumstances this seems to result in an > empty .addr_info field, rather than omitting it entirely, which could > cause us to get the wrong result > > So, instead, explicitly wait for the address we need to be present: an > RA provided address on the external interface. While we're here we remove > the requirement that it have global scope: the "kernel_ra" check is already > sufficient to make sure this address comes from an NDP RA, not something > else. If it's not the global scope address we expect, better to check it > and fail, rather than keep waiting. > > Fixes: 9a0e544f05bf ("test: Improve test for NDP assigned prefix") > > Signed-off-by: David Gibson Applied. -- Stefano