From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MRWDMmEK; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 73AFD5A004E for ; Wed, 27 Nov 2024 13:49:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732711757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kl5QYzMDlMfktr/oC4Yvp86sxH3murp/VagZJsrWY8c=; b=MRWDMmEKWtEEVvATTbNpfz4dnyvSImOPMe1ROqckWv5qsNVFa/JVOxD3hWw8c+SNGngmP/ 1d33zKsoiwHPa82APwRUjd+9bDCxWpbVNtL8tduWIUZUdgvTX7zJcjciTXa9Qrp4i93GAb 0QglaVkYZUOLFTV9mX6jIWUu6ll0MQ0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642--6vOq4NpN6K9AmUpkk5dmg-1; Wed, 27 Nov 2024 07:49:16 -0500 X-MC-Unique: -6vOq4NpN6K9AmUpkk5dmg-1 X-Mimecast-MFC-AGG-ID: -6vOq4NpN6K9AmUpkk5dmg Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38242a78f3eso3507277f8f.0 for ; Wed, 27 Nov 2024 04:49:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732711755; x=1733316555; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kl5QYzMDlMfktr/oC4Yvp86sxH3murp/VagZJsrWY8c=; b=Qn0VLEhcejY4QoMiSievxxvH8i3yxVlNhTAslItQhNweUWYLTCpe7eoyWBxROT+4cX kaevflKIDsfYlsOhntNZ4bQk45l+VH2baD39zZpOKywXC+ohWYgaahqgooD2hpjXcoMs tN9UomWENDQleM4X8IuLUtKCNMQ9LtXP+u4exsMCX3hRQhO4hJR9QPgcCMXnYiQCZu22 C7oFZ0Dfzg1tvac3+h5yIrg1YttT8+HNb+NUBMeuclFqUJf08Xr+FeWzShrNqdEJbb4n /l59zJ+vUW5hGB1vTByN8FDjmnDWKrP6jLbE0vM/HZwWhZj4FpbdFhCulznofeZnPQa9 5B1Q== X-Gm-Message-State: AOJu0Yxa5ePzhydDT01XEceGl2+3nrW81AZcK7GY+z4VLqzO0Xp1h2Bg ZcmKmMzQmX6D0/shiEhDV3XS1YWH4FCF2VrX4sqatBSGFT4kvU+/IuIfXUTWnoDJVpDCa3JjuEx Ek50HhgAY9q61J8BY6VRRbyFjKRgbbT98M8Gt53yuWzwadw2niA== X-Gm-Gg: ASbGnctvqdf7gHwM1bhnqmDJnObySAqgBS+mIqyP9NYD1DRKy74uozOTPRlVfQZWLgQ hbHnUZHXVppJ7YIwRkII3bzewWLyueDjFqOxNeiKOv9NHHNeTGetivSJsJUiK1TbANoFIs0gu2d m84P6BWxt5/Uyp0rxVVIsWXbEXLPeqXbEnU72mhc9yzr1Z8h+Yr/YsbNb4bYsKkvgN4VJ6Bwbcu u00SYnQMkCxwHhLGdp871o3YAnowWzYRytms7u7HRtoyCd/72e8ud9F/tywSw== X-Received: by 2002:a5d:5c04:0:b0:382:5295:b33c with SMTP id ffacd0b85a97d-385c6ee26e6mr2532826f8f.58.1732711754688; Wed, 27 Nov 2024 04:49:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IEyb4T3N1qC4sXhMpoId0zC5MWd2D53l22+FNy8pYiqcGuieUu69u6aDTererUDJ6tQ59wZiQ== X-Received: by 2002:a5d:5c04:0:b0:382:5295:b33c with SMTP id ffacd0b85a97d-385c6ee26e6mr2532808f8f.58.1732711754383; Wed, 27 Nov 2024 04:49:14 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fbc44f7sm16677775f8f.82.2024.11.27.04.49.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2024 04:49:13 -0800 (PST) Date: Wed, 27 Nov 2024 13:49:12 +0100 From: Stefano Brivio To: Paul Holzinger Subject: Re: [PATCH v4] treewide: Introduce 'local mode' for disconnected setups Message-ID: <20241127134912.6df3f693@elisabeth> In-Reply-To: <293d884b-1a82-41f4-aa21-b9cbe28b3fd4@redhat.com> References: <20241127042725.3133538-1-sbrivio@redhat.com> <293d884b-1a82-41f4-aa21-b9cbe28b3fd4@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Pb916vgHLGBw02ITvQzZiCa3ZPa1C98FKmF45QP637E_1732711755 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: U6LBXK2BD4CU2H46JIRJPL4RHLCO3V5W X-Message-ID-Hash: U6LBXK2BD4CU2H46JIRJPL4RHLCO3V5W X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 27 Nov 2024 13:37:25 +0100 Paul Holzinger wrote: > On 27/11/2024 05:27, Stefano Brivio wrote: > > There are setups where no host interface is available or configured > > at all, intentionally or not, temporarily or not, but users expect > > (Podman) containers to run in any case as they did with slirp4netns, > > and we're now getting reports that we broke such setups at a rather > > alarming rate. > > > > To this end, if we don't find any usable host interface, instead of > > exiting: > > > > - for IPv4, use 169.254.2.1 as guest/container address and 169.254.2.2 > > as default gateway > > > > - for IPv6, don't assign any address (forcibly disable DHCPv6), and > > use the *first* link-local address we observe to represent the > > guest/container. Advertise fe80::1 as default gateway > > > > - use 'tap0' as default interface name for pasta > > > > Change ifi4 and ifi6 in struct ctx to int and accept a special -1 > > value meaning that no host interface was selected, but the IP family > > is enabled. The fact that the kernel uses unsigned int values for > > those is not an issue as 1. one can't create so many interfaces > > anyway and 2. we otherwise handle those values transparently. > > > > Fix a botched conditional in conf_print() to actually skip printing > > DHCPv6 information if DHCPv6 is disabled (and skip printing NDP > > information if NDP is disabled). > > > > Link: https://github.com/containers/podman/issues/24614 > > Signed-off-by: Stefano Brivio > > Just for completeness sake, I know it is already applied. so it doesn't > matter. > > Tested-by: Paul Holzinger No, no, it matters, thanks a lot. The upcoming release is 100% more tested now. :) -- Stefano