From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=d+FF4RjN; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 5066D5A061B for ; Thu, 28 Nov 2024 14:04:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732799044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NBOZqBYUidxXy3+1vAFZRuof2r4eF6+MuInMP3RX8B8=; b=d+FF4RjNlj78lQhLx+0thnfPmJl13aaKWuztdT6l41RkIPnsfibrZZQNIUTSVR5Ke/sJ0H NwvDJoOadvPUcK2R8b+V9v9Jne/T03ox5RQjomG1dZrNoXySgJT4lTQJ483Jv+9G0ASwo/ SHK5cRzwx2TlBAlW+2oukjWKQK9XLg0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-600-zABIaUVhPviENBrPYns-tg-1; Thu, 28 Nov 2024 08:04:02 -0500 X-MC-Unique: zABIaUVhPviENBrPYns-tg-1 X-Mimecast-MFC-AGG-ID: zABIaUVhPviENBrPYns-tg Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3823fe49055so441489f8f.2 for ; Thu, 28 Nov 2024 05:04:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732799041; x=1733403841; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NBOZqBYUidxXy3+1vAFZRuof2r4eF6+MuInMP3RX8B8=; b=lcvEZA3AMDQwZkPAcfykelWXRLr6rWhUnZKMuE4+VEup210u9dVc6yu1YK9ijzbjOe NOP0Rigr5YrVcI6D3GCnXuCComEAIG19A1FBhoFzi1LW72APg8kH/o94IG4eB7ihyb0V aTbK7XjfduG9r/C/YzztIZT+i2BcA/spkfFARsQpvgdHNb/mdiCGCjlqZnUVXKnrTOBG qQ/zBrwRvJVQHaHIX31N2x1olJaJP12GcInu0W4vZIDwr8KtZqow+75ghNMZKGKYoDeZ Uo61cAI/C7Kx9fqNj5QbvGPKuCN3VKea2TF2HrmKfrFMAX0iwpN8lEdEd3DDTc48I9Vv J6Ig== X-Gm-Message-State: AOJu0YyOXCK3/AXB0IiRIRyOGAjwSWGVsortQmkAY1FZ8egDmYYRwyGW AOFnDnsvzGNPBps+iLjvPsiCWGJMNIpgtZmd926Ty8LmmD34k1Th4+hwyp1uFmGIjx/xpfvYdTT yHWVnmELM05izk/Th0r1X4WrywUDA7fwE9oOhkG/1A5g6y1kLgBLVvud93A== X-Gm-Gg: ASbGncv/HuVS6V8ljdFVjbRr6pGmqbITjpvmBOCbHPkoe9w+t37/MTY21YSehx5BhLz ZDL3wXxD+B7mXr3gJjkZ+mJFuYtYeGQiYTwmtlUwZgi36gnZBaS0u5W1H7o5tHBbAmuaQtEotVE +tgBFkignlNvd55hJmRC6EcArk4/y0MsIPgV9OB8R0XKlr3UfqAeXT9miuz8ACsVmduQqqFAp1z hUHyRup5RcFqqIHBqfKqJUWxKCQfPmS1c5HTapvDsSor1FvzQ4ow1k87ElxlA== X-Received: by 2002:a5d:64cb:0:b0:382:4e85:1f04 with SMTP id ffacd0b85a97d-385c6edd3f3mr5468573f8f.47.1732799040955; Thu, 28 Nov 2024 05:04:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+czCiafffWwP8Mpep+FRRlJCO0K7mpsnLbPmmgAaIdyQtAM+fZi2jUxHNGYMeo9uoBZkM5g== X-Received: by 2002:a5d:64cb:0:b0:382:4e85:1f04 with SMTP id ffacd0b85a97d-385c6edd3f3mr5468245f8f.47.1732799035933; Thu, 28 Nov 2024 05:03:55 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385ccd68c1bsm1626314f8f.84.2024.11.28.05.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2024 05:03:55 -0800 (PST) Date: Thu, 28 Nov 2024 14:03:53 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/7] TCP buffer handling cleanups (including vhost) Message-ID: <20241128140353.439d4e9d@elisabeth> In-Reply-To: <20241127035410.1167773-1-david@gibson.dropbear.id.au> References: <20241127035410.1167773-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: stpDrOufj7NlRLSDSAw95GO4g435b1Wtes-HiRNcZSQ_1732799042 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 2J4MPSEAJCWBQY32YASGEWHPIAIEW5MT X-Message-ID-Hash: 2J4MPSEAJCWBQY32YASGEWHPIAIEW5MT X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 27 Nov 2024 14:54:03 +1100 David Gibson wrote: > Here's a current version of my IOV tail and some cleanups to TCP > buffer handling based on it. Now rebased on top of v14 of the > vhost-user patches. > > This was aimed at sharing more code between the "buffer" and > vhost-user paths, but that turned out to be trickier than I > anticipated, so it hasn't really been accomplished. Nonetheless I > think these are reasonable cleanups on their own merits, and may yet > make sharing some more code between the paths easier in future. > > David Gibson (7): > iov: iov tail helpers > iov, checksum: Replace csum_iov() with csum_iov_tail() > tcp: Pass TCP header and payload separately to > tcp_update_check_tcp[46]() > tcp: Pass TCP header and payload separately to tcp_fill_headers[46]() > tcp: Merge tcp_update_check_tcp[46]() > tcp: Merge tcp_fill_headers[46]() with each other > tcp_vu: Remove unnecessary tcp_vu_update_check() function Applied. -- Stefano