From: Stefano Brivio <sbrivio@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] tcp_vu: Compute IPv4 header checksum if dlen changes
Date: Thu, 28 Nov 2024 14:04:02 +0100 [thread overview]
Message-ID: <20241128140402.4eb3a0c8@elisabeth> (raw)
In-Reply-To: <20241128120841.4129705-1-lvivier@redhat.com>
On Thu, 28 Nov 2024 13:08:41 +0100
Laurent Vivier <lvivier@redhat.com> wrote:
> In tcp_vu_data_from_sock() we compute IPv4 header checksum only
> for the first and the last packets, and re-use the first packet checksum
> for all the other packets as the content of the header doesn't change.
>
> It's more accurate to check the dlen value to know if the checksum
> should change as dlen is the only information that can change in the
> loop.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Applied.
--
Stefano
prev parent reply other threads:[~2024-11-28 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 12:08 [PATCH] tcp_vu: Compute IPv4 header checksum if dlen changes Laurent Vivier
2024-11-28 13:04 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241128140402.4eb3a0c8@elisabeth \
--to=sbrivio@redhat.com \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).