From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dht8vLIi; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 551C15A061B for ; Thu, 28 Nov 2024 14:04:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732799056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=70VRx5UpIDNr+uQa60iXVCkjXaCk7NUKwWYvM0z3viE=; b=dht8vLIiwN5YawK4BaDExWTYajAEXF16YeAAdRpTif8RJxQl0GZkKGdTq3A5sM6qwqGeBS 93pELFbnZF5HMKsrk6u2+tzQrEtoyijXTiuRs9wKEhNf/MO6/oZATvRg2ymRe9NCVeDDoN yol7QEfkaHbej6H196JosGl2z7n4TUk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-505-5btU3TBAM_uqQIOFDtLulg-1; Thu, 28 Nov 2024 08:04:15 -0500 X-MC-Unique: 5btU3TBAM_uqQIOFDtLulg-1 X-Mimecast-MFC-AGG-ID: 5btU3TBAM_uqQIOFDtLulg Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4349e97bfc4so7481585e9.3 for ; Thu, 28 Nov 2024 05:04:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732799053; x=1733403853; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=70VRx5UpIDNr+uQa60iXVCkjXaCk7NUKwWYvM0z3viE=; b=Xc370xWMM4p4IHuxzNNY9rqc0Tm2B6qJqD8p21flVF6e69FaNCcQpKZeClQxfu7pOK NFce2cmJLgtlmqIzw3sNiUP/0M/bTmidKkTDknNRnzc1/YzZeyNtXC8uj52KzVdRoL3W 9tbNnOUjQZyIL6PUb1Jhx7qrnT0e7jVl932iDaqbFt5qeGtsU5vx568dRXQstj+Ktczj gF1TmvogoyncBJSqj305eWMwVQ0ZRXiisUfiQr8ZthEPoUhXNQt1ZUGN7QSYJU7SEiOk Lwvwnpvf4QN7FZbMyVZn3KNtTW01/yHUhoDg7oEzOOzIpiJjzgsS/7LIsAWWNoZqBLnp 3GtQ== X-Gm-Message-State: AOJu0Yw1yqffap7oVek8tFfwf2FqAjIh5IaBNxqWoWB7k71W7LKW5twe hlcdGqIAQiu6vooE3Nud4sCRd6oqMNkyFzSWOyvk3SMYg9E1UUJnqiNsGDEOWRyieMBfuUhk4F2 VOCdd83Y0Q6GvP676LnAWm8Jc2/bS+RfbJISMcSJjI1zkN5hH9lnViMIJ3FubFh+LmBzVMZcyIa yzNWtzUBiyb+Du5eliwyqT0rfGu4H2Fpfb X-Gm-Gg: ASbGncu5i7F5UkPZDqGc0OrIaGqMatzuvh46/456pKxHB7FPOJP7RfehovduVWd7Wwi 7bDwwidCIRbo4CSosP15U0tuLKf2E7W1Ec4UuRFJovp5BvGUSZXsZ+NcTd/L/uIVYVlo/2vGRDZ BCE71jmxE+3By1kB3Zndr+RKc3ogmDn4qxhZZVq7kL2Dhwfd8+a+rMuLOkgcd5RI4nwCBucZYIU xjGxebA0y3xAItjRWxnuvskirFfZmzTxKQeTl8mitzUuQg8UczTZxZWn0hYnf9V3Beq1ImC/bWC r9g= X-Received: by 2002:a05:600c:3b24:b0:434:a802:e9a6 with SMTP id 5b1f17b1804b1-434a9dbb64amr68933525e9.7.1732799053205; Thu, 28 Nov 2024 05:04:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IEbcl2e9CrVra2cHAMv9YDp7P+rB4TsXLlDCQiiuDugqAX9uljvDy6bOfXbGVmRpq9DX3ZFPA== X-Received: by 2002:a05:600c:3b24:b0:434:a802:e9a6 with SMTP id 5b1f17b1804b1-434a9dbb64amr68926315e9.7.1732799046282; Thu, 28 Nov 2024 05:04:06 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434aa7e4d42sm52701345e9.37.2024.11.28.05.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2024 05:04:03 -0800 (PST) Date: Thu, 28 Nov 2024 14:04:02 +0100 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH] tcp_vu: Compute IPv4 header checksum if dlen changes Message-ID: <20241128140402.4eb3a0c8@elisabeth> In-Reply-To: <20241128120841.4129705-1-lvivier@redhat.com> References: <20241128120841.4129705-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AFV8puB1n2vyehHdXV6XEiYqpUWo7_1UT4ppo7K-PTk_1732799054 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: NOUZBHAUYRA4CULQD55D4TFNA5KEG5BR X-Message-ID-Hash: NOUZBHAUYRA4CULQD55D4TFNA5KEG5BR X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 28 Nov 2024 13:08:41 +0100 Laurent Vivier wrote: > In tcp_vu_data_from_sock() we compute IPv4 header checksum only > for the first and the last packets, and re-use the first packet checksum > for all the other packets as the content of the header doesn't change. > > It's more accurate to check the dlen value to know if the checksum > should change as dlen is the only information that can change in the > loop. > > Signed-off-by: Laurent Vivier Applied. -- Stefano