From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=R/CdGIeE; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 6603C5A061C for ; Sat, 30 Nov 2024 00:57:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732924665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h2whZeAqLnagP0djjVFw6ofhxnuVm60oiqyXYEQ+MgQ=; b=R/CdGIeEZJx5E8VGoHM2E/1bPT9AKTjxppOX7GY5SkzDlLnhF0UdFU3fJGjZtHwxeRO/eo bjqORmnu/D3BTmkmtm92xiSkarANVu2mi6xuSkacclC3KuvrSXSULAVLKaMcz0kpxLhUpi G0c6IK3U2oRmWAmnyiMrSmau6DtmVrE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-364-sQjGvYLQM2yKmxcI46g91w-1; Fri, 29 Nov 2024 18:57:44 -0500 X-MC-Unique: sQjGvYLQM2yKmxcI46g91w-1 X-Mimecast-MFC-AGG-ID: sQjGvYLQM2yKmxcI46g91w Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4349cda1899so17720455e9.0 for ; Fri, 29 Nov 2024 15:57:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732924661; x=1733529461; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=h2whZeAqLnagP0djjVFw6ofhxnuVm60oiqyXYEQ+MgQ=; b=QAGpgiMkAjvmblMra2rlSeUbzCmoXffCJy4OpnuDESdeoqFO2QokAzIZnGGwM2TWjZ rtujjjkgIhBMFIaMJ9Pr8QlkpnY51JRQPIWzTqe8jTX4yNzKAd/3M93m1thxjZsWx4kV JrXKTaG6ystl+yVI0b4JEgAq06qcsKlYrJwoWUrZbTgBXK8XkF4IuYGcQXx3YzKVAd4v LVk3tOb9cn/mcoWEbWDsBqtGSkTPYr8VGYH8KCsj7PbdKdHHtNLJFpItiqkp8B/mDh4t vu3UJGEP3EpclbI+/eA+Z5LOW++ekPngfJls9DibhOOz6nAKpNBiZY2t/W+JvQ0z2my5 3h0w== X-Gm-Message-State: AOJu0YzH2fC7rymgzH0b0acxC12Q6t+1ZYSW/+HSBVP26b+ZXaqdPJZ2 fgahP8RIkrCzUICH8ZrF57tGjUvqF7Y3Z79dxNnShOi645pfd/wF/Z4GUUFQcXhOUn06R/ZEy6f 5Xzo2Ul3t0ulByb+04lZ4J5ExrpaOIgu2d/+ikmM0eK6sQ2dUmQDJsQB8jO29fWNUE4r+T/tRmo 3vuT67HQbUJB+fP2OBa6ZsTpvBIqLwC9vY X-Gm-Gg: ASbGncvijFcPEh0+iuei2UaIAf/YuyHKizFzI4s1/L7m7r/pMncgwm/DGjPKh6DC3je 8TVMh7ulta/xL9mHapSIRA/YiOgi9MQV3u6zPoZf0rlPohUOPbOImYuo1WAOAZjmFN0tRVJ8I3Q ckOX+SW/rC/PPqGyWpLKgCwBj1Gfg/7YQqHPuQP0EquEs0fdGcn58djW0aX7OlIsOihzL54ugRO shGViBu7M8/aeioRuL3vocHyU/BcYpd64ffq2d4X0aSDeAaE2aCQzb9mcU9Rw== X-Received: by 2002:a05:600c:4fc9:b0:434:a71f:f804 with SMTP id 5b1f17b1804b1-434a9dbbd30mr148571355e9.3.1732924661600; Fri, 29 Nov 2024 15:57:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1WkWSIdsAmc7meFwUz8MUQSzBK+Tts1uPc3bGzMWH6LieD5S7T+dVAAOiGX0Liz8lGL5psg== X-Received: by 2002:a05:600c:4fc9:b0:434:a71f:f804 with SMTP id 5b1f17b1804b1-434a9dbbd30mr148571175e9.3.1732924661181; Fri, 29 Nov 2024 15:57:41 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434b0f327f2sm67356265e9.29.2024.11.29.15.57.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2024 15:57:40 -0800 (PST) Date: Sat, 30 Nov 2024 00:57:38 +0100 From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v2] pasta: make it possible to disable socket splicing Message-ID: <20241130005738.19aa116f@elisabeth> In-Reply-To: <20241129224946.2664970-1-jmaloy@redhat.com> References: <20241129224946.2664970-1-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KCnf85xT2UQhE0iI1NE8Xdmopfb1eCvaWvjjfPh0P_I_1732924663 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: TLWPKLVSM34DQY7XZRUUSUUGKMJZCMTA X-Message-ID-Hash: TLWPKLVSM34DQY7XZRUUSUUGKMJZCMTA X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, lvivier@redhat.com, dgibson@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 29 Nov 2024 17:49:46 -0500 Jon Maloy wrote: > During testing it is sometimes useful to force traffic which would > normally be forwared by socket splicing through the tap interface. > > In this commit, we add a command switch enabling such funtionality > for inbound local traffic. > > For outbound local traffic this is much trickier, if even possible, > so leave that for a later commit. > > Suggested-by: David Gibson > Signed-off-by: Jon Maloy > > --- > v2: Some minor changes based on feedback from PASST team > --- > conf.c | 5 +++++ > fwd.c | 2 +- > passt.h | 2 ++ > 3 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/conf.c b/conf.c > index 5107549..fe6fa04 100644 > --- a/conf.c > +++ b/conf.c > @@ -846,6 +846,7 @@ static void usage(const char *name, FILE *f, int status) > " --no-ndp Disable NDP responses\n" > " --no-dhcpv6 Disable DHCPv6 server\n" > " --no-ra Disable router advertisements\n" > + " --no-splice Disable inbound socket splicing\n" I think this really needs an update to the man page as David mentioned. We don't have any undocumented option (as far as I know!) and I don't think it would be a particularly good idea to start now... -- Stefano