From: Stefano Brivio <sbrivio@redhat.com>
To: Jon Maloy <jmaloy@redhat.com>
Cc: passt-dev@passt.top, lvivier@redhat.com, dgibson@redhat.com
Subject: Re: [PATCH v3] pasta: make it possible to disable socket splicing
Date: Tue, 3 Dec 2024 23:07:39 +0100 [thread overview]
Message-ID: <20241203230739.6f2fb4d2@elisabeth> (raw)
In-Reply-To: <20241203215302.3773941-1-jmaloy@redhat.com>
On Tue, 3 Dec 2024 16:53:02 -0500
Jon Maloy <jmaloy@redhat.com> wrote:
> diff --git a/passt.1 b/passt.1
> index b2896a2..c8a5783 100644
> --- a/passt.1
> +++ b/passt.1
> @@ -695,6 +695,10 @@ Configure MAC address \fIaddr\fR on the tap interface in the namespace.
>
> Default is to let the tap driver build a pseudorandom hardware address.
>
> +.TP
> +.BR \-\-no-splice
> +Disable socket splicing for host to NS traffic.
It's not necessarily clear to users what "NS" is: we never use it in
the man page. To keep this quick, if you agree, I would fix this up on
merge with:
.TP
.BR \-\-no-splice
Disable the bypass path for inbound, local traffic. See the section \fBHandling
of local traffic in pasta\fR in the \fBNOTES\fR for more details.
Everything else looks good to me.
--
Stefano
next prev parent reply other threads:[~2024-12-03 22:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 21:53 [PATCH v3] pasta: make it possible to disable socket splicing Jon Maloy
2024-12-03 22:07 ` Stefano Brivio [this message]
2024-12-04 2:09 ` David Gibson
2024-12-05 20:06 ` Stefano Brivio
2024-12-05 22:34 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241203230739.6f2fb4d2@elisabeth \
--to=sbrivio@redhat.com \
--cc=dgibson@redhat.com \
--cc=jmaloy@redhat.com \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).