From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SNUVXhoS; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 0DB7B5A061E for ; Tue, 03 Dec 2024 23:07:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733263668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6MSar9TwTNoA910yOc8B0CzEGKOvsgA1XrEca0NURi8=; b=SNUVXhoS4bMJRmlzgqcHLOR60C84B0JyenMl1fdNw2vEQhcN4u/5auviBYTQuM5UIQi8zk DphfSqnFTgI8U8ZGJxa3yoTWdULTanZ9gzQlnjrpj8tGoI1WREP92ugj0TivlKa/mq3LCT LmZfovtVXSCz8F0FvlRod/H7wo2ckfk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-403-OqIgPf5vPxirEUmy19_Nvg-1; Tue, 03 Dec 2024 17:07:47 -0500 X-MC-Unique: OqIgPf5vPxirEUmy19_Nvg-1 X-Mimecast-MFC-AGG-ID: OqIgPf5vPxirEUmy19_Nvg Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-434a04437cdso44483075e9.2 for ; Tue, 03 Dec 2024 14:07:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733263665; x=1733868465; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6MSar9TwTNoA910yOc8B0CzEGKOvsgA1XrEca0NURi8=; b=wI+q78re/w6aDlnBDuBZkXvZK223Z4w3Mpf1RNf0c7pxBSRSPu1gve2oIprowC9Sy5 J1kZvS46O1ODv6fN8GQ19ebiBvGqCTp/y4ugh22RjApQmMSzo6SH/av03yaiYUmRsO5k c7ruIxweOYAThYbY908ewL7uxJnFdGWSqWy0Tf8RmT0VfWGdJZveCptNs0vLIjGyvSIF XsuzRvoII1mGB4+Yo6DZqtrRZd/NzJuyz7CtNUHAifM+Q37MG/5yvgSprWWTL7QUUb7S jCAignGgvpdmUovOtHcXk5OYwjUqDkLk4ob/1xCmvlHI4/zqbIkAyY6sziRUl8jpD5Ok duJQ== X-Gm-Message-State: AOJu0YzfOURcdW/LesZHi4B5k3e7WT75gyxMgKUQHvjBkXTdDtDCE9pq BmSLw4vSehR01B1T18pbLfFbrqiui9cJBdsaZ5iToKo2eVQccwouIXbLLV8xmCDovBwtLnu8m4U YFgKjlW3nxHg0SbZq92Wxo8eJaV3+f9FCLim2QbocrERAeEFrcW7OqcGEnKHJaUSFjcVLVp83bc 67GjD2xmy9PfNeasERYuLxUTQmVIVsIkJ+ X-Gm-Gg: ASbGncusAzvUH0tcOY9K3cbVwasw2LTKemMKLJalx8JRlrrAvUnEzuMy4mFea/4NTQr aztnlm2y17OI1T2f3agQSE2coc/lLRF9AiPEwg53IH33hdKSB/6J+/Y7lAJkHkfSIL/+PF/DiGA F+FpclxSabIOXJBMHKy7VKzZs/15kH+ClLTGOyO++VQeCzX/vTRIb9wPcSln9+0od/35UHDCE2w epDKEbMRGTL6m/LxOCMqS5vFKHp/6pDCrVuDZ0rY5UjEF7ys5ThSdwqnS8Zpw== X-Received: by 2002:a05:600c:1f8f:b0:434:a396:9474 with SMTP id 5b1f17b1804b1-434d09cbe39mr37888465e9.18.1733263665274; Tue, 03 Dec 2024 14:07:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IHp+DZrGCtNDbwCHGUJakLvMJ4wvtRXz5xiGUMEizMoihOvCqbNqe96sDwJdWIfh6zTDrw+4A== X-Received: by 2002:a05:600c:1f8f:b0:434:a396:9474 with SMTP id 5b1f17b1804b1-434d09cbe39mr37888285e9.18.1733263664833; Tue, 03 Dec 2024 14:07:44 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385db37debdsm15345927f8f.2.2024.12.03.14.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 14:07:43 -0800 (PST) Date: Tue, 3 Dec 2024 23:07:39 +0100 From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v3] pasta: make it possible to disable socket splicing Message-ID: <20241203230739.6f2fb4d2@elisabeth> In-Reply-To: <20241203215302.3773941-1-jmaloy@redhat.com> References: <20241203215302.3773941-1-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: E6TVqUr4nilnsLoNCk7Ann_GVgatYlZP9zX-lSaSdX0_1733263666 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: TAOAPBLGTQM3PU5667KQ7TTU5XQAOLBS X-Message-ID-Hash: TAOAPBLGTQM3PU5667KQ7TTU5XQAOLBS X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, lvivier@redhat.com, dgibson@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 3 Dec 2024 16:53:02 -0500 Jon Maloy wrote: > diff --git a/passt.1 b/passt.1 > index b2896a2..c8a5783 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -695,6 +695,10 @@ Configure MAC address \fIaddr\fR on the tap interface in the namespace. > > Default is to let the tap driver build a pseudorandom hardware address. > > +.TP > +.BR \-\-no-splice > +Disable socket splicing for host to NS traffic. It's not necessarily clear to users what "NS" is: we never use it in the man page. To keep this quick, if you agree, I would fix this up on merge with: .TP .BR \-\-no-splice Disable the bypass path for inbound, local traffic. See the section \fBHandling of local traffic in pasta\fR in the \fBNOTES\fR for more details. Everything else looks good to me. -- Stefano