From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FFcF1C8l; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id E0C765A004E for ; Thu, 05 Dec 2024 22:46:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733435214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q3sDuP1/XRaNcD9ObV5FQIgIcaRz2TrRn8xqZ6TdDzc=; b=FFcF1C8lMIIyCuFZrNuQkVba1d1GUyOdTlU6/hcL9FlWuOS5SfmufBs+dO0PjO2w1WxQtM xTpgFRiqb+JNcfoRiDsduqTKYunJ7Logs0aB86Pjv8HhjY4PBg8Fartn97uCk7FjCbCPS+ Mj0aW0Y/+KD7Vf/ygnm2gNxyRTDDzB0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-616-kPdPjOvWPaiBx_hRl4E6cQ-1; Thu, 05 Dec 2024 16:46:53 -0500 X-MC-Unique: kPdPjOvWPaiBx_hRl4E6cQ-1 X-Mimecast-MFC-AGG-ID: kPdPjOvWPaiBx_hRl4E6cQ Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-434a4ad78a1so11492195e9.0 for ; Thu, 05 Dec 2024 13:46:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733435211; x=1734040011; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=q3sDuP1/XRaNcD9ObV5FQIgIcaRz2TrRn8xqZ6TdDzc=; b=HZ0dJBtis+VodBUGe/oIClU/dYddPb/saLg0Q2ru5Y/SsuMoBCSEJrcxk4euBDTFh+ ss19iuoiNuBrWUvSHjyrpzG0zf0a4CJ9JhnBmYUGXr8piLvikeBq5BF3exEbh9acorCS rlFpOOKMUZrjnhprcBh7RW4KIkBQCw9ZeN71lSBngy2RXvz+OCyPsTSc6q4nKUlw2Csh Y0IjS5zGG589JoAIk2TChF0OH4af0OuCNLQDJtHuRyB/IJmQvwNfCfykLkU9R07tcVgA 6yb0zVCuaZn7Xcfsha0VcXCXTN4NC7Ie7a3AhLUtbhFEQ+QZqzE/WZtETMfxEfbPQsLp RtdQ== X-Gm-Message-State: AOJu0YwWI8LkFXO/snk3isfNhNJfkqcz2dqLf8ROEUMOUEPbjuZ19Xbh C5suIq7/MnxYpqRSVLUBXOt3jhx7w18fJouOVbDh4lDTUXkjd6pL9CP4x6FhXdEnDI3tvfn5xTS z1wKEttxlImAmwL6KwaN5aWtuASuB1/mklKJs4t3o8MJTbuAxYpNT7hnYxP6oC4DLKFuyxQ1lCE UwUQCJp6U2sDTz4Rz/1QpV0ImK2TmTG2/+ X-Gm-Gg: ASbGncsOzljrdeKwQfmexE+oAqZkojK3H/JW2S7LtOPWSj59GRr+QlCKANO6iDg/h9e LR2he0q3Cdcj9+3HbWe335Q683KsDgmXwpNuQOmqxdZPfrWgbdHm/FdwytimxgOp85jRTLxa9pm Pf4qpSbs5n20Hat9qH+XPi+EtjQq4KUHMfgc5eQ/ZjqmyMlA7kOISBVkzy9kAlIrkziaSY0lTGD HJeRE8wifzwC+7ZMTCPOdDaeYJbDiinXbCy9tLl4X6Hqkj0TsT+ifpGOywnww== X-Received: by 2002:a7b:cd07:0:b0:431:3933:1d30 with SMTP id 5b1f17b1804b1-434df0d3a67mr115325e9.5.1733435211398; Thu, 05 Dec 2024 13:46:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IG0tTePrpTud0IFKa+Y3p4WrOhQNvECYytYxFj5ice3aP2PnyW5zUvAAPWR9t2ocgrdKyD2Yw== X-Received: by 2002:a7b:cd07:0:b0:431:3933:1d30 with SMTP id 5b1f17b1804b1-434df0d3a67mr115175e9.5.1733435210959; Thu, 05 Dec 2024 13:46:50 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434d52cbd5asm72678415e9.40.2024.12.05.13.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2024 13:46:50 -0800 (PST) Date: Thu, 5 Dec 2024 22:46:48 +0100 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v2] udp_vu: update segment size Message-ID: <20241205224648.651825ed@elisabeth> In-Reply-To: <20241205073718.6914-1-lvivier@redhat.com> References: <20241205073718.6914-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3foCH_euk3shHP2c3NNIxj1H9njfOA9FbwKQhOcj13E_1733435212 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: OJ353O4MVNSD5PT5CEIFUJ7FH3SJVT6L X-Message-ID-Hash: OJ353O4MVNSD5PT5CEIFUJ7FH3SJVT6L X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 5 Dec 2024 08:37:18 +0100 Laurent Vivier wrote: > In udp_vu_sock_recv(), collect a segment with a size defined to > IP_MAX_MTU + ETH_HLEN + sizeof(struct virtio_net_hdr_mrg_rxbuf) > > The original version double counted the IP header: IP_MAX_MTU includes > the IP header, and so did hdrlen. > > Signed-off-by: Laurent Vivier Applied. -- Stefano