From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=c8Il+H3w; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 7908C5A061B for ; Wed, 11 Dec 2024 13:09:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733918943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gFor2K2WxrcOKhiIwNCMV0do9sVgtfZd1CcI/8Oxrlc=; b=c8Il+H3wu9gAVIPz817Tt2rlEJXkdDG2Agn48y8VgRPJLykJKx87Z7vXIFBUQutLUtuEFH Q3Lde4io8yWr8Mo5k9OMiexSLP2wCGPs6TDjie+hBHtQdwXJPX24rJEoOKS3DfegTJhle9 8mXh+YkwexZPg/JYN6Dj6iX0btyGcfo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-510-SvSv3zdjNQGZLhElEDj7VQ-1; Wed, 11 Dec 2024 07:02:45 -0500 X-MC-Unique: SvSv3zdjNQGZLhElEDj7VQ-1 X-Mimecast-MFC-AGG-ID: SvSv3zdjNQGZLhElEDj7VQ Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-434f852cb35so2748995e9.0 for ; Wed, 11 Dec 2024 04:02:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733918564; x=1734523364; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gFor2K2WxrcOKhiIwNCMV0do9sVgtfZd1CcI/8Oxrlc=; b=n0me0J2/Qt/y2Vw2mVX5gxG3H5wAPTO3/TmeN5vMEsz9vPQAtfjNW4LXXvT1t9fQ13 hDWdnhc04A/tuBeG9joycXVRSWS9VxMa60FA9VAKwWY/xim9t21AtXZuF5KVaf9r/L+X g2bb+m6PaumHGuX88KQh2Zck0mduQXRPAwA+9jF6eoxlrrwYSivGe5fjM2dZgWnd3AZB FUIP2XNCo3ncY5nMf45tqdjFn9w7aJNbRBj1i8iNS0fPnSk8+9iyKuqk6K59x6EaL3u3 NjE4w6oD2T2LGcSFsJSLt2BFJXavmoVBWybURHU2tynaYdVlt6WOhxs1wSU6Cc5xJBJ6 rrwA== X-Forwarded-Encrypted: i=1; AJvYcCUQvjee/+6UlAH6f2dSo5v2bPz4KmrAmUFEbu/qzd6Zx5rchzaiG4zQhL8UUYz+IkB3241Wd7o+nw4=@passt.top X-Gm-Message-State: AOJu0Yxdi3+MVfQ6+0We/05r+89supKDlD3m2nN55ZkYvqfYolOH9oxZ CmjCY1dHJmSMCdnaT5HkB+1MjuKbYeMoh5qRdFIFQhoQRUCrNnMopLlEfoKNTMwk+hwsbqyt0zv p3y3bYwv1zJeRKgHCUVFRieYzHENtwr3yaUT8+kC5KAr5qnPZfg== X-Gm-Gg: ASbGncvx+Eo56EwADFK7sq3LwJ/CSySsQYL/f1xGV0Yyd1JFjyyYBRTJw9xYJF3X+6L AXIYTDzO/Tb8+TbQG9YACiIWxJSAAXv438AXXl865gInJ2iZk6X7QPt4G9BOt1r4h0Glfyk2waz RhMY3W7OTQceQa3h8324UZyfoONOcGRQwSTEqelCsekpKvrqaclV67B2PnCITRWIetiktkontrD La1pjK34z/jMCrt3zSDalG1ZEart8a4+wTRPaFgo09IY7ezB9fBfQvgwaXObF40Gg== X-Received: by 2002:a05:600c:1c1c:b0:434:a350:207c with SMTP id 5b1f17b1804b1-4361c3f4cbcmr18545695e9.23.1733918564554; Wed, 11 Dec 2024 04:02:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IG7iqoP3nCcYEzxsuk/9R+hyuyBXYKt6aYwL8OzzgbR44BwwEGW4QzhKx1MNRVAib2D/ah1Jg== X-Received: by 2002:a05:600c:1c1c:b0:434:a350:207c with SMTP id 5b1f17b1804b1-4361c3f4cbcmr18545425e9.23.1733918564148; Wed, 11 Dec 2024 04:02:44 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434fc530a2dsm83235645e9.11.2024.12.11.04.02.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2024 04:02:43 -0800 (PST) Date: Wed, 11 Dec 2024 13:02:41 +0100 From: Stefano Brivio To: Paul Holzinger Subject: Re: [PATCH] treewide: Dodge dynamic memory allocation in strerror() from glibc > 2.40 Message-ID: <20241211130241.4dda23af@elisabeth> In-Reply-To: <570332c8-fd8d-4447-9091-00244b0db164@redhat.com> References: <20241210232909.1034903-1-sbrivio@redhat.com> <20241211014641.27e438ca@elisabeth> <570332c8-fd8d-4447-9091-00244b0db164@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6Dpb_Rle1Gxiqimx-O0oMi7w-gakFaSQvKk4YAm3nI0_1733918565 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: WFFURGFKHV4BFIG6IX7DBBKUUMOM4JNO X-Message-ID-Hash: WFFURGFKHV4BFIG6IX7DBBKUUMOM4JNO X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 11 Dec 2024 11:36:20 +0100 Paul Holzinger wrote: > On 11/12/2024 04:55, David Gibson wrote: > >> I wonder if ignoring the locale is really that bad. After all, we print > >> all the messages in English, without localisation. Printing the error > >> description in other languages is arguably inconsistent. > > Hm, I guess. Maybe we can tackle respecting locale for the kernel > > library errors when/if we add localisation support for our own > > messages. > > As German who has a few systems with a German locale configured I prefer > it when the locale is ignored in such cases. Getting a mixed > English/German error text always looks wrong and I much rather have it > only in English. But then again I understand English and these error > messages well enough already so users who do not might feel differently. I'm a native speaker of Italian not picking Italian locales (so that "others" understand, and to avoid witnessing abuses on Italian), but setting LC_PAPER="en_GB.UTF-8" and LC_MEASUREMENT="en_GB.UTF-8" which are otherwise wrong (nobody should send envelopes with fingers inside). I find two small advantages of translated locales in error reports: in some cases they might give you a rough indication of the user's timezone, and they usually make me giggle. Oh, and I know how to say "drain pipe" (not really "pipe") in a number of languages, by now. Other than that they are hard to grep, possibly harder to translate by an automatic agent, and they are inconsistent. For desktop environments, distribution installers, "proper" user interfaces, I totally see the inclusiveness advantage of translated messages. Otherwise not really. -- Stefano