From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202412 header.b=lM+XOT0h; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id E985F5A0275 for ; Fri, 13 Dec 2024 13:02:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202412; t=1734091323; bh=8d+awcmlkWiG1AJQCy/0UxhaV53i4Eo7Su5+U06tKb8=; h=From:To:Cc:Subject:Date:From; b=lM+XOT0hanwg461J7lM2vDvs7inuKlxKmSRWuuKaaZI4BxWnIgIS2LZTpvHePe/rR 16SNajLdEyBl2MSOqTWYiO/WhrRoBsuZy7l1SaJ+W3zlovVQCjvm9OCOOHOOk618Xv sJrFvWpBtT26CxYbt5KEGYPXIz58u9+8cesdNe3M7MX1o0Fn6KnGmHLTcbngVyXNxf dNwLD4leFrYsn4rLEq+T5G+MyE4Ba15BG90gdPtkt+pg3dx+HFDKz9pDbqzXNcp/Ne GiYi4jLhkZK5j39UpXVeTtOeL5wDG1lguGM/CNMzYDsVag5I+MKFOVywJCtpn7ddR6 ayw981GnMGDnw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Y8ny36T9Qz4wc3; Fri, 13 Dec 2024 23:02:03 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 0/3] Cleanups to packet pool handling and sizing Date: Fri, 13 Dec 2024 23:01:53 +1100 Message-ID: <20241213120156.4123972-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.47.1 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: ZCJFLARN2TN5FDYXY3QCV3GYLQHRBLWP X-Message-ID-Hash: ZCJFLARN2TN5FDYXY3QCV3GYLQHRBLWP X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This... is not any of the things I said I would be working on. I can only say that a herd of very hairy yaks led me astray. Looking at bug 66 I spotted some problems with our handling of MTUs / maximum frame sizes. Looking at that I found some weirdness and some real, if minor, bugs in the sizing and handling of the packet pools. David Gibson (3): packet: Use flexible array member in struct pool packet: Don't have struct pool specify its buffer tap: Don't size pool_tap[46] for the maximum number of packets packet.c | 63 ++++++---------------------------------------------- packet.h | 41 ++++++++++++---------------------- passt.h | 2 -- tap.c | 63 +++++++++++++++++++++++++--------------------------- tap.h | 4 ++-- vhost_user.c | 2 -- vu_common.c | 31 ++------------------------ 7 files changed, 55 insertions(+), 151 deletions(-) -- 2.47.1