From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iQMkrrvG; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 951D35A004E for ; Thu, 19 Dec 2024 15:23:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734618181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yAfEuw8A0NmU8G3Xoht/ifZ2PGtxA+TkL7FHuDlBitE=; b=iQMkrrvGyYCvz5He3F4zbo+TbHJ4mQ4R7DyPnvVZgkw6gMDHJg7RBTffTvFoCkV5wa+9i3 MAMCbOF9iI5elne2F7JN7iU8tBWkd/nptLGwMzE2VkcQ1OzC7ANSI+xgdQZtbK1GZN+U/l KuaJ2XXm8VTvhGUfKGKPcddMU6ZaOgc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-135-bssk48hFNs6k_sG9RR61fw-1; Thu, 19 Dec 2024 07:06:06 -0500 X-MC-Unique: bssk48hFNs6k_sG9RR61fw-1 X-Mimecast-MFC-AGG-ID: bssk48hFNs6k_sG9RR61fw Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43628594d34so4328075e9.2 for ; Thu, 19 Dec 2024 04:06:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734609963; x=1735214763; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yAfEuw8A0NmU8G3Xoht/ifZ2PGtxA+TkL7FHuDlBitE=; b=C2MZXkwrIgju+paIqCMtoLlHmekwO6NlZbNuADuX0q6EghxXi5CcIFjcN5QUQb5Zcb 0ArkZtKm/XClGc05tWs3xgoay19V2YPIxx/Libp8aytY7d/VlBsjXWZr1Fg/saLdr9Zc GX0xrtca4mWz3ig4g9UwgIUJ0kcFm3KMCB9wHJZSZOjIewuRC1LJ2cghpI32WJOKCrOo 3Gci9Ka+d5t9MtN6raSzkPqhJGNV/SB+rSJZ5CLX7l0m0ttDGaJZbcNvSs6OhxqES/Du +T1HmBViijRu4KoslzwFZTW82AvVTSF+dAOCREOJxBYLPD7sNt/Df9MIoOpEj4Ns/Tlm KRlw== X-Gm-Message-State: AOJu0Yz5sDqelPPN3UIySW2ogk9ha9pubxlJIeWm7bGSElqWtJKJsTZS 8PNulrhETLFqmJ4w4MvhmCES8Xfwz2b3Nwkj+805rAVExaguOVTdOnqGZaWgDCzXUBhueJ/GwGi 0ry2Mh0eLhPaM0SxKelh+MsAsH1a93rEM70HQVe1uqkyCusbeFg4xtxWslfLQv3y0dFgi13uiAZ 9UELKy2kSKuzb1/PSdw79EqpMkPNAg3Q9+ X-Gm-Gg: ASbGncuvSh+sn9E5Nmvo5YrGgYnHcLFU3OjfOyEpKev2Hzdo4DUAfbDRebnBho1nqBV XbTP3XGkhqOSYAtBFzT9Zud1HmjObEQQHAZLF5BeMMfCUveZc2MimHL05Tphx2p4kCpJ45HUhe4 OIYpMxWwemLGD/D5D5NhtUT/4ECfAbZn5y5P6ygmhkO9qZcFxf1a/LjH3Sc8vh9pMVtqHB9o3Er nATdVgAdQwXI0n6YDF66FP9fxzGpeGFyL8baTJN46hlHy7HpjLIHu91jkFUdKmyR6jU X-Received: by 2002:a05:600c:524b:b0:436:488f:4f3 with SMTP id 5b1f17b1804b1-4365c793990mr28977395e9.17.1734609963107; Thu, 19 Dec 2024 04:06:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGLwzRnIE9Ng7DQFQq4idYZlzlWGH+mZPnrOQx1AFS7SEa9NuFm+O/d4O105dJy2rUHIulGXg== X-Received: by 2002:a05:600c:524b:b0:436:488f:4f3 with SMTP id 5b1f17b1804b1-4365c793990mr28976955e9.17.1734609962677; Thu, 19 Dec 2024 04:06:02 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c829297sm1454297f8f.4.2024.12.19.04.06.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2024 04:06:01 -0800 (PST) Date: Thu, 19 Dec 2024 13:06:00 +0100 From: Stefano Brivio To: Enrique Llorente Pastora Subject: Re: [PATCH v4] dhcp, dhcpv6: Add hostname and client fqdn ops Message-ID: <20241219130600.4bc5e79b@elisabeth> In-Reply-To: References: <20241217065028.23718-1-ellorent@redhat.com> <20241218003454.4a4cbc8b@elisabeth> <20241219011933.071cd876@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JXRO_cr3zqaVSMV3ZlY-QqhqbKDK7YmPi2Da5QabJTk_1734609965 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: OQ2DUTF4NW5F4C6V3DWQSHWVLMNDBIHR X-Message-ID-Hash: OQ2DUTF4NW5F4C6V3DWQSHWVLMNDBIHR X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 19 Dec 2024 12:51:27 +0100 Enrique Llorente Pastora wrote: > On Thu, Dec 19, 2024 at 1:19=E2=80=AFAM Stefano Brivio wrote: > > > I guess we could have it as a define (OPT_MAX_SIZE?), no need to have > > it in any struct. > > > > By the way, note that we have MAX() defined in util.h, so you don't > > need a condition and a separate statement, you can just do: =20 >=20 > I am going to create a new OPT_MAX_SIZE with the computation and also a n= ew > IPV6_MIN_MTU to be part of it and use that later on with MIN. Sorry, MIN, of course, not MAX! --=20 Stefano