From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 00/12] Cleanups to packet pool handling and sizing
Date: Fri, 20 Dec 2024 19:35:23 +1100 [thread overview]
Message-ID: <20241220083535.1372523-1-david@gibson.dropbear.id.au> (raw)
This... is not any of the things I said I would be working on. I can
only say that a herd of very hairy yaks led me astray. Looking at bug
66 I spotted some problems with our handling of MTUs / maximum frame
sizes. Looking at that I found some weirdness and some real, if
minor, bugs in the sizing and handling of the packet pools.
Changes in v2:
* Stefano convinced me that packet_check_range() is still worthwhile.
* So don't remove it... but in looking at it I spotted various
flaws in the checks, so address those in a number of new patches.
David Gibson (12):
test focus
hack: stop on fail, but not perf fail
make passt dumpable
packet: Use flexible array member in struct pool
packet: Don't pass start and offset separately too
packet_check_range()
packet: Don't hard code maximum packet size to UINT16_MAX
packet: Remove unhelpful packet_get_try() macro
util: Add abort_with_msg() and ASSERT_WITH_MSG() helpers
packet: Distinguish severities of different packet_{add,git}_do()
errors
packet: Move packet length checks into packet_check_range()
tap: Don't size pool_tap[46] for the maximum number of packets
packet: More cautious checks to avoid pointer arithmetic UB
dhcpv6.c | 2 +-
ip.c | 2 +-
isolation.c | 2 +-
packet.c | 106 ++++++++++++++++++++++----------------------------
packet.h | 19 ++++++---
passt.h | 2 -
tap.c | 18 +++++++--
tap.h | 3 +-
test/lib/term | 1 +
test/lib/test | 4 +-
test/run | 38 +++++++++---------
util.c | 19 +++++++++
util.h | 25 +++++-------
vu_common.c | 34 ++++++++++------
14 files changed, 153 insertions(+), 122 deletions(-)
--
2.47.1
next reply other threads:[~2024-12-20 8:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 8:35 David Gibson [this message]
2024-12-20 8:35 ` [PATCH v2 01/12] test focus David Gibson
2024-12-20 8:35 ` [PATCH v2 02/12] hack: stop on fail, but not perf fail David Gibson
2024-12-20 8:35 ` [PATCH v2 03/12] make passt dumpable David Gibson
2024-12-20 8:35 ` [PATCH v2 04/12] packet: Use flexible array member in struct pool David Gibson
2024-12-20 8:35 ` [PATCH v2 05/12] packet: Don't pass start and offset separately too packet_check_range() David Gibson
2024-12-20 8:35 ` [PATCH v2 06/12] packet: Don't hard code maximum packet size to UINT16_MAX David Gibson
2025-01-01 21:54 ` Stefano Brivio
2025-01-02 1:00 ` David Gibson
2025-01-02 21:59 ` Stefano Brivio
2025-01-03 1:16 ` David Gibson
2025-01-05 23:43 ` Stefano Brivio
2025-01-08 1:48 ` David Gibson
2024-12-20 8:35 ` [PATCH v2 07/12] packet: Remove unhelpful packet_get_try() macro David Gibson
2025-01-01 21:54 ` Stefano Brivio
2025-01-02 2:15 ` David Gibson
2025-01-02 22:00 ` Stefano Brivio
2025-01-03 4:48 ` David Gibson
2025-01-06 10:55 ` Stefano Brivio
2025-01-08 4:44 ` David Gibson
2024-12-20 8:35 ` [PATCH v2 08/12] util: Add abort_with_msg() and ASSERT_WITH_MSG() helpers David Gibson
2024-12-20 8:35 ` [PATCH v2 09/12] packet: Distinguish severities of different packet_{add,git}_do() errors David Gibson
2025-01-01 21:54 ` Stefano Brivio
2025-01-02 2:58 ` David Gibson
2025-01-02 22:00 ` Stefano Brivio
2025-01-03 5:06 ` David Gibson
2025-01-06 10:55 ` Stefano Brivio
2025-01-08 4:53 ` David Gibson
2024-12-20 8:35 ` [PATCH v2 10/12] packet: Move packet length checks into packet_check_range() David Gibson
2024-12-20 8:35 ` [PATCH v2 11/12] tap: Don't size pool_tap[46] for the maximum number of packets David Gibson
2025-01-01 21:54 ` Stefano Brivio
2025-01-02 3:46 ` David Gibson
2025-01-02 22:00 ` Stefano Brivio
2025-01-03 6:06 ` David Gibson
2025-01-07 22:56 ` Stefano Brivio
2024-12-20 8:35 ` [PATCH v2 12/12] packet: More cautious checks to avoid pointer arithmetic UB David Gibson
2024-12-20 9:00 ` [PATCH v2 00/12] Cleanups to packet pool handling and sizing David Gibson
2024-12-20 10:06 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241220083535.1372523-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).