From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Dpifu6ep; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 53E535A0272 for ; Fri, 20 Dec 2024 11:06:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734689208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZR+LEsxqj23c/JV6ZwjbC/ONY33xRqCMkFQBzBsDHR8=; b=Dpifu6epWPbFSXH0ltm3G0U/OFutRrRf0gvM/J5/kv4MHLmsxSUuCMIOd5kPhlyFxhjGrB xoEdEHyJcILQ2hqiEwyhMFkVoc6UbO3RIoPOs8D36Yi3/uxeuYSpEAOh8k0PnjMZjazIGS yAfbF+RU3eSFGwhQyRLtYjSW1ojzR+g= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-348-xZRHhE3lPvyDiaGHqUUPFA-1; Fri, 20 Dec 2024 05:06:46 -0500 X-MC-Unique: xZRHhE3lPvyDiaGHqUUPFA-1 X-Mimecast-MFC-AGG-ID: xZRHhE3lPvyDiaGHqUUPFA Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-385e4a759e6so1225005f8f.1 for ; Fri, 20 Dec 2024 02:06:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734689205; x=1735294005; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZR+LEsxqj23c/JV6ZwjbC/ONY33xRqCMkFQBzBsDHR8=; b=d3Geuvu2isU48FT8Us57ZNXve7NyWsgpCakymCTMdvoqVVeM6pM9t3EH+Vu51LCDuC K2CakrpDVbFmK4y4wnToznWJkez5XpuKub35wmj7piFh4W29I38mJn8B1QPOfeeGRZQr rXZEtkaNUs95FVeCw8k7Rj4G/c1zKGX57hkkAbZWmUGXJI/ugzOuX3+sRTfB0U5qT/WH 2uR65kbTmoDEs7gOw/n1XE2AZcpXhujvO5L3yqfeZf0oUFvd2mfZd255X6bV/o+2rvD/ 0RLoXTy30SuNLonDsAT2wdg18LSWdbHmlbUlIw82AdNuQzAXpETq/YjrTsFJvX5kwtid 2naQ== X-Gm-Message-State: AOJu0YzoVh7uRNJF7he3ZbdOw6pWxZybstqbSaz2i0NMOdcX0MU4w7HK ytm2eshGziwXcoOfFGe/rQDAdM/aQiC0RtwWxIpdqHegOZIGx7M+AXkD5xQ9IRn9g69IxheDlW0 iM+KyBerX7LatoGhDBpb/uKFz0WmmBEPJNbAZIAJVpZk7Of7f8Q== X-Gm-Gg: ASbGnctyu0JqMpKtF5QT8d6KrupDjqJDAyfAKKECvHeRv1oG8+YDefxfrRgr+M0MFPi K59KPqAJL5lUlhFiLD5xlk8o7cbj5Wub7syHlNERx/jKGrDdMphgwhFWzBHI/mcj0BUt4ier43h YQG0lF++Lsco0PCK+e4EpJKIxkplIJalMDcrCoeyXcvguq2FeXIyIHGz1lP/BPKYrTJfEpNRbDo wKT5GYIbKJBq3Kmo/mdUOLPxD61Cbry3GOpQ0VNfHVt3XZgpfwkgr7FP7ypULPN3KJMHzN1TfTd 3wUaf7tXTA== X-Received: by 2002:a5d:584e:0:b0:385:e5d8:3ec2 with SMTP id ffacd0b85a97d-38a221f9c94mr2341397f8f.28.1734689205313; Fri, 20 Dec 2024 02:06:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IH3USQKxIUvFvK7Bu0BLiv7L2V2YFLyxa1eX8wpIKGGfGoP87E7uibyCNar2AJ5tL0wpT39zA== X-Received: by 2002:a5d:584e:0:b0:385:e5d8:3ec2 with SMTP id ffacd0b85a97d-38a221f9c94mr2341362f8f.28.1734689204972; Fri, 20 Dec 2024 02:06:44 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e357sm3751983f8f.72.2024.12.20.02.06.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2024 02:06:44 -0800 (PST) Date: Fri, 20 Dec 2024 11:06:42 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 00/12] Cleanups to packet pool handling and sizing Message-ID: <20241220110642.65ef36d5@elisabeth> In-Reply-To: References: <20241220083535.1372523-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Za1GeEEFfPEysDVC8AQltOnwSftwwyRHSAyRoRqjQQQ_1734689205 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: M2QRP2CN4VRKVV4W2FPHOCZT7YW2IG4A X-Message-ID-Hash: M2QRP2CN4VRKVV4W2FPHOCZT7YW2IG4A X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 20 Dec 2024 20:00:13 +1100 David Gibson wrote: > On Fri, Dec 20, 2024 at 07:35:23PM +1100, David Gibson wrote: > > This... is not any of the things I said I would be working on. I can > > only say that a herd of very hairy yaks led me astray. Looking at bug > > 66 I spotted some problems with our handling of MTUs / maximum frame > > sizes. Looking at that I found some weirdness and some real, if > > minor, bugs in the sizing and handling of the packet pools. > > > > Changes in v2: > > * Stefano convinced me that packet_check_range() is still worthwhile. > > * So don't remove it... but in looking at it I spotted various > > flaws in the checks, so address those in a number of new patches. > > > > David Gibson (12): > > test focus > > hack: stop on fail, but not perf fail > > make passt dumpable > > Argh, oops. Of course, 1..3 are test/debug patches that should not be > included in the series. Yeah, it's fine, 4/12 to 12/12 apply cleanly anyway. -- Stefano