From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Myu9+KpY; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 16C395A0271 for ; Fri, 10 Jan 2025 09:55:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736499329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OUicLsKZE/58zo+JeClwEb1vVWEw/dj2SVbq7P39cuQ=; b=Myu9+KpYonBiZ75oiqU/Zg0xjzz2acpx/mrcy1HZXUYZHyDVkZdbdsYbK8c5g50BDkAhkb bww+HQnCriI66T32NDsrPaPWTlOcG4nMgEWAi3/S7fX+/4VNlPIN/aHVp2H3XtR2gq6Avp b7yTrol3M456GfLlOZ9Z5HeMBPeLf8c= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-S7VdXYE2NWSvbeqcjrmGEA-1; Fri, 10 Jan 2025 03:55:28 -0500 X-MC-Unique: S7VdXYE2NWSvbeqcjrmGEA-1 X-Mimecast-MFC-AGG-ID: S7VdXYE2NWSvbeqcjrmGEA Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-385d735965bso1519807f8f.1 for ; Fri, 10 Jan 2025 00:55:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736499327; x=1737104127; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OUicLsKZE/58zo+JeClwEb1vVWEw/dj2SVbq7P39cuQ=; b=MJnBF0ZqBqzCU6ItDqvByZ2JixR4b0UA8aZy/yrFnosTNihCy3OZ39KrB9rHTGxU8y GQQkbUMkFoGM2S6tM4ScXSc0Jcvzcz3UtRvJGQHD6CHBYHAIkJ+uI0y/QV3YIra+3uF9 jO0/2U7tL6yEJE/bPX2XNDAQIDMNnx0z9PSh0EB2m5D5S6e/sVkoSCNGLUPEBrCENPkk i2Xd/Ho74iDBzCRER9dWkub2MPQmpf2O05crJ1fjANbv/QziDlNKXw0xZZ4k9D+psRKr QlAQcKhVa9+d8hMjDe/eJyaa+O8FKzLJ7cyNFIjzSz+nKAWYsA3CzkcOJFaqMRKycm2x yYuQ== X-Forwarded-Encrypted: i=1; AJvYcCUzzlvK8F90uvLj73Yrluzq0CQHAwQwmLGW/ZKsNwhha5q0xnoti7JjtK1Yf8uhS76qHO7fg2HbzLw=@passt.top X-Gm-Message-State: AOJu0Yxw/LQ6+6l1ibF4nk6F/QkGYO01C1SaB7ZTjBjbXEeV+sHUGgNo 0hJ5yVnaJe0Dwt9QW/KEsjfE+6oabHZuLJqKGwU52aDIk371orZsn5IDzU1gk204UwJp0FMufTl A0WakZQ4Q01GYYIWzTkd8lSFAl5BmIXOIJmsc5fLmPOGHchB8Zw== X-Gm-Gg: ASbGnct6s0C9VklAinDn6WVLvJOKwcl2QiNQ136QZ7u/ty+wKsYIawoArr8lkC90OYj 3RIRab+C/5+uIlFUQ0YuWp62hBtYWiXqwb8CnkYb1kN2xrO2HEElUF8u1cPqzqjH3N/w3GaVy6E OGpF1jT7aq1i/m/1HK+2mnc6fd7iSpMbQzjqsTlGVhtZOt43ocMeaP84HB7EJWZDU72A+ONd3Dv cgA2ufyxCqfwnHJHZ/mbrI5DUdrC+Nsh3ykGrb+BBGCh9lXnrnqz0TkbL5ud5QC88/oSFx3/NOM YhiAC1V0tg== X-Received: by 2002:a05:6000:144d:b0:388:e377:8a1b with SMTP id ffacd0b85a97d-38a8730cc78mr8867353f8f.28.1736499326887; Fri, 10 Jan 2025 00:55:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IE0YzUNRWFoG8pZgdlrMMvkK8l2A9HH8T4pXR9OgOh1ZcX2YfNJYKY6dNkLla/d9Eht8mjKdQ== X-Received: by 2002:a05:6000:144d:b0:388:e377:8a1b with SMTP id ffacd0b85a97d-38a8730cc78mr8867317f8f.28.1736499326425; Fri, 10 Jan 2025 00:55:26 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9e62126sm45390085e9.34.2025.01.10.00.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 00:55:25 -0800 (PST) Date: Fri, 10 Jan 2025 09:55:23 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] checksum: fix checksum with odd base address Message-ID: <20250110095523.78874f61@elisabeth> In-Reply-To: References: <20250109130648.326933-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FoOrmPmn5k7E-uh_HiSCnwgdp6FYmTT3ne11NAeSVCw_1736499327 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: O5MHSDHA7OGP2ZU35WXM5N2IGM4V2ARC X-Message-ID-Hash: O5MHSDHA7OGP2ZU35WXM5N2IGM4V2ARC X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 10 Jan 2025 13:40:28 +1100 David Gibson wrote: > That said, I think we can do a bit better long term: I believe it > should be possible to correct the value from the of-by-one > csum_avx2(), I think with just an unconditional byteswap. See also https://bugs.passt.top/show_bug.cgi?id=108#c16, but I'm not so sure it's "a bit better". -- Stefano