From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=U9mq29qT; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 6E3655A0271 for ; Fri, 10 Jan 2025 10:00:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736499601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MXkR0EwUFs0KKUweORlqeq8CONAVqGNnGdkYViyqcd0=; b=U9mq29qTL+FaomX3aVmcKBjB9wEg4aQP0KEQq6WQoLE0RFHv7ShQu13v9vQHazT1JKrno2 UyDwVCtYGeHgmNRpGDzchyvFXI4mM3Wx7qQqDyjO4McFBdeaNHXxHMKC9riPAFJ2XIssV8 NyyuOMYlC0A1b8CdTDlSyR4RkDTSUZc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-10-sIeCebIQN6-hMrpYGDEDdQ-1; Fri, 10 Jan 2025 04:00:00 -0500 X-MC-Unique: sIeCebIQN6-hMrpYGDEDdQ-1 X-Mimecast-MFC-AGG-ID: sIeCebIQN6-hMrpYGDEDdQ Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-385d735965bso1523731f8f.1 for ; Fri, 10 Jan 2025 01:00:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736499598; x=1737104398; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MXkR0EwUFs0KKUweORlqeq8CONAVqGNnGdkYViyqcd0=; b=XZGYtpggboNph3tHt0bRyr1kmYKRd8LPrHTbiQf8vhl3gX1hCSpe9JxpkCb2MSKx86 PLl1voHRQRtKW/t8RK1vBYaOyjE6Zad0yfOy+cyE/wSO0AvmxgIbGvZNnBlC8wuFNKlW hWMv+P4i4QKaRe8lgU6uKZiu3jSATmfEvWIV5LYha2nsDk+zfPZCpJvOiBz5fJNVOblo BxCGgs306ek4uC+NWqk1U/HBV9IrFlKIq1Y1SB0UxHoSxrmy1Mg3/He3yGsV1ocznfxo JQNWsfN6eHb05YtpjgnWxRYX25FEjxC8vJcha2/jos+rL4seb7BEWAY0vafWttBQQy13 a5xA== X-Gm-Message-State: AOJu0YzqKFSfSRq00EHSOCy1erZ4jFcH3adS3gqsMV3mh5vtQX1UUeFX kAOeU6lMRKmeVg5KGPwxql0CGf5hTl9ogaKTZ1EmZmSvK5KaT6SvxQAbgMtyfHKX0yJwjJ9zkgz En1E4efr116ezjKAJa6Uza4orh151vXqLisxGx+8yumFeGU4bGs95saXk4lk4PSGftA7GWpdLzc L3coHVS6A9IVvMAk1odsBxJCr66X5jj2cP X-Gm-Gg: ASbGncuWfzSkgxVnioTbrdEWATPTlax7pqZ54TwRnvfBOLAHlDnXwHw6zUZ9+7leqd7 COn5izBZjgkB3XIh4Y+LRRyS6qL/UbqIccfGfWcxUIlBn1xBHyrLhX7clDIySYcIvBNSFJricMy zyCu6xWMWcBZ10ypKrH3+w/NMjhFGSmV/1eEUH2Bnsl5TVkyCNmxrrDa8m37uzDeLCP7FKYAoRR MQ1az2DjT/TqtdyVKYYza8D52mDMmjNKrOj+jPxDdLyLx07jGbuRHP6nZauFPRjAB5w6owe0YJe MvtuOQUv+Q== X-Received: by 2002:a05:6000:470d:b0:385:fd07:8616 with SMTP id ffacd0b85a97d-38a870877c4mr9471080f8f.0.1736499598009; Fri, 10 Jan 2025 00:59:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFmYQTZ30TA9PCFV21kjoG8k6vi1B7sPBhpAzJcxnU8+V/vIcbboRIK5tt/5L5XM8T1MAT2EQ== X-Received: by 2002:a05:6000:470d:b0:385:fd07:8616 with SMTP id ffacd0b85a97d-38a870877c4mr9471051f8f.0.1736499597580; Fri, 10 Jan 2025 00:59:57 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9e03f54sm45665925e9.21.2025.01.10.00.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 00:59:56 -0800 (PST) Date: Fri, 10 Jan 2025 09:59:55 +0100 From: Stefano Brivio To: Enrique Llorente Pastora Subject: Re: [PATCH v7] dhcp, dhcpv6: Add hostname and client fqdn ops Message-ID: <20250110095955.11024478@elisabeth> In-Reply-To: References: <20250108145811.833308-1-ellorent@redhat.com> <20250109091631.03fefb0e@elisabeth> <20250109143358.334ef58a@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vTC2y-Jxg14CwNRncusjMPt2cy5fgPsQxh-PD2dHcak_1736499599 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: DM6ILW4XP4FOVZOJLOHD552OWKLFS7GX X-Message-ID-Hash: DM6ILW4XP4FOVZOJLOHD552OWKLFS7GX X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 10 Jan 2025 09:39:09 +0100 Enrique Llorente Pastora wrote: > On Thu, Jan 9, 2025 at 2:34=E2=80=AFPM Stefano Brivio wrote: > > > > On Thu, 9 Jan 2025 13:57:38 +0100 > > Enrique Llorente Pastora wrote: > > =20 > > > Also I have to move the list buffer or I will be storing it at the > > > first element. > > > encoded_name_len =3D encode_domain_name(srch->list + srch->hdr.l, > > > NS_MAXDNAME, > > > c->dns_search[i= ].n, > > > name_len); =20 > > > > Oh, right. I didn't test this. Can't you just follow along where you > > are with 'offset'? I'm not sure, I didn't look into it. =20 >=20 > I cannot use offset since it's initialize with + header >=20 > offset +=3D sizeof(struct opt_hdr); Right, but doesn't that need to point to where we want to write anyway? That will be after the header, so it's good that it's past the header. Again, I didn't try this. --=20 Stefano