From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by passt.top (Postfix, from userid 1000) id 41EE45A0272; Thu, 16 Jan 2025 21:32:50 +0100 (CET) From: Stefano Brivio To: passt-dev@passt.top Subject: [PATCH 2/4] tcp: Don't subscribe to EPOLLOUT events on STALLED Date: Thu, 16 Jan 2025 21:32:48 +0100 Message-ID: <20250116203250.784496-3-sbrivio@redhat.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250116203250.784496-1-sbrivio@redhat.com> References: <20250116203250.784496-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: URYZ2PJ44R5ID2GLUXMWHTQJKZ7KMIQT X-Message-ID-Hash: URYZ2PJ44R5ID2GLUXMWHTQJKZ7KMIQT X-MailFrom: sbrivio@passt.top X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Asahi Lina , Sergio Lopez , Jon Maloy , David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I inadvertently added that in an unrelated change, but it doesn't make sense: STALLED means we have pending socket data that we can't write to the guest, not the other way around. Fixes: bb708111833e ("treewide: Packet abstraction with mandatory boundary checks") Signed-off-by: Stefano Brivio --- tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcp.c b/tcp.c index 72fca63..ef33388 100644 --- a/tcp.c +++ b/tcp.c @@ -437,7 +437,7 @@ static uint32_t tcp_conn_epoll_events(uint8_t events, uint8_t conn_flags) return EPOLLET; if (conn_flags & STALLED) - return EPOLLIN | EPOLLOUT | EPOLLRDHUP | EPOLLET; + return EPOLLIN | EPOLLRDHUP | EPOLLET; return EPOLLIN | EPOLLRDHUP; } -- 2.43.0