From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Z3/LtNYW; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id C49715A061C for ; Fri, 17 Jan 2025 15:29:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737124187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8MX/I1gpaO21LarlE9Fn4Q9xvvDyNpiCTWpotYyfOBo=; b=Z3/LtNYW6UcjJpbk+zJkZNislAROmLl1lk1JmwPiKO8cvfXug6wAH7EDB1KPJCaB3avSbB HcOOA2kUYKovdve0Jh5c84yokoRjm3Gzh5/xV8P0lloUv3MQDGzLSz1uYc9Fx+chrtZ+Yn tY9Q/to5nkSMRQrdTQ8aS9Ews5w00gE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-mxI5usDXMomk8ykmzHlsUw-1; Fri, 17 Jan 2025 09:29:46 -0500 X-MC-Unique: mxI5usDXMomk8ykmzHlsUw-1 X-Mimecast-MFC-AGG-ID: mxI5usDXMomk8ykmzHlsUw Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-436723db6c4so15736605e9.3 for ; Fri, 17 Jan 2025 06:29:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737124184; x=1737728984; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8MX/I1gpaO21LarlE9Fn4Q9xvvDyNpiCTWpotYyfOBo=; b=MNGsZPxDXZHxowyTIaK+lGMnQqV2pz7CCasU0MZXsT4SQXpjZuFLpFUkWxRi7ASX8z w4yeNg9dAhDut4jn0NodHk7OofPWlOMANhFV7SB+fzBZHt64xgVS3lVraxjlCWWnb4nH zyHGxnUMgAVCCssHB8uNiXi+HQ5FUYSoLrOh67lYG2u3Xid/++0IeZekT0/5K4hXnjrZ SE42yw6S8DX71zswIEVCgoBPnPbz/IboL08rAoKgpnOfdozpeZCC/RAPRx5CydDxQAo9 8BU0CWRwQSpDCEhavZDxEg/3j+vcC6Br79KepRthYO90boENb1OIzYy4y0Uy9JMn4Ymd XW7Q== X-Gm-Message-State: AOJu0YzFirhL8LV8kn92f0Hhx3zIiiUFXuxxAfZ73GYi+wd9fPKpN46E 0icrXSIdGScpEUdi15tvofMsWXf4IdlHDtxgfoqhdg0xlWTq2Bz2Xzkjw4+LqWk4snbJdJMfX69 iyHyiWAYaQR+3SZ6dWKvGUrexAgy7uC8d7SOvsqpqpZsRdGqh2tQgOdV+ZXo0cXn+JLqWMEaAOc OaQCY8RcQld1n5nVSMm75xCq5Z7sVlaPSg X-Gm-Gg: ASbGncu3xLc/+rCrGnKpaU6LOC4gk+er3uus/LbBfwT58k0tzUtoSS1G+DqwnipeG0h q7jiTeFOp8BjHrf0FBdEYqCEyLySu9xek1zy5tofa7/UOw+UNnjCOxvgoOcBNLjxxg1nlp9SBJx AqQ8H6WdrOg+bbVrokmuvKr9usCV+NlZiR6+4lRc3lDBeSv77jyohMlHrtpEzO6wertVBzIpgNV /4f4zH3nUkQEKaovhkmPrM9j6nsb5j2mvxVVfuU5h0M1SPcK3Ed6o3fFpQ/3kmbvuVm X-Received: by 2002:a05:600c:46cb:b0:436:1b96:7072 with SMTP id 5b1f17b1804b1-438913bebe7mr32257655e9.5.1737124184625; Fri, 17 Jan 2025 06:29:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IFNU+CvoyUYHzW3IqPPgMIKmB/VoCKWUbG27JMsiUDw30AuWlipkQNoafjAMCwNuVNq7D3ZIA== X-Received: by 2002:a05:600c:46cb:b0:436:1b96:7072 with SMTP id 5b1f17b1804b1-438913bebe7mr32257455e9.5.1737124184274; Fri, 17 Jan 2025 06:29:44 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438904131easm34634535e9.12.2025.01.17.06.29.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2025 06:29:43 -0800 (PST) Date: Fri, 17 Jan 2025 15:29:41 +0100 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH 0/9] vhost-user: Migration support Message-ID: <20250117152941.10a86ca2@elisabeth> In-Reply-To: <96f413e1-462f-4417-bd5c-ca80a72e326c@redhat.com> References: <20241219111400.2352110-1-lvivier@redhat.com> <329e349d-f86c-479b-97ee-61397aa28c60@redhat.com> <20250117134445.5b341bdd@elisabeth> <20250117143829.7e861cac@elisabeth> <96f413e1-462f-4417-bd5c-ca80a72e326c@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tzsnqcUyC_RG30-x5yQLPQQDBkY3s9LkJvxCMbXz4us_1737124185 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 7H47I4WTRSCJ4WZ5X3C7SF3MIUQFJG5R X-Message-ID-Hash: 7H47I4WTRSCJ4WZ5X3C7SF3MIUQFJG5R X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 17 Jan 2025 14:58:31 +0100 Laurent Vivier wrote: > On 17/01/2025 14:38, Stefano Brivio wrote: > >> So we can implement VHOST_USER_SEND_RARP with an empty function (at least to silence the > >> "Vhost user backend fails to broadcast fake RARP" message). > > Oh, sure, if it's so annoying. And we can't just keep > > VHOST_USER_PROTOCOL_F_RARP off in the feature flags? > > VHOST_USER_PROTOCOL_F_RARP is already off in passt. > > So vhost_user_migration_done() returns -ENOTSUP in QEMU. > > And then in vhost_user_receive(): > > r = vhost_net_notify_migration_done(s->vhost_net, mac_addr); > > if ((r != 0) && (display_rarp_failure)) { > fprintf(stderr, > "Vhost user backend fails to broadcast fake RARP\n"); Looks like a bug, right? If we don't support it we can't fail, I would say. Well, but sure, given how annoying it might get, it makes sense to work around it regardless of whether it can be fixed. -- Stefano