From: Stefano Brivio <sbrivio@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 2/9] vhost-user: update protocol features and commands list
Date: Fri, 17 Jan 2025 19:04:50 +0100 [thread overview]
Message-ID: <20250117190450.1681e7ee@elisabeth> (raw)
In-Reply-To: <20241219111400.2352110-3-lvivier@redhat.com>
On Thu, 19 Dec 2024 12:13:53 +0100
Laurent Vivier <lvivier@redhat.com> wrote:
> vhost-user protocol specification has been updated with
> feature flags and commands we will need to implement migration.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> vhost_user.c | 5 +++++
> vhost_user.h | 46 ++++++++++++++++++++++++++++++++++++++++++----
> 2 files changed, 47 insertions(+), 4 deletions(-)
>
> diff --git a/vhost_user.c b/vhost_user.c
> index 4b8558fa851f..48226a8b7686 100644
> --- a/vhost_user.c
> +++ b/vhost_user.c
> @@ -110,6 +110,11 @@ static const char *vu_request_to_string(unsigned int req)
> REQ(VHOST_USER_GET_MAX_MEM_SLOTS),
> REQ(VHOST_USER_ADD_MEM_REG),
> REQ(VHOST_USER_REM_MEM_REG),
> + REQ(VHOST_USER_SET_STATUS),
> + REQ(VHOST_USER_GET_STATUS),
> + REQ(VHOST_USER_GET_SHARED_OBJECT),
> + REQ(VHOST_USER_SET_DEVICE_STATE_FD),
> + REQ(VHOST_USER_CHECK_DEVICE_STATE),
> };
> #undef REQ
> return vu_request_str[req];
> diff --git a/vhost_user.h b/vhost_user.h
> index 464ba21e962f..fbacb5560755 100644
> --- a/vhost_user.h
> +++ b/vhost_user.h
> @@ -37,6 +37,10 @@ enum vhost_user_protocol_feature {
> VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD = 12,
> VHOST_USER_PROTOCOL_F_INBAND_NOTIFICATIONS = 14,
> VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS = 15,
> + VHOST_USER_PROTOCOL_F_STATUS = 16,
> + /* Feature 17 reserved for VHOST_USER_PROTOCOL_F_XEN_MMAP. */
> + VHOST_USER_PROTOCOL_F_SHARED_OBJECT = 18,
> + VHOST_USER_PROTOCOL_F_DEVICE_STATE = 19,
>
> VHOST_USER_PROTOCOL_F_MAX
> };
> @@ -83,6 +87,11 @@ enum vhost_user_request {
> VHOST_USER_GET_MAX_MEM_SLOTS = 36,
> VHOST_USER_ADD_MEM_REG = 37,
> VHOST_USER_REM_MEM_REG = 38,
> + VHOST_USER_SET_STATUS = 39,
> + VHOST_USER_GET_STATUS = 40,
> + VHOST_USER_GET_SHARED_OBJECT = 41,
> + VHOST_USER_SET_DEVICE_STATE_FD = 42,
> + VHOST_USER_CHECK_DEVICE_STATE = 43,
> VHOST_USER_MAX
> };
>
> @@ -128,12 +137,39 @@ struct vhost_user_memory {
> struct vhost_user_memory_region regions[VHOST_MEMORY_BASELINE_NREGIONS];
> };
>
> +/**
> + * struct vhost_user_log - Address and size of the shared memory region used
> + * to log page update
> + * @mmap_size: Size of the shared memory region
> + * @mmap_offset: Offset of the shared memory region
> + */
> +struct vhost_user_log {
> + uint64_t mmap_size;
> + uint64_t mmap_offset;
> +};
> +
> +/**
> + * struct vhost_user_transfer_device_state - Set the direction and phase
> + * of the backend device state fd
> + * @direction: Device state transfer direction (save or load)
> + * @phase: Migration phase (only stopped is supported)
> + */
> +struct vhost_user_transfer_device_state {
> + uint32_t direction;
> +#define VHOST_USER_TRANSFER_STATE_DIRECTION_SAVE 0
> +#define VHOST_USER_TRANSFER_STATE_DIRECTION_LOAD 1
> + uint32_t phase;
> +#define VHOST_USER_TRANSFER_STATE_PHASE_STOPPED 0
> +};
> +
> /**
> * union vhost_user_payload - vhost-user message payload
> - * @u64: 64-bit payload
> - * @state: vring state payload
> - * @addr: vring addresses payload
> - * vhost_user_memory: Memory regions information payload
> + * @u64: 64-bit payload
> + * @state: vring state payload
> + * @addr: vring addresses payload
> + * @vhost_user_memory: Memory regions information payload
> + * @vhost_user_log: Memory logging payload
> + * @vhost_user_transfer_device_state: Device state payload
Nit: these are called 'memory', 'log', and 'transfer_state'.
> */
> union vhost_user_payload {
> #define VHOST_USER_VRING_IDX_MASK 0xff
> @@ -142,6 +178,8 @@ union vhost_user_payload {
> struct vhost_vring_state state;
> struct vhost_vring_addr addr;
> struct vhost_user_memory memory;
> + struct vhost_user_log log;
> + struct vhost_user_transfer_device_state transfer_state;
> };
>
> /**
--
Stefano
next prev parent reply other threads:[~2025-01-17 18:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 11:13 [PATCH 0/9] vhost-user: Migration support Laurent Vivier
2024-12-19 11:13 ` [PATCH 1/9] virtio: Use const pointer for vu_dev Laurent Vivier
2024-12-20 0:24 ` David Gibson
2025-01-06 8:58 ` Stefano Brivio
2024-12-19 11:13 ` [PATCH 2/9] vhost-user: update protocol features and commands list Laurent Vivier
2025-01-17 18:04 ` Stefano Brivio [this message]
2024-12-19 11:13 ` [PATCH 3/9] vhost-user: add VHOST_USER_SET_LOG_FD command Laurent Vivier
2025-01-17 18:04 ` Stefano Brivio
2024-12-19 11:13 ` [PATCH 4/9] vhost-user: Pass vu_dev to more virtio functions Laurent Vivier
2024-12-19 11:13 ` [PATCH 5/9] vhost-user: add VHOST_USER_SET_LOG_BASE command Laurent Vivier
2025-01-17 18:05 ` Stefano Brivio
2025-01-20 10:57 ` Laurent Vivier
2025-01-17 19:10 ` Stefano Brivio
2024-12-19 11:13 ` [PATCH 6/9] vhost-user: Report to front-end we support VHOST_USER_PROTOCOL_F_LOG_SHMFD Laurent Vivier
2024-12-19 11:13 ` [PATCH 7/9] vhost-user: add VHOST_USER_CHECK_DEVICE_STATE command Laurent Vivier
2024-12-19 11:13 ` [PATCH 8/9] vhost-user: add VHOST_USER_SET_DEVICE_STATE_FD command Laurent Vivier
2024-12-19 19:47 ` Stefano Brivio
2024-12-20 7:56 ` Laurent Vivier
2024-12-20 13:28 ` Stefano Brivio
2025-01-17 18:05 ` Stefano Brivio
2025-01-20 11:00 ` Laurent Vivier
2025-01-20 20:09 ` Stefano Brivio
2024-12-19 11:14 ` [PATCH 9/9] vhost-user: Report to front-end we support VHOST_USER_PROTOCOL_F_DEVICE_STATE Laurent Vivier
2025-01-17 12:13 ` [PATCH 0/9] vhost-user: Migration support Laurent Vivier
2025-01-17 12:44 ` Stefano Brivio
2025-01-17 13:27 ` Laurent Vivier
2025-01-17 13:38 ` Stefano Brivio
2025-01-17 13:58 ` Laurent Vivier
2025-01-17 14:29 ` Stefano Brivio
2025-01-17 13:31 ` Stefano Brivio
2025-01-17 16:51 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250117190450.1681e7ee@elisabeth \
--to=sbrivio@redhat.com \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).