From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RKW//kF4; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 762FD5A061D for ; Fri, 17 Jan 2025 20:10:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737141024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YBGZhh+k0U10Sun1Zzuj0Lmr7HDU9sRqAgajQ7iObuk=; b=RKW//kF48YZLjXztHVl/UN7hKBxE0EWan1YPod5oVS0Zaqb1dj1lcx/Fc+11RGnvX032GM EypMI8ucq2CBh2Z3qkipjYh8B0hCChkwLb7SxARg7+1dL6i/BHJCFn48MJNYYTCaf9/uk1 Cj7SpsEmQPz8zChFSEh8/Tb+DdN28fs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-kAKL1i-lNc2pVb3adluZxg-1; Fri, 17 Jan 2025 14:10:23 -0500 X-MC-Unique: kAKL1i-lNc2pVb3adluZxg-1 X-Mimecast-MFC-AGG-ID: kAKL1i-lNc2pVb3adluZxg Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3862e986d17so1035007f8f.3 for ; Fri, 17 Jan 2025 11:10:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737141021; x=1737745821; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YBGZhh+k0U10Sun1Zzuj0Lmr7HDU9sRqAgajQ7iObuk=; b=q+gWaDPBFYxh1i7GUaV26DA7m6Mx9U+6d0R+0Zz8DidFD9IMCZtb5EVQL7G4IY5kAT Nu+FjcLErryXuxtXK9GitU+P9jx+OzOQAC31+SOWWislDKmWvOc8KOYCftaBI8w/gPmE 4F9EEriH5+BRIVsnwvVvjueW2BG2hBb4SmgmfL5J2dBloPtpLgxzsyK0CWb5T+w1D3+b NpMAr1aXIiiDxRuGnxlIfijReFzJo4bQIkXgotTVekAp4FCPpuuLXzHxbAEgMAdwJZTH b/eJynM23I0DR2yGK0KhrDlVzUVIoGJnaXXyo3ZjC3XPqRYn0fOt0Fdl7gbqbj08U55e s9Pw== X-Gm-Message-State: AOJu0YxclzpbfUocCyvMOFCTJdY+MJLQZmu3JkJF0OtUDl90ye2fq1rK 3JMzP0PDbS76GS6KZtjsG0Dlj4ZVIX5VMRa8WVRIeeDNk/naGLlLf1aJrsjiiQURxfQKR95fNPX EML5Eb3fYkGXwcYFMVEcjm52yKYe3921yB9HbgDuHYeGit9Fkcxu+nHxPl3QZVf4HFLgG8VkR2C ZSjVjw1GaneGi5ebjZtU2eQQFyxtlOgPZy X-Gm-Gg: ASbGncsJPGebNiMmT9jK8JH0ITkeFYP0w96COiIfUXtBc5smhcrdyrGcOuAnkQi4E8h vtoxI+M4ZYuY4VjfOWsgbjfFu11XK7i9Jp1BR3IFo0tmWPpmVfMnqACxZ9iOWbci2Cw9bWvUNaN x+58A6wwO6e7APlggbsm0znGBeKhn8isjT50OmlGUJsBq/hIow5Tz2EMYzRcXqLzIIuRvSITeGa 1h9/qTUj+/wPbdJysRA5a7u3B+mzTXU81Rvzla25frmOLpTCQZv2+LJHSBuiuAb75cAQlueku4n vj7n5BgeFw== X-Received: by 2002:a05:6000:2ce:b0:385:e2c4:1f8d with SMTP id ffacd0b85a97d-38bf565f06bmr3506810f8f.19.1737141021295; Fri, 17 Jan 2025 11:10:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFgzxDjtRJAC9eb92qEy/H7R9QiPVMmvA1k1QJ+iajlEDw3F3TJZoY6mBxsyvwwHsjMZUWwdQ== X-Received: by 2002:a05:6000:2ce:b0:385:e2c4:1f8d with SMTP id ffacd0b85a97d-38bf565f06bmr3506790f8f.19.1737141020966; Fri, 17 Jan 2025 11:10:20 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf32221a8sm3251686f8f.37.2025.01.17.11.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2025 11:10:20 -0800 (PST) Date: Fri, 17 Jan 2025 20:10:18 +0100 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH 5/9] vhost-user: add VHOST_USER_SET_LOG_BASE command Message-ID: <20250117201018.5ed35ecc@elisabeth> In-Reply-To: <20241219111400.2352110-6-lvivier@redhat.com> References: <20241219111400.2352110-1-lvivier@redhat.com> <20241219111400.2352110-6-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qgQKYSj7me2orG9FJq9N36iX2-HzPJlbqBRCHF5N4JY_1737141022 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: G5UYDZT3PQUBVQEEYVVFEHTDYPB7TLBI X-Message-ID-Hash: G5UYDZT3PQUBVQEEYVVFEHTDYPB7TLBI X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: By the way, pre-existing, but I just realised that: On Thu, 19 Dec 2024 12:13:56 +0100 Laurent Vivier wrote: > +/** > + * vu_set_log_base_exec() - Set the memory log base > + * @vdev: vhost-user device > + * @vmsg: vhost-user message > + * > + * Return: False as no reply is requested > + * > + * #syscalls:vu mmap munmap ...on glibc and (at least) armv6l, we don't have mmap(), it's mmap2() only, so this (and the one later in this file) should be: #syscalls:vu mmap|mmap2 munmap I think it's safe to assume that architectures with mmap() will use that, and the ones without will use mmap2() (which, by the way, doesn't exist on x86_64). -- Stefano