From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CDxQ3RUW; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 68BF95A0274 for ; Mon, 20 Jan 2025 21:02:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737403369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j2K8JHm1+S+Mq5QBfxj/IPSZqh3uIe3Qc3o+DWaTW54=; b=CDxQ3RUWESSYoLevbcw+VEgZuuwg9QScdAUQjMURmIRLe4x0SI3sj5dPkhWF6W6u4MZVKZ ufZeoi/P3SOTHqu6RVJ/dEI+tSueaZxMWPAdQ4bW5EIovHXXQVSkPhGqKuseTikAWXqs4N fBsz9GjzuRxIxjvpBh6bR15d4YBLacA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-4xjSXZ8lPOyjQy6Nd66PjA-1; Mon, 20 Jan 2025 15:02:47 -0500 X-MC-Unique: 4xjSXZ8lPOyjQy6Nd66PjA-1 X-Mimecast-MFC-AGG-ID: 4xjSXZ8lPOyjQy6Nd66PjA Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4362b9c1641so23559215e9.3 for ; Mon, 20 Jan 2025 12:02:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737403365; x=1738008165; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=j2K8JHm1+S+Mq5QBfxj/IPSZqh3uIe3Qc3o+DWaTW54=; b=TzlakVdGBh9mncu8h9el7d3x9x6Tuj+pYjK9AZXP5IUrn/A29DYro0mzOR50D8VRWB PG7Mn8ln3JZhV829bYfBBc6z/f+TMtX4TafVDtHMW9B3RvVkvj2amRyhKUWFBGLVZH9f RSb00SGzT65D3SRpQBFjn9Tdsapgs29xjxxK3yNRvP2cp1kH/eWcVwwWR/EOnDvFt1FU jCzmPGNZKJ/GaSYDHDXRde647CI2iCPJue9YqH/rClOLKbbkLGLISKM2epurNiPE24t1 4E5T/8/VDQmgrrQE5TgTIyEpi3+uoWH8HCxhs74NCD19KvPTBxbZpcqrcDe3//lA1BOf XdBA== X-Gm-Message-State: AOJu0Yxrk9MXb+Nf5OUOjx2WCv4CjAYvHEHaAvB9wyCNoIHUC/tG1yXl /kqXX4S7jZOl9iqZEaXba//3ROJVcC91cpHB8lNjKfqXLmGT1mWXzdpBWEDcsuHkDptF9lqH9gz 4G0eLsgv6978pJJMueplaGvvlngKn+XDVtLnGbaRBj8EPdMHUlPox/zZuC0mCrchPJuseP2XSsx 3sy+Uw0d/DbpDjtEE872HUOTgZkAuv/WC/Fys= X-Gm-Gg: ASbGnctQX6e/eCs/gXR6C3XNAtD9aqytLfTtFX1UzaTmbRIv7b28anOMGsXd20G2Oum ss4W97xZmzKg6EtzDxGjYW1EiliwOM8FRq1FLJk4wGwDXj53B1tP8PpR6yI5OegdU0GkpxQXQhG G34FEAEzcXJFOdNk08+IFbx309QV949xZLjyJKPy16RZNMnm+bJPFcFAtzPiTb1imvo+E8P7mzH uJwAmKkhsoGmSp2dB+9m4DyCz/V8sMlKjJOQK02lr1O+5F5f6UI0y+oOLE9hmxSkb4wUXv8eUay eSDQcYh8gInOGHXArTpP3hs= X-Received: by 2002:a05:600c:b8a:b0:434:a386:6ae with SMTP id 5b1f17b1804b1-438913cae53mr138795745e9.7.1737403365405; Mon, 20 Jan 2025 12:02:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+zPPFaFTibKHHrD5tgTg8SDolE1JtNfgqD/T8FLcyUrnRIYKqgDxiFWYI3aSHPoKmnvcPbw== X-Received: by 2002:a05:600c:b8a:b0:434:a386:6ae with SMTP id 5b1f17b1804b1-438913cae53mr138795465e9.7.1737403364961; Mon, 20 Jan 2025 12:02:44 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43890413053sm154085115e9.10.2025.01.20.12.02.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 12:02:44 -0800 (PST) Date: Mon, 20 Jan 2025 21:00:41 +0100 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH] vhost_user: remove ASSERT() on iovec number Message-ID: <20250120210000.1de61b67@elisabeth> In-Reply-To: <20250120131522.1053992-1-lvivier@redhat.com> References: <20250120131522.1053992-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: URYQ7wNRPBZodB-GVe0PAWFZh3jyZBLpNVHdVWebcQo_1737403367 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: FDQTBMVTSOHJJDDZGX476RHHU6N4EGSI X-Message-ID-Hash: FDQTBMVTSOHJJDDZGX476RHHU6N4EGSI X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 20 Jan 2025 14:15:22 +0100 Laurent Vivier wrote: > Replace ASSERT() on the number of iovec in the element and on > the first entry length by a debug() message. > > Signed-off-by: Laurent Vivier > --- > vu_common.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/vu_common.c b/vu_common.c > index 431fba6be0c0..d34ae6dc1df3 100644 > --- a/vu_common.c > +++ b/vu_common.c > @@ -195,8 +195,12 @@ static void vu_handle_tx(struct vu_dev *vdev, int index, > hdrlen); > } else { > /* vnet header can be in a separate iovec */ > - ASSERT(elem[count].out_num == 2); > - ASSERT(elem[count].out_sg[0].iov_len == (size_t)hdrlen); > + if (elem[count].out_num != 2) > + debug("virtio-net tranmit queue contains more than one buffer ([%d]: %u)", s/tranmit/transmit/ Applied with this change. -- Stefano