From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Laurent Vivier <lvivier@redhat.com>, passt-dev@passt.top
Subject: Re: [PATCH] vhost_user: remove ASSERT() on iovec number
Date: Tue, 21 Jan 2025 13:18:31 +0100 [thread overview]
Message-ID: <20250121131831.6a265b4b@elisabeth> (raw)
In-Reply-To: <Z48ZhGinqp2QSveQ@zatzit>
On Tue, 21 Jan 2025 14:20:28 +1030
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Mon, Jan 20, 2025 at 02:15:22PM +0100, Laurent Vivier wrote:
> > Replace ASSERT() on the number of iovec in the element and on
> > the first entry length by a debug() message.
> >
> > Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>
> Removing the ASSERT() makes sense, but is it safe to carry on to the
> tap_add_packet() if the packet is not in the layout we expect?
Safe for us and for TCP yes, but it's bad to mangle UDP packets like
that.
> Should we be bailing out of the function (effectively dropping the packet)
> instead?
I even proposed that in:
https://archives.passt.top/passt-dev/20250115233302.23b24862@elisabeth/
and forgot about it during review. :(
This is applied now. Laurent, a follow-up patch would be appreciated.
--
Stefano
prev parent reply other threads:[~2025-01-21 12:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 13:15 [PATCH] vhost_user: remove ASSERT() on iovec number Laurent Vivier
2025-01-20 20:00 ` Stefano Brivio
2025-01-21 3:50 ` David Gibson
2025-01-21 12:18 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121131831.6a265b4b@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).