public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: Jon Maloy <jmaloy@redhat.com>, Eric Dumazet <edumazet@google.com>,
	Neal Cardwell <ncardwell@google.com>,
	netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
	passt-dev@passt.top, lvivier@redhat.com, dgibson@redhat.com,
	eric.dumazet@gmail.com, Menglong Dong <menglong8.dong@gmail.com>
Subject: Re: [net,v2] tcp: correct handling of extreme memory squeeze
Date: Mon, 27 Jan 2025 11:32:14 +0100	[thread overview]
Message-ID: <20250127113214.294bcafb@elisabeth> (raw)
In-Reply-To: <CAL+tcoBwEG_oVn3WL_gXxSkZLs92qeMgEvgwhGM0g0maA=xJ=g@mail.gmail.com>

On Mon, 27 Jan 2025 18:17:28 +0800
Jason Xing <kerneljasonxing@gmail.com> wrote:

> I'm not that sure if it's a bug belonging to the Linux kernel.

It is, because for at least 20-25 years (before that it's a bit hard to
understand from history) a non-zero window would be announced, as
obviously expected, once there's again space in the receive window.

> The other side not sending a window probe causes this issue...?

It doesn't cause this issue, but it triggers it.

> The other part of me says we cannot break the user's behaviour.

This sounds quite relevant, yes.

-- 
Stefano


  reply	other threads:[~2025-01-27 10:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17 21:40 [net,v2] tcp: correct handling of extreme memory squeeze jmaloy
2025-01-17 22:09 ` Eric Dumazet
2025-01-17 22:27   ` Stefano Brivio
2025-01-18 17:01 ` Jason Xing
2025-01-18 20:04 ` Neal Cardwell
2025-01-20  5:03   ` Jon Maloy
2025-01-20 16:10     ` Jon Maloy
2025-01-20 16:22       ` Eric Dumazet
2025-01-24 17:40         ` Jon Maloy
2025-01-27  9:53           ` Eric Dumazet
2025-01-27 10:01           ` Stefano Brivio
2025-01-27 10:06             ` Eric Dumazet
2025-01-27 10:27               ` Stefano Brivio
2025-01-27 10:17             ` Jason Xing
2025-01-27 10:32               ` Stefano Brivio [this message]
2025-01-27 13:37                 ` Menglong Dong
2025-01-27 14:03                   ` Stefano Brivio
2025-01-27 16:37           ` Eric Dumazet
  -- strict thread matches above, loose matches on Subject: below --
2025-01-16  2:29 [net, v2] " Jon Maloy
2025-01-16 21:14 ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250127113214.294bcafb@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dgibson@redhat.com \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jmaloy@redhat.com \
    --cc=kerneljasonxing@gmail.com \
    --cc=kuba@kernel.org \
    --cc=lvivier@redhat.com \
    --cc=menglong8.dong@gmail.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).