From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cuRfbGNI; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id C6E475A061C for ; Tue, 28 Jan 2025 07:48:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738046910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jSlNU7nyai9fjgHDHErirOmSvVkrx2AkeS5X0IjvK4c=; b=cuRfbGNIQELVp7LnwqnSqYEnfcyOqeIAVC4X4bgoFrN4BD1543zxWQNa4FbdX5SJR3BKsI s0l5tqycpnKzL8xf5l7FWgle2E2YAI8WkZfExl8VdT8evhkKdn88jgEUTyR6gUORB8vkOc fHS5hjiac6uYBFsI5wkM4ENkhQBY+tA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-q_QQ-9uHMb2uuTNfD2S5zg-1; Tue, 28 Jan 2025 01:48:29 -0500 X-MC-Unique: q_QQ-9uHMb2uuTNfD2S5zg-1 X-Mimecast-MFC-AGG-ID: q_QQ-9uHMb2uuTNfD2S5zg Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-385f0829430so3198378f8f.1 for ; Mon, 27 Jan 2025 22:48:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738046908; x=1738651708; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jSlNU7nyai9fjgHDHErirOmSvVkrx2AkeS5X0IjvK4c=; b=Q0d9BqOlmQ6rBL2+JBd/K4hSE8aQZtgMWVHFeGVa5EDnuJDwEMR+KcmneKK8CCnqWn 985tYEjHp2taSwtShn4mmsnmoWDL803QNK9AVynNwudyO8f9usNczwarFaV+LI2ik1e5 dT2rSUx7heyly7/Hx66JWC54oLWIuzDKoeB8CSwniAKpA2KYFtbozK1qkPqKxOn7sQdn XJlcRHgkh26emenJKeE9sQ9zbsCgNey/WzdFtYXz5KDN2IMEKhzc6rCa9cOUubvHP0i/ ExthVNSw/e72VavNT+Qub8xAqm1rhn2YYL3mndiEuOdXMUMJQD2gQ+fNzJswXHhDUm+p DfyA== X-Gm-Message-State: AOJu0YzjieBR+ov36BD0NevZv1sLplLjAaYqKB+bYYlOSRmr/1TvyL6e hXUHhcgqs+MU2Gm93a8Rud8yhy54NcgXbCHy7DK6U5AgbrYiuDI5HIU8qhh+BVoQzzRXNrN4NQM ex+CEmpBUFU6XqhzmwDqz800R14j0mKNXE20iQ2ylf8cVaYO1oA== X-Gm-Gg: ASbGnctZwH6J4UBc/UNVXR7M7qHwe/4Uit6BpdZE8A8RJ1d+q7JRwnyzfCSytt7UPMA DGp1zCL5gLSPks7xq5V1hHJTPx2MMWutOWM2eHY0Lb+D8dupP1Za/ovacIhyLw3kqFmT7PQPqnI P/YGbAaklDMbcImk/NBwLX+AxnAdvfXvJVSjxWjVO5fhmRdFcF1ceZPtD5qey7GRfdf6nrprIwt RP/4zYZAS1xu26Gie5SKV56tfRy6Asm14o8WRoCJrdiW5LYvo9mVIJgvNZt7V1ts/TXwfcVcsOj wcRzK375Fy7fyaqy X-Received: by 2002:a5d:6489:0:b0:385:f6f4:f8e with SMTP id ffacd0b85a97d-38bf57bd824mr38553597f8f.50.1738046908023; Mon, 27 Jan 2025 22:48:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcs7y7MIfjNClqyVDPiGGAm+JCDr7Npb/tp0nrm3DIGsmZVScz7meaS0TAEumank1KqPENmA== X-Received: by 2002:a5d:6489:0:b0:385:f6f4:f8e with SMTP id ffacd0b85a97d-38bf57bd824mr38553538f8f.50.1738046906624; Mon, 27 Jan 2025 22:48:26 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a17d6edsm13005860f8f.40.2025.01.27.22.48.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jan 2025 22:48:25 -0800 (PST) Date: Tue, 28 Jan 2025 07:48:24 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 1/7] icmp, udp: Pad time_t timestamp to 64-bit to ease state migration Message-ID: <20250128074824.000f3576@elisabeth> In-Reply-To: References: <20250127231532.672363-1-sbrivio@redhat.com> <20250127231532.672363-2-sbrivio@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PM-Zs_VEvRh8FQYoVlMsN_xyfYHpSZTUf4UDgwHBIk8_1738046908 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 3O5KPSAKI2Z2C2CZESIHVPCSPVSWNPC3 X-Message-ID-Hash: 3O5KPSAKI2Z2C2CZESIHVPCSPVSWNPC3 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 28 Jan 2025 11:49:16 +1100 David Gibson wrote: > On Tue, Jan 28, 2025 at 12:15:26AM +0100, Stefano Brivio wrote: > > That's the only field in flows with different storage sizes depending > > on the architecture: it's usually 4-byte wide on 32-bit architectures, > > except for arc and x32 where it's 8 bytes, and 8-byte wide on 64-bit > > machines. > > As discussed on the call, I think there are broader problems with > transferring timestamps than just the structure size. So I'm hoping > we can work out how to not transfer them at all and avoid this change. This change is not related to the fact that we ignore or use them. It's about making the flow entries the same size, which we need, at least with this implementation. -- Stefano