From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bQHWvBtp; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 617D85A061C for ; Tue, 28 Jan 2025 07:48:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738046924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BYHkn8E2zP2MxRltMMhDMVx1AYdax3BEaZqKbnmvfrA=; b=bQHWvBtp/d0lfE+yx0UqwjzHsj7WFZSDbGABIZJBrR1P1sZM4u72+bV5hVf+kB8iR8Gzjg zOU14Ot6NbLwWJkRDe/n4IcDw9DN3JpWmsotRko9T833t52ZBYs28+bAP6o9Z3hKpkKwTk ByOwh38wd5iYOssgJzibmGDhQpW65CA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-ybkLZhJBPpK3snE1BPzU1w-1; Tue, 28 Jan 2025 01:48:38 -0500 X-MC-Unique: ybkLZhJBPpK3snE1BPzU1w-1 X-Mimecast-MFC-AGG-ID: ybkLZhJBPpK3snE1BPzU1w Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4361f371908so36450755e9.0 for ; Mon, 27 Jan 2025 22:48:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738046917; x=1738651717; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BYHkn8E2zP2MxRltMMhDMVx1AYdax3BEaZqKbnmvfrA=; b=jxRow7+YbTnCFsfzPlggSTsi8gyPcj+4Fnu737etq5AiJwEOI/fXVRrG8SKq50lWWG 8qVpVzDs399vRfU6tKWoRco5RcJbC8rVxcz6U7u7DyAPgBchSdSDVMBe54kGNc8kTMDm dzNbI0no4aG9y5kUWDaEWd7E4IjgZIce0wvWMYjj0HX7ZeKEcZt42iivJrPMX5ATbtoP L6CG5ZNtFgindjCOOCPKuxLgb6DXdWCGDrCAx/Pldy4oEHVoH5G90jhJm6h+TdSLszRz id22/TLen2eF+GI+x5TcO8t8jNf7wZsZvMNF4SnyMtRjBGgQCBrNcjwknAyWi8iM5E1u en8Q== X-Gm-Message-State: AOJu0YwHbdi545UlT3RAnNOhIns/RXiiU8JazNuVdtNjCqoEupP1CkL7 wLYWxOaH5hH1Y+Vup6EM6r4ZXNrw+Qfq6ynDrTqkQV02xNzF9oePErjLB/gdQyQJW+eRXNhaEoq iy9BtbyIEHfXK9zbIKgbm3PNiDKu0velVkcozw3gsjLx6qa2HYQ== X-Gm-Gg: ASbGncvv/g9pYYibS0WjgECuSKhiCZodIQXEsebXtaBYQRZHFaQVUbNzPlvwrI22N4V jgPdKdOJdVPyBNp4LMumCGtKaYUmSvmyN+qoxgPHchG3LShE2BnugjEvZerINXv6CqgzY+wF698 L/d3hDEs+/hs5mD+M7ZOzUrWp9JI6vOg8baUZqAspHxxpkoDWzW43H2XaiQZmwXWeZQKBBBA4iN 21HaENEdZIJrKFtpRx7Z1XUkRThgGrV/R/nlc+vsF/ntHUKOenLSU5QTiuQulEODC4YfI4l2Ihp XPHYqen58uVNUU7cYsdJa6niT/oP2w5+Pg== X-Received: by 2002:a05:600c:458a:b0:436:faeb:2a18 with SMTP id 5b1f17b1804b1-438913bed3fmr369440875e9.6.1738046917474; Mon, 27 Jan 2025 22:48:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwvMsF6pw1zpA/+uPf7mz7d2lz26eMDoIEWxDsKVR/Uy2400WHzVbqiKxl7uWFT4byDovWGQ== X-Received: by 2002:a05:600c:458a:b0:436:faeb:2a18 with SMTP id 5b1f17b1804b1-438913bed3fmr369440745e9.6.1738046917168; Mon, 27 Jan 2025 22:48:37 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a1c3bacsm12978260f8f.83.2025.01.27.22.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jan 2025 22:48:36 -0800 (PST) Date: Tue, 28 Jan 2025 07:48:33 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 3/7] tcp_conn: Avoid 7-bit hole in struct tcp_splice_conn Message-ID: <20250128074833.716e4a66@elisabeth> In-Reply-To: References: <20250127231532.672363-1-sbrivio@redhat.com> <20250127231532.672363-4-sbrivio@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lHKF5sK3agQwhUXRfOF5E6-2ZgVZG2RjCaiTQbKgGz8_1738046917 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: MJKDCV7DUIKYHTHRNENVBWZ2PXCA45M6 X-Message-ID-Hash: MJKDCV7DUIKYHTHRNENVBWZ2PXCA45M6 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 28 Jan 2025 11:53:09 +1100 David Gibson wrote: > On Tue, Jan 28, 2025 at 12:15:28AM +0100, Stefano Brivio wrote: > > Moving in_epoll out of the common flow data created a 7-bit hole in > > struct tcp_splice_conn: repack by shrinking @flags by one (otherwise > > unused) bit. > > Is this actually necessary for the migration stuff? Or just a cleanup > you spotted along the way? I thought it was helpful to keep the same size on 32-bit, but it looks like it's not actually needed. Let me drop it from this series as it's just noise and I'm trying to keep this slim. If we are all happy with it I can apply it. If not I'll forget about it. -- Stefano