From: Stefano Brivio <sbrivio@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: jmaloy@redhat.com, netdev@vger.kernel.org, davem@davemloft.net,
kuba@kernel.org, passt-dev@passt.top, lvivier@redhat.com,
dgibson@redhat.com, memnglong8.dong@gmail.com,
kerneljasonxing@gmail.com, ncardwell@google.com,
eric.dumazet@gmail.com
Subject: Re: [net,v3] tcp: correct handling of extreme memory squeeze
Date: Tue, 28 Jan 2025 16:18:25 +0100 [thread overview]
Message-ID: <20250128161825.339f95ea@elisabeth> (raw)
In-Reply-To: <CANn89i+x2RGHDA6W-oo=Hs8bM=4Ao_aAKFsRrFhq=U133j+FvA@mail.gmail.com>
On Tue, 28 Jan 2025 16:04:35 +0100
Eric Dumazet <edumazet@google.com> wrote:
> This so-called 'deadlock' only occurs if a remote TCP stack is unable
> to send win0 probes.
>
> In this case, sending some ACK will not help reliably if these ACK get lost.
>
> I find the description tries very hard to hide a bug in another stack,
> for some reason.
Side note: that was fixed meanwhile. Back then, at a first analysis, we
thought it was a workaround, but it's the actual fix as we *must* send
zero-window probes in that situation, and this commit triggers them:
https://passt.top/passt/commit/?id=a740e16fd1b9bdca8d259aa6d37f942a3874425c
--
Stefano
next prev parent reply other threads:[~2025-01-28 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 23:13 [net,v3] tcp: correct handling of extreme memory squeeze jmaloy
2025-01-28 0:52 ` Jason Xing
2025-01-28 15:04 ` Eric Dumazet
2025-01-28 15:18 ` Stefano Brivio [this message]
2025-01-28 15:56 ` Neal Cardwell
2025-01-28 16:01 ` Eric Dumazet
2025-01-28 16:51 ` Jon Maloy
2025-01-28 17:11 ` Eric Dumazet
2025-01-30 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250128161825.339f95ea@elisabeth \
--to=sbrivio@redhat.com \
--cc=davem@davemloft.net \
--cc=dgibson@redhat.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jmaloy@redhat.com \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=lvivier@redhat.com \
--cc=memnglong8.dong@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).