From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Onpb7Mic; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id BE53E5A026F for ; Thu, 30 Jan 2025 08:56:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738223769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9TmFL1FU3RlcsYVHe9iu5iv69wGxZ9rznsK76M+oXhw=; b=Onpb7Mic7p/wx5TqCyUhCjKJk+eF47YqBlkBlvTQOFe15ZL8cClcMsCoahWngl0L92tM87 9nRu+KuB37YTdhA5iCdnJnCIZaG+SdNiWsPm4/IOi0ZafVfBHfuAjzrhAuaAb/c9M6oXGK NyMpRjq1geQ5/7xXZY61T4lkYh33Ucw= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-98-0KHitTrTM-qjJsxihs3y-w-1; Thu, 30 Jan 2025 02:56:07 -0500 X-MC-Unique: 0KHitTrTM-qjJsxihs3y-w-1 X-Mimecast-MFC-AGG-ID: 0KHitTrTM-qjJsxihs3y-w Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-ab39f65dc10so56772866b.1 for ; Wed, 29 Jan 2025 23:56:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738223766; x=1738828566; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9TmFL1FU3RlcsYVHe9iu5iv69wGxZ9rznsK76M+oXhw=; b=q79xeGvFh4ZbGIiRFeRAMjkEe7iWsPh5++DAo2PcIlBYhfM3XGoJtYpDjmGbSjuTZR HtgUn6hZMy4RCdBsjsHqa7V8RZ7f2AiDw450ARjteOlL8WRM82v3R8OPp+00DSTNu7/P GVoax/hX7ZpHRZGHeznxl4kXH4oVMJb8UFcHV3Dem2ZKMUYXAts7mvJg78OXnLHfXsRZ 4DYy2lES87evLVsaCcxYCO3qQUaAUVOc5pxJzmMOVB2YlVL1uiM/gyi0ZX2spdIGma/4 Fko4Oq20jk9XZPfh7JOGbvDtD1wbwul73+V7ZD/3vSB1fcwA3x1D4qPLkJi9GznoJQGv AsUA== X-Gm-Message-State: AOJu0YxPRlIyJu6V3akk2Lr+8uNnaJEvoO/CgXujNPAoms1pni2sf8TW 3r8DQzOHYcdpr3vPo971/Q0TFZ0Di4HTPGPYyyY3x0TNjNJRiVNgIIGWyEcVjhb3z+ULF1lrzqA HkEQPTzmI/kE5/PR3yh5LCdFJ5x0L5ZuKaXKetcTy/Rjmx7deF29VhzN3mQ== X-Gm-Gg: ASbGncvXoJImpfP4kzyq+XWDc3JDuDqkdiQqLaklIlCOuAxE1Gi6wuDGzgsYUEt4MqX BRV8vLx6UfpzXmsmLwe/BNRJiOeleolzCmgkkiWIfXgQa3Zv6P4ytxtCACwQTEi7/qYVq8zFKxU pkNJ3yGS4Teh7yGAAl8J6LgouzpAZuDZjdpdxvuholNp6WVGW6wRbOIP1ipSr8ygJOsDrxdUzeT wHDzjG5bT4uGderXSDEFhuAM94YDfoAJlke39bVhdJds9zEiSJoIzOlkXydNbTtvC1NR/6L32VE 0BqmdbwQ/TqjUv+b X-Received: by 2002:a17:907:3f0b:b0:ab6:37c3:381d with SMTP id a640c23a62f3a-ab6cfceb5c2mr623280466b.24.1738223766093; Wed, 29 Jan 2025 23:56:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IHffezC6/rBIEhbwhAoweNfU3tfZxuFrMtN5jTAx2kboYvv4FI1erpANFVcWTGMZRyyX6iM3Q== X-Received: by 2002:a17:907:3f0b:b0:ab6:37c3:381d with SMTP id a640c23a62f3a-ab6cfceb5c2mr623278866b.24.1738223765663; Wed, 29 Jan 2025 23:56:05 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6e4a59855sm73456266b.180.2025.01.29.23.56.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2025 23:56:05 -0800 (PST) Date: Thu, 30 Jan 2025 08:56:02 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 7/7] Introduce passt-repair Message-ID: <20250130085602.69821cf1@elisabeth> In-Reply-To: References: <20250127231532.672363-1-sbrivio@redhat.com> <20250127231532.672363-8-sbrivio@redhat.com> <20250128075131.268f85d1@elisabeth> <20250129080428.472744aa@elisabeth> <20250130055543.1020dec7@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eGO6DK9UnannWDSsK7Q93SqRv21S6_iGzTXsSZBeABk_1738223767 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: QBIV5EGGDMGIF673SWSJS6TUTL6HR4LK X-Message-ID-Hash: QBIV5EGGDMGIF673SWSJS6TUTL6HR4LK X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 30 Jan 2025 18:43:34 +1100 David Gibson wrote: > Hm, ok. I'm way less convinced on both of those points. Which means > I'd like to have a clear policy on whether we require versions to > match or not. Which we prioritise affects design choices. No, in this case, we don't require versions to match. The protocol is well-defined and won't change. Any change to it will require a different interface. The protocol is one byte that can be TCP_REPAIR_ON, TCP_REPAIR_OFF, TCP_REPAIR_OFF_WP, and one to SCM_MAX_FD sockets as SCM_RIGHTS ancillary message, sent by the server. The client replies with the same byte (and no ancillary message) to signal success, and closes the connection on failure. The server closes the connection on error or completion. This is obviously enough for a privileged helper that has the only function of setting the TCP_REPAIR socket option to TCP_REPAIR_ON, TCP_REPAIR_OFF, or TCP_REPAIR_OFF_WP, on a given set of sockets. As a result, I think that any added complexity is plain wrong. -- Stefano