From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BCIZs1fW; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 510C35A061E for ; Fri, 31 Jan 2025 06:37:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738301837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CZ0cUJlR2kSNJ4dDVGPrpUi2ZkhyCncvyU4ofnyG4yk=; b=BCIZs1fWNm3uOQgrSO2kAofnyg4U7NU5hHRfWOQohTlppedtDp4ujy1Cawr6TcP1xhqCSU S9kHDPETIlM+nLA1rLffnROCQe35mFLS+gxKBYzkt1dkC7fiF3fo5ioeBc6ihAgvFxbfq1 Ih0cM1Aiu9GPi/XKArA94cU+BSPz6FY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-304-xiF4lnbLOJ-jGUK1ni1vTA-1; Fri, 31 Jan 2025 00:37:15 -0500 X-MC-Unique: xiF4lnbLOJ-jGUK1ni1vTA-1 X-Mimecast-MFC-AGG-ID: xiF4lnbLOJ-jGUK1ni1vTA Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-436219070b4so7164095e9.1 for ; Thu, 30 Jan 2025 21:37:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738301834; x=1738906634; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=CZ0cUJlR2kSNJ4dDVGPrpUi2ZkhyCncvyU4ofnyG4yk=; b=ferdH81PYOBkZY99r+88aMJcxvvQBLWDIEOyytbmntoBvjaHj7Ay1H+Yln+3vmQvRJ yZ8ZnW4BweFDPhsbqfpQyq7v1rUQ/9ZbTzI+QRgqr85IGun3VMZuQjCFuFtLFvKVFByE EpzEzTw0TIVnzpQeIpczccu2AdyBy6G2hCHl1bENy3tCVq6Y3UBJFt2XLmpvzL9DzFW/ AGnURTi/5Bs7MyzUpTVyTKU7SVKqB2D6r3sg1w81BjBtUapyYcb2hcVCqQ/TSik8gcPm myYrMY0cFuUDaGzk+Wbi8hLHuXvfibM3hvQ44oZE5VV3KPWr/SoOI+JirNWC/NcF+Xpm dG1w== X-Gm-Message-State: AOJu0YzevJVuyzqKJmcaOHWPWS1Q56QfNzk4DnfU74AwfwdcMgtr3njn h0NAb3zFZqPdDsw8IQC2ltnR0ucdDtFLV9rDhSovARHnPVvje6+GCffmacn4uXwp8JXMd/Wl5Wp 7H5BazXpXZKeD9cGjy6wI0wK6fl0LO+b9zRUbmvLJmbycKEmaAw== X-Gm-Gg: ASbGncu1CvAAQCqkjdfSdWu8FRHL5vFQq01zwSvD4ihbHyEVNqEr4CJwlexPL03BFM3 WqmpxwtAilmnpJUSW6QVuLsmipr2PwuNzoSKptsg+e1GP/Jjj2ifDGb+ThnrqBx591OsZRksBXc XyVe9Q5SU4TNme3IE6ZE7yyKNW3jx9L3NbOD2qk6ME3/MKpetzLoo3ASx+TuG1aZuFcs4hYq3xy 6x3N32CcAoLhlQfwfcgMs0OTHn1XvexOhnJPw6hnft5zsT8gwgSWKQihUvxoI7BofgJZeXQp2Vc bux5p9pQQ8Ol5XqC X-Received: by 2002:a05:600c:4f55:b0:436:51bb:7a43 with SMTP id 5b1f17b1804b1-438dc3ab675mr96027805e9.5.1738301833948; Thu, 30 Jan 2025 21:37:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnybU7j0w47AcqlL56PUSm6jGEdwumDZE6DWPm61vhnu6/6m7I7kWHTzLuTcIzqs9B5sKm/w== X-Received: by 2002:a05:600c:4f55:b0:436:51bb:7a43 with SMTP id 5b1f17b1804b1-438dc3ab675mr96027735e9.5.1738301833640; Thu, 30 Jan 2025 21:37:13 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438d7b4c4c4sm56096085e9.1.2025.01.30.21.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jan 2025 21:37:11 -0800 (PST) Date: Fri, 31 Jan 2025 06:37:09 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 5/5] migrate: Don't handle the migration channel through epoll Message-ID: <20250131063709.25a11049@elisabeth> In-Reply-To: <20250130083330.917030-6-david@gibson.dropbear.id.au> References: <20250130083330.917030-1-david@gibson.dropbear.id.au> <20250130083330.917030-6-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _Cw7EIIcI0pbOn_Mpcd24tUc2t6fwzRt-AaV5krQYe8_1738301834 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: WYTH4HFH4TNJOHWZBPVAFPTO2JHT7GMW X-Message-ID-Hash: WYTH4HFH4TNJOHWZBPVAFPTO2JHT7GMW X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 30 Jan 2025 19:33:30 +1100 David Gibson wrote: > --- a/migrate.c > +++ b/migrate.c > @@ -327,26 +327,6 @@ static int migrate_target(struct ctx *c, int fd) > return rc; > } > > -/** > - * set_migration_watch() - Add the migration file descriptor to epoll > - * @c: Execution context > - * @fd: File descriptor to add > - * @target: Are we the target of the migration? > - */ > -static void set_migration_watch(const struct ctx *c, int fd, bool target) > -{ > - union epoll_ref ref = { > - .type = EPOLL_TYPE_DEVICE_STATE, > - .fd = fd, > - }; > - struct epoll_event ev = { 0 }; > - > - ev.data.u64 = ref.u64; > - ev.events = target ? EPOLLIN : EPOLLOUT; > - > - epoll_ctl(c->epollfd, EPOLL_CTL_ADD, ref.fd, &ev); This change should have dropped: epoll_del(c, c->device_state_fd); from migrate_close(). -- Stefano