From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 1/2] migrate: Merge protocol version information into one table
Date: Fri, 31 Jan 2025 06:53:44 +0100 [thread overview]
Message-ID: <20250131065344.1f440c01@elisabeth> (raw)
In-Reply-To: <20250131045215.1368543-2-david@gibson.dropbear.id.au>
On Fri, 31 Jan 2025 15:52:14 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> +/**
> + * struct migrate_meta - Migration metadata
> + * @version: Version number, host order
> + * @v: Version information
> + * @bswap: Source has opposite endianness
> + * @peer_64b: Source uses 64-bit void *
> + * @time_64b: Source uses 64-bit time_t
> + * @flow_size: Size of union flow in source
> + * @flow_sidx_size: Size of struct flow_sidx in source
> + */
> +struct migrate_meta {
> + uint32_t version;
> + const struct migrate_version *v;
> + bool bswap;
> + bool source_64b;
> + bool time_64b;
> + size_t flow_size;
> + size_t flow_sidx_size;
> +};
What's the purpose of this, if this information should go away quite
soon (even before merge, perhaps)?
--
Stefano
next prev parent reply other threads:[~2025-01-31 5:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 4:52 [PATCH 0/2] Fancier version handling for migration David Gibson
2025-01-31 4:52 ` [PATCH 1/2] migrate: Merge protocol version information into one table David Gibson
2025-01-31 5:53 ` Stefano Brivio [this message]
2025-01-31 6:17 ` David Gibson
2025-01-31 4:52 ` [PATCH 2/2] migrate: More sophisticated versioning David Gibson
2025-01-31 5:53 ` Stefano Brivio
2025-01-31 6:21 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250131065344.1f440c01@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).