From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eCM9iv0L; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id E66B45A0625 for ; Fri, 31 Jan 2025 06:53:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738302831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NAAv43Qmrj/cSlpiTSeU3JVl81z7YMzmiSwqc+7I4g8=; b=eCM9iv0LgqOmdxKqp/7hbOE+UhH7PNe14vDts7CFATpaYmutctu40AeCQgHaiXa3Fh1mn7 1y1gBLydpqbuKSfjJGdl4KbldSCcHXkfNSzUpmRRog86z8dQiAIbCH/CsItDrIpAbnZtVS rDz+63e4eNPTUu6nbyohMHMV9aan1o8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-Ug36OqN_MAG6EAxw5iqF3Q-1; Fri, 31 Jan 2025 00:53:50 -0500 X-MC-Unique: Ug36OqN_MAG6EAxw5iqF3Q-1 X-Mimecast-MFC-AGG-ID: Ug36OqN_MAG6EAxw5iqF3Q Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38a2140a400so1154389f8f.0 for ; Thu, 30 Jan 2025 21:53:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738302828; x=1738907628; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NAAv43Qmrj/cSlpiTSeU3JVl81z7YMzmiSwqc+7I4g8=; b=u/83kF+VkD3LxFGLGWayxolZNqaIrhA+15wc9Z1XUI1mvC3uY0pKK64+AYhVIjtElb gMSr2a1HJZCttsWj/P6IfZDOhVeQlgKHVmOt8VNtSUNP8SU2EdhNIzK+s8ihOQp82qAJ 3DVnTj0fd2aeFgVRgZzF4UJc1ezU02C6Qq9lQPmk2sSjeKnZ1IW4uhIbi2RNCqoJajIc yc1Y9OwQd2dVV2MR4B5lDwSDSSlm2yBeZF3MxVk9Cdnn4IKe1h/V6N4EpFf9V4NG9yjd ndIjze4Mth0yk8XuIikz/L7h+oYlKx2n8ek8g//oTjr9skX9pBNfmmxsqSP4DTH1Pv/C R8dg== X-Gm-Message-State: AOJu0YzTKgTj+e1ryOS7Sq5PymW5u9exYN9lfjHrvnMl9Cc1I9tAqvhD ZUaIWDkbEquokA4xBkrBQY3Ha/qvLbRDfkovimGllcAP4kDmuu+owC2UhBkiqQgvy4m96ScTghl 7KeWvXlAHAFlred9RHc2+Rmtfdk3OWmcvqx7Vr8hNwpjmTiCBIVkUlVH6SA== X-Gm-Gg: ASbGnctS5R5M2gOZZkMDkmuSmuY24ogYEl/9j/2BFT8pro2lcJRc8tyzQ2LcQRtOWtT 4fGNwkTfr9H3I/qzGc/8uSgIMsMZhzP4BQPemaLVpbAPbT8qY2pYJQtoT1cuB3DKhxxvswt/reY 3/X2YB09HZY08y11Z5B86GdCOrRUwFBeMaGQYVLG8npAt+sSKVUTdxYxS0NzLTQ00+wZL73lNkq TM0LOvZw1rMw4zbPUh18y2HDK6B8pOYiJPpKwy37lc81VY+61dHnnxOzrNWfu8DxMoEac4lOuiS mzhAz9ljRLAjyK12EBMDvr2vSCCHLHE4qA== X-Received: by 2002:a05:6000:2ad:b0:38a:4de1:ac6 with SMTP id ffacd0b85a97d-38c51931f06mr7704439f8f.6.1738302827989; Thu, 30 Jan 2025 21:53:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFXcpqe0O8Ag6UUgh4MK3khIoWXDvOgN4jJjj1jVT7nKEZsW764Q0JZleRPQIbfLmP6eYJrcw== X-Received: by 2002:a05:6000:2ad:b0:38a:4de1:ac6 with SMTP id ffacd0b85a97d-38c51931f06mr7704428f8f.6.1738302827626; Thu, 30 Jan 2025 21:53:47 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c122539sm3788835f8f.46.2025.01.30.21.53.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jan 2025 21:53:46 -0800 (PST) Date: Fri, 31 Jan 2025 06:53:44 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 1/2] migrate: Merge protocol version information into one table Message-ID: <20250131065344.1f440c01@elisabeth> In-Reply-To: <20250131045215.1368543-2-david@gibson.dropbear.id.au> References: <20250131045215.1368543-1-david@gibson.dropbear.id.au> <20250131045215.1368543-2-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8Kr-NLlysGHAvvOelRjRbinTJJz23oZplpm7-yhLRNg_1738302829 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: ZSA5K73B65E2YGEE7BJZEQOOZBXM3JD3 X-Message-ID-Hash: ZSA5K73B65E2YGEE7BJZEQOOZBXM3JD3 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 31 Jan 2025 15:52:14 +1100 David Gibson wrote: > +/** > + * struct migrate_meta - Migration metadata > + * @version: Version number, host order > + * @v: Version information > + * @bswap: Source has opposite endianness > + * @peer_64b: Source uses 64-bit void * > + * @time_64b: Source uses 64-bit time_t > + * @flow_size: Size of union flow in source > + * @flow_sidx_size: Size of struct flow_sidx in source > + */ > +struct migrate_meta { > + uint32_t version; > + const struct migrate_version *v; > + bool bswap; > + bool source_64b; > + bool time_64b; > + size_t flow_size; > + size_t flow_sidx_size; > +}; What's the purpose of this, if this information should go away quite soon (even before merge, perhaps)? -- Stefano