From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 3/6] migrate: Clearer debug message in migrate_request()
Date: Mon, 3 Feb 2025 20:26:12 +1100 [thread overview]
Message-ID: <20250203092615.500163-4-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20250203092615.500163-1-david@gibson.dropbear.id.au>
The message confusingly gives the *previous* value of c->device_state_fd as
the fd, not the newly assigned one.
[This is a candidate to fold into the earlier patch]
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
migrate.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/migrate.c b/migrate.c
index d47c44b0..2d9f77ef 100644
--- a/migrate.c
+++ b/migrate.c
@@ -374,7 +374,8 @@ void migrate_close(struct ctx *c)
*/
void migrate_request(struct ctx *c, int fd, bool target)
{
- debug("Migration requested, fd: %d", c->device_state_fd);
+ debug("Migration requested, fd: %d (was %d)",
+ fd, c->device_state_fd);
if (c->device_state_fd != -1)
migrate_close(c);
--
@@ -374,7 +374,8 @@ void migrate_close(struct ctx *c)
*/
void migrate_request(struct ctx *c, int fd, bool target)
{
- debug("Migration requested, fd: %d", c->device_state_fd);
+ debug("Migration requested, fd: %d (was %d)",
+ fd, c->device_state_fd);
if (c->device_state_fd != -1)
migrate_close(c);
--
2.48.1
next prev parent reply other threads:[~2025-02-03 9:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 9:26 [PATCH 0/6] More migration improvements David Gibson
2025-02-03 9:26 ` [PATCH 1/6] vhost-user: Change different vhost-user messages to trace() level David Gibson
2025-02-04 0:42 ` Stefano Brivio
2025-02-03 9:26 ` [PATCH 2/6] migrate, flow: Abort migration on repair_flush() failure David Gibson
2025-02-03 9:26 ` David Gibson [this message]
2025-02-03 9:26 ` [PATCH 4/6] migrate: Handle sending header section from data sections David Gibson
2025-02-03 9:26 ` [PATCH 5/6] util: read_remainder should take const pointer to iovec David Gibson
2025-02-04 0:42 ` Stefano Brivio
2025-02-03 9:26 ` [PATCH 6/6] migrate: Make migration handlers simpler and more flexible David Gibson
2025-02-03 10:20 ` Stefano Brivio
2025-02-03 23:55 ` David Gibson
2025-02-04 0:12 ` Stefano Brivio
2025-02-04 3:36 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203092615.500163-4-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).