From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=So/YPxPQ; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id E6DB35A0271 for ; Mon, 03 Feb 2025 10:26:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1738574768; bh=JTi4gYijsmTXJLHXqgo49LCMYZzU7PhyLhhSyTWQ5x0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=So/YPxPQRuXtaxMtNToWHqk3Q9tZh5JtVt5dV1Ccz9SFl8TveY+MovxEflrxBFRuB qgInWENjwM/qe3/Agp2b0xxN3BlpT0ul1A7HcJeGXJsaiQtgOY+wYp81Bey/w6jCOc h/wP8+A8FGuXcdTpFoh5I/soyNXQqWxGZLFOJ6yoQdbRk1eVwFDGcRANq3OjTO3U8+ LxDeS0nfDPWQsiqLZzwuj3CyVKIXVEQrczkMTMKHsDHpkSTsJuL78aovkCqSMHuz51 ZHp9Jpl2jBEdjjNBemGqhAufvy2LOAMtkmme3pT1fxtxfYpPN45QozWMW1BRhYNDTc XTXf6f2J00d6A== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Ymh282S7cz4wy9; Mon, 3 Feb 2025 20:26:08 +1100 (AEDT) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 3/6] migrate: Clearer debug message in migrate_request() Date: Mon, 3 Feb 2025 20:26:12 +1100 Message-ID: <20250203092615.500163-4-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250203092615.500163-1-david@gibson.dropbear.id.au> References: <20250203092615.500163-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: 6SK3RABAVP45SU3XVODDTMNJR2LGQNAQ X-Message-ID-Hash: 6SK3RABAVP45SU3XVODDTMNJR2LGQNAQ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The message confusingly gives the *previous* value of c->device_state_fd as the fd, not the newly assigned one. [This is a candidate to fold into the earlier patch] Signed-off-by: David Gibson --- migrate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migrate.c b/migrate.c index d47c44b0..2d9f77ef 100644 --- a/migrate.c +++ b/migrate.c @@ -374,7 +374,8 @@ void migrate_close(struct ctx *c) */ void migrate_request(struct ctx *c, int fd, bool target) { - debug("Migration requested, fd: %d", c->device_state_fd); + debug("Migration requested, fd: %d (was %d)", + fd, c->device_state_fd); if (c->device_state_fd != -1) migrate_close(c); -- 2.48.1