public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v4 1/8] flow_table: Use size in extern declaration for flowtab, export hash table
Date: Tue,  4 Feb 2025 01:47:38 +0100	[thread overview]
Message-ID: <20250204004745.97854-2-sbrivio@redhat.com> (raw)
In-Reply-To: <20250204004745.97854-1-sbrivio@redhat.com>

This can all be thrown away once we stop copying the flow table.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
 flow.c       | 6 +-----
 flow_table.h | 5 ++++-
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/flow.c b/flow.c
index a6fe6d1..3b8dd0e 100644
--- a/flow.c
+++ b/flow.c
@@ -109,12 +109,8 @@ unsigned flow_first_free;
 union flow flowtab[FLOW_MAX];
 static const union flow *flow_new_entry; /* = NULL */
 
-/* Hash table to index it */
-#define FLOW_HASH_LOAD		70		/* % */
-#define FLOW_HASH_SIZE		((2 * FLOW_MAX * 100 / FLOW_HASH_LOAD))
-
 /* Table for lookup from flowside information */
-static flow_sidx_t flow_hashtab[FLOW_HASH_SIZE];
+flow_sidx_t flow_hashtab[FLOW_HASH_SIZE];
 
 static_assert(ARRAY_SIZE(flow_hashtab) >= 2 * FLOW_MAX,
 "Safe linear probing requires hash table with more entries than the number of sides in the flow table");
diff --git a/flow_table.h b/flow_table.h
index eeb6f41..be4f841 100644
--- a/flow_table.h
+++ b/flow_table.h
@@ -41,7 +41,10 @@ union flow {
 
 /* Global Flow Table */
 extern unsigned flow_first_free;
-extern union flow flowtab[];
+extern union flow flowtab[FLOW_MAX];
+#define FLOW_HASH_LOAD		70		/* % */
+#define FLOW_HASH_SIZE		((2 * FLOW_MAX * 100 / FLOW_HASH_LOAD))
+extern flow_sidx_t flow_hashtab[FLOW_HASH_SIZE];
 
 /**
  * flow_foreach_sidei() - 'for' type macro to step through each side of flow
-- 
@@ -41,7 +41,10 @@ union flow {
 
 /* Global Flow Table */
 extern unsigned flow_first_free;
-extern union flow flowtab[];
+extern union flow flowtab[FLOW_MAX];
+#define FLOW_HASH_LOAD		70		/* % */
+#define FLOW_HASH_SIZE		((2 * FLOW_MAX * 100 / FLOW_HASH_LOAD))
+extern flow_sidx_t flow_hashtab[FLOW_HASH_SIZE];
 
 /**
  * flow_foreach_sidei() - 'for' type macro to step through each side of flow
-- 
2.43.0


  reply	other threads:[~2025-02-04  0:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04  0:47 [PATCH v4 0/8] Draft, incomplete series introducing state migration Stefano Brivio
2025-02-04  0:47 ` Stefano Brivio [this message]
2025-02-04  0:47 ` [PATCH v4 2/8] Introduce facilities for guest migration on top of vhost-user infrastructure Stefano Brivio
2025-02-04  0:47 ` [PATCH v4 3/8] migrate: Make more handling common rather than vhost-user specific Stefano Brivio
2025-02-04  0:47 ` [PATCH v4 4/8] migrate: Don't handle the migration channel through epoll Stefano Brivio
2025-02-04  0:47 ` [PATCH v4 5/8] Add interfaces and configuration bits for passt-repair Stefano Brivio
2025-02-04  0:47 ` [PATCH v4 6/8] flow, tcp: Basic pre-migration source handler to dump sequence numbers Stefano Brivio
2025-02-04  3:43   ` David Gibson
2025-02-04  6:44     ` Stefano Brivio
2025-02-05  0:58       ` David Gibson
2025-02-04  0:47 ` [PATCH v4 7/8] vhost_user: Make source quit after reporting migration state Stefano Brivio
2025-02-04  0:47 ` [PATCH v4 8/8] Implement target side of migration Stefano Brivio
2025-02-04  6:01 ` [PATCH v4 0/8] Draft, incomplete series introducing state migration David Gibson
2025-02-04  6:48   ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250204004745.97854-2-sbrivio@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).