From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 1/6] vhost-user: Change different vhost-user messages to trace() level
Date: Tue, 4 Feb 2025 01:42:22 +0100 [thread overview]
Message-ID: <20250204014222.246796d3@elisabeth> (raw)
In-Reply-To: <20250203092615.500163-2-david@gibson.dropbear.id.au>
On Mon, 3 Feb 2025 20:26:10 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> A previous patch changed the debug() calls in vu_control_handler() to
> trace() to reduce noise when debugging migration. However those messages
> are infrequent, and pretty useful when debugging migration (I used them to
> discover I needed a different qemu version).
>
> At the same time we have potentially per-packet debug() messages in
> vu_kick_cb() and vu_send_single(). These get much more in the way since
> they occur asynchronously with the migration operation. As a rule, per
> packet messages should be trace() level anyway.
>
> [This is a candidate to fold into the earlier patch]
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Folded into existing patch and applied.
--
Stefano
next prev parent reply other threads:[~2025-02-04 0:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 9:26 [PATCH 0/6] More migration improvements David Gibson
2025-02-03 9:26 ` [PATCH 1/6] vhost-user: Change different vhost-user messages to trace() level David Gibson
2025-02-04 0:42 ` Stefano Brivio [this message]
2025-02-03 9:26 ` [PATCH 2/6] migrate, flow: Abort migration on repair_flush() failure David Gibson
2025-02-03 9:26 ` [PATCH 3/6] migrate: Clearer debug message in migrate_request() David Gibson
2025-02-03 9:26 ` [PATCH 4/6] migrate: Handle sending header section from data sections David Gibson
2025-02-03 9:26 ` [PATCH 5/6] util: read_remainder should take const pointer to iovec David Gibson
2025-02-04 0:42 ` Stefano Brivio
2025-02-03 9:26 ` [PATCH 6/6] migrate: Make migration handlers simpler and more flexible David Gibson
2025-02-03 10:20 ` Stefano Brivio
2025-02-03 23:55 ` David Gibson
2025-02-04 0:12 ` Stefano Brivio
2025-02-04 3:36 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204014222.246796d3@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).