From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=D7YnUh4c; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id E18EB5A0271 for ; Tue, 04 Feb 2025 01:42:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738629750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mtDtyDNgH4GGLkP+sLiy1LbEFT9Iy12EERDNQQdICsI=; b=D7YnUh4c1ihZucaSaCaTbb9c6le9KgU9MUuG4ebXdpKBl/VYblJWJcvnvQk14mL7K8npgL 326Dlruy7DS7sq2bA5PPrB/12bmjdm3GscfaK9NMglIKWFNoGQzkmgVmJx1X/wER+ViOHT CSks3nZDjNknnuRWX8qRxc1XLc3/P/s= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-peUznru5Owi-_Q_-KCdQ1A-1; Mon, 03 Feb 2025 19:42:29 -0500 X-MC-Unique: peUznru5Owi-_Q_-KCdQ1A-1 X-Mimecast-MFC-AGG-ID: peUznru5Owi-_Q_-KCdQ1A Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-438e180821aso25762785e9.1 for ; Mon, 03 Feb 2025 16:42:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738629747; x=1739234547; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mtDtyDNgH4GGLkP+sLiy1LbEFT9Iy12EERDNQQdICsI=; b=gfkqvB73PQ34s3+9WEYMpY3ZV/IrPKom3Kqoj+c5KPFaCAjxXTY/J5EvmVZTFN2yaZ HEM50WuCRa4km1FvPaIgwnG5v06heoPBMyLJM4pzdh1I42mPoDxWqJ+Qaisj2FpplyKL NjrW+TpAmLszDHTuZFo57mZj1OLWoVoA/Fj1c6uvl/FE/1/TK5Vw7fv3asPf0UQLbTAs 1Cs65Z3utaZ+IVbimhuksN9THwCR1wNWZrYYz3tBztIhNZnvhFRhomU2jkqKgc5VvENs l9UqA7O8vpbSD5ltjvpiWaRTjimIWYj8ET3LPMQPEKx+HRTCS3m1fj3G/azgtq/Rlnm3 A5Gg== X-Gm-Message-State: AOJu0Yxc9FXtDC1HZYcn3YZsysPKYiAPa5O8/eplNl6lvVJ7iUcTBl/H hlXlY50fwesrXGaSkqPVxIFL2ebIllO0jM4ojMelsRuw2Sa2j0b2QXer+SlA5qfEe1GBchT8xWH oFb+1Jey+CZ7fv+7g1zEQnEyLQTNNQ5kiGPAjHbSoWa4s6tyuEP0HJFcP3g== X-Gm-Gg: ASbGnctNk3wWzPjUwdtHnn9Cw4EG1eMRR9mZLJ64L2mbapo5Qw8uA969mnfxI/I/qAg vxKA5mDoJvvlsDTsMdEh739J1FK4FmjhtTURjnxscAI4Usct2+UFCQzTIQqTHodpqfWF8O+QcgL uHkKT611rrfj0AMKTtZzjkQdT/9oEMBF2vM/Mh3l0+/kMaNT6gUCWX6OLIT/L9wl1YQwsWKXQU9 Hx6nF9eiKMT2qX7YSpgN8rhpsp5DwDWGe/oHhsW5g9RvnEHCoAhwQQC/pJ0WQ1GOGAFi9XC2dd3 raY3Wo5Em4FBMXkNqvwoxJMx4cZlgR0ejA== X-Received: by 2002:a05:600c:224a:b0:434:ea21:e14f with SMTP id 5b1f17b1804b1-438e017bb6bmr186531175e9.13.1738629747225; Mon, 03 Feb 2025 16:42:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IFRvqoopqWV24XZEdjbmCl12Gpuck5rrm5K1mkvsdeRgH+VMqMQqgNuibxd9FULjlC9wyY45A== X-Received: by 2002:a05:600c:224a:b0:434:ea21:e14f with SMTP id 5b1f17b1804b1-438e017bb6bmr186531105e9.13.1738629746929; Mon, 03 Feb 2025 16:42:26 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438e244f0d2sm175474385e9.30.2025.02.03.16.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 16:42:25 -0800 (PST) Date: Tue, 4 Feb 2025 01:42:22 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 1/6] vhost-user: Change different vhost-user messages to trace() level Message-ID: <20250204014222.246796d3@elisabeth> In-Reply-To: <20250203092615.500163-2-david@gibson.dropbear.id.au> References: <20250203092615.500163-1-david@gibson.dropbear.id.au> <20250203092615.500163-2-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HV3vtc8ixLU5jA46NYwAPxYwRRGP7FZDcR1c7jjUZ1c_1738629748 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: CKQSJTU7G6E7WANNHTE24JC5DPGYDSCR X-Message-ID-Hash: CKQSJTU7G6E7WANNHTE24JC5DPGYDSCR X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 3 Feb 2025 20:26:10 +1100 David Gibson wrote: > A previous patch changed the debug() calls in vu_control_handler() to > trace() to reduce noise when debugging migration. However those messages > are infrequent, and pretty useful when debugging migration (I used them to > discover I needed a different qemu version). > > At the same time we have potentially per-packet debug() messages in > vu_kick_cb() and vu_send_single(). These get much more in the way since > they occur asynchronously with the migration operation. As a rule, per > packet messages should be trace() level anyway. > > [This is a candidate to fold into the earlier patch] > > Signed-off-by: David Gibson Folded into existing patch and applied. -- Stefano