From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cTtiCHIA; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 891A85A0271 for ; Tue, 04 Feb 2025 01:42:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738629753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lArpG3r1V0WFR7Tlwb5v2yQDoet/TMgp/OynX2QcK4k=; b=cTtiCHIASs8c19hoZKeVo3nUMe/9GKE/sLAuNsmztlse1jDHPGlBho5K2ZJHTmJHEQMQr5 7uOc0BQBvh/qdcAbm99bgxY7JkPWT4hJvFMAWUsp+2QSphNeLxRtt6weV41O+jANAerVWi Ytde0bQmG/3p2cZHEVB1Wk35PeYtEGw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-55-0S-aTAdWOEeHYn4_sNJsMw-1; Mon, 03 Feb 2025 19:42:32 -0500 X-MC-Unique: 0S-aTAdWOEeHYn4_sNJsMw-1 X-Mimecast-MFC-AGG-ID: 0S-aTAdWOEeHYn4_sNJsMw Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-385d80576abso3365190f8f.3 for ; Mon, 03 Feb 2025 16:42:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738629750; x=1739234550; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=lArpG3r1V0WFR7Tlwb5v2yQDoet/TMgp/OynX2QcK4k=; b=UvT9MjsFKWddm8Lqyhm8sxyFevdcEqPm/oIoM45VFtAV6JGeLKhzT68UTuyC4bQPaP dMN3UiVG8mspbUqwHsdTnqNU5h1GPJW/S8FytFkzZupqIClSn73h90vkOHaO5dSg0iRr 0zgbFBW1it7smKtuybd+9HzIATOR4FCfhOJD+nR4FGqiheDhmDtkvRxKxvkojNimD7yc CMJsQdBbAN9C6QjFIGfwWvosFnXIzC7y5xytD0+o5Hgv7OcPZZYDADhfVn+r6SV5nuN9 EwHXcw1SmIfmiqbzYIfTDUcSdRD1K1wI062/txyfz5Un3Qj/6n2hoOsfRYjoFCGeOfcd UfMA== X-Gm-Message-State: AOJu0YziBcFj88IjIsHatJoGVISvHiWFNEg9rS9ofBIYMqNTmqL2R6Vn 5Cj/4IGaxiK8VsLrlmYqiVFAfQE9R5HgEuXaiX0UQ5V6+0r3a6bJ/WylR8vZ4q1/Zf/5v3YSuD5 sFzzY1tb0HS0cXavQ3DHpa043DF1AQeGQvBSu+m76JrTzFJmwcp5Mj1YGFA== X-Gm-Gg: ASbGnctS7Sa9Vz4boAZMVEXeNFWIbFOwcTiPbG6cco3R3G8i1t/DPFEK/Q1M+TCwoTz ma4nZHkskV4fjaNTwpoRZzfvdFz93FeR605TgqiYmOqwdbmA9d7LwIi3Vs9/oYVR8M61t0vV9ot A1jvIStRQu9mex3PluaImzEIZMtr0HjuNgqPkh7tC27GzEPW8/+98vdhG7dEMN8UDO11T9I4Pto QnGBKJ2Czqcb8aoUl2fG7CnqNyEwrKJe6fHd/iO/2GtoX9GuVAPPmAFXd6d7D8wiggqpikGAV7e p74czy+yN+iVF6xM/1xF4iJtgIDdDohItg== X-Received: by 2002:a05:6000:18ac:b0:38a:88f8:aadd with SMTP id ffacd0b85a97d-38c520a64b7mr24070995f8f.53.1738629750444; Mon, 03 Feb 2025 16:42:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IFG5u2kKMgu8qKV7xYpOUQltCsgoENqpHCl0T4XuUxgaszRd1oR6BOI32vkXab+H0ZssMydhQ== X-Received: by 2002:a05:6000:18ac:b0:38a:88f8:aadd with SMTP id ffacd0b85a97d-38c520a64b7mr24070988f8f.53.1738629750114; Mon, 03 Feb 2025 16:42:30 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c0ec02bsm14380445f8f.13.2025.02.03.16.42.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 16:42:28 -0800 (PST) Date: Tue, 4 Feb 2025 01:42:27 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 5/6] util: read_remainder should take const pointer to iovec Message-ID: <20250204014227.36799874@elisabeth> In-Reply-To: <20250203092615.500163-6-david@gibson.dropbear.id.au> References: <20250203092615.500163-1-david@gibson.dropbear.id.au> <20250203092615.500163-6-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Cip-V0t9fSz7GMjvZqWx6YBXtzQuAMlu-V504trUxUw_1738629751 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: XQJU7FWAUXD772YXMVBTWI3VOF2P5G6A X-Message-ID-Hash: XQJU7FWAUXD772YXMVBTWI3VOF2P5G6A X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 3 Feb 2025 20:26:14 +1100 David Gibson wrote: > read_remainder() takes a struct iovec * to describe where it will read its > data, unlike write_remainder() which takes a const struct iovec *. At > first this seems like it makes sense, since read_remainder() will alter > data within the iovec. > > However, what it actually alters is data within the buffers described by > the iovec, not the iovec entries itself. So, like write it should take > a const struct iovec *. > > [This is a candidate for folding into the earlier patch] Folded into existing patch and applied. -- Stefano