From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 3/5] migrate: Move repair_sock_init() to vu_init()
Date: Tue, 4 Feb 2025 01:42:31 +0100 [thread overview]
Message-ID: <20250204014231.3b7fe0d6@elisabeth> (raw)
In-Reply-To: <20250130083330.917030-4-david@gibson.dropbear.id.au>
On Thu, 30 Jan 2025 19:33:28 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> Currently we call repair_sock_init() immediately before
> tap_sock_unix_init(). However, this means it will be skipped if the
> vhost-user control fd is passed with --fd instead of being created at a
> specific path.
That's intended, because we might not have a path in that case. See
conf_open_files().
I know it's not perfectly consistent, but it's practical at the moment.
The alternative opens up complicated questions such as: should we have
a --fd-repair option? What should be the default path if only --fd is
given? This is really unnecessary right now.
--
Stefano
next prev parent reply other threads:[~2025-02-04 0:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 8:33 [PATCH 0/5] RFC: Assorted migration improvements David Gibson
2025-01-30 8:33 ` [PATCH 1/5] migrate: Add passt-repair to .gitignore David Gibson
2025-01-30 8:33 ` [PATCH 2/5] migrate: vu_migrate_{source,target}() aren't actually vu speciic David Gibson
2025-01-30 8:33 ` [PATCH 3/5] migrate: Move repair_sock_init() to vu_init() David Gibson
2025-02-04 0:42 ` Stefano Brivio [this message]
2025-02-04 2:09 ` David Gibson
2025-01-30 8:33 ` [PATCH 4/5] migrate: Make more handling common rather than vhost-user specific David Gibson
2025-01-30 8:33 ` [PATCH 5/5] migrate: Don't handle the migration channel through epoll David Gibson
2025-01-31 5:37 ` Stefano Brivio
2025-01-31 6:23 ` David Gibson
2025-01-30 8:46 ` [PATCH 0/5] RFC: Assorted migration improvements Stefano Brivio
2025-01-30 8:55 ` David Gibson
2025-01-31 5:46 ` Stefano Brivio
2025-01-31 6:24 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204014231.3b7fe0d6@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).