From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Bb2gdQIK; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 32CA95A0276 for ; Tue, 04 Feb 2025 01:42:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738629758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9GloYbM4xB5o09tVP8KDUQN4n0PTuXOdTum6fD3LM88=; b=Bb2gdQIKon+zff31GtfALnMUCRryqqWPkoqYp81QRzuBgceC4NRqBKsdtMKkj+gwVhE12U FsncBHmae75oi8oZF/V5NfLCN9Y5EDvygFsdX+ThwX6uHtdhtlAOdN9qZS+69OyCa+/bEJ 6FLZQwC3hlPOcJ4lEHlapqnts6kBiYY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-58-jxI7cda2OnSkQba2XcPLkw-1; Mon, 03 Feb 2025 19:42:36 -0500 X-MC-Unique: jxI7cda2OnSkQba2XcPLkw-1 X-Mimecast-MFC-AGG-ID: jxI7cda2OnSkQba2XcPLkw Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43619b135bcso24955005e9.1 for ; Mon, 03 Feb 2025 16:42:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738629755; x=1739234555; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9GloYbM4xB5o09tVP8KDUQN4n0PTuXOdTum6fD3LM88=; b=MkUA/U/VT45PwzNKantpJwuTco42RrZzCbILJI/hfWXKpdvEXGfmD46S8rgMWgyLvQ YvXV8hlrWccrBnOsxceFxl3iajRowdW70MtAPePG17k+dLiAWXZ2FIJ0IZcyzNf7vqyf GjDiR1/Z4neQQPV9UcYESXdcE9NyFdkDccbi8dDgIjOfPhf3DhUUqY5dT4+Ua9vpS70e IgICKj/c8yytM9K+B1V3dzafyN2ShtTdek+NpXIDEbp+/TKPnZ2mjV2q80AypgB3h1R+ 8AWuV4IAjpMrNqGupB7hebyfOzklZxepv0g7t1YDF9uWGFztWoxpxb+CFQ7+xgO9/2x3 S4iQ== X-Gm-Message-State: AOJu0YxXoy5un2UeqX2Hmhm8Pg0Pz40m/ZMF2+DMBy1F0TrBFRnrUDoJ xIXOA3bAXW6QfQxXADmVPBYus6hMILY3f3hE9FPDS/BYPy07KX0hVXO6zevpPaaZrOvCzi1VVWs Qois1XrYSguxU1Hp7w7bVk2ebBp+cpyoRqSTJl0fZ+HdeAFAmgg== X-Gm-Gg: ASbGncvA1sb+oL5xRoqiFSPwnR7PDy7cPO/5E8UfEK03ma0aqcZoEXNBrD9V8HNISFv ZT/ECHSmWazc3lubG+WpS7YOteGa8iiGTp3Ru9wnJ97iaVntYJ40TzmEuB6v/EGKfcHtUxlDa7M mgVbga6rSk9epOPMuSLmJu720JotcsB1wBCu36Dgiyyg243eZYNWBwf1OFrmlotn74UJNCwWQmB 2MGgAYDfPRmUUcjEw9u9UiURDcfVuU0Yj+u2sQ+bkH42UykFBaEayTQiCylt7SAyXs6ggFcSSNs OGK+MsJBZk/jQSzn X-Received: by 2002:a05:600c:3488:b0:434:a711:ace4 with SMTP id 5b1f17b1804b1-438dc3cb049mr212237915e9.17.1738629755535; Mon, 03 Feb 2025 16:42:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IG9NsTzuzL/puQX64qD/BBXyhvBJD/Cq5LgI0p/EAtdGi6uwZyA+nx/fcAQJpXG+ruj8AQqEw== X-Received: by 2002:a05:600c:3488:b0:434:a711:ace4 with SMTP id 5b1f17b1804b1-438dc3cb049mr212237845e9.17.1738629755186; Mon, 03 Feb 2025 16:42:35 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438e23e5e53sm170022845e9.17.2025.02.03.16.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 16:42:33 -0800 (PST) Date: Tue, 4 Feb 2025 01:42:31 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 3/5] migrate: Move repair_sock_init() to vu_init() Message-ID: <20250204014231.3b7fe0d6@elisabeth> In-Reply-To: <20250130083330.917030-4-david@gibson.dropbear.id.au> References: <20250130083330.917030-1-david@gibson.dropbear.id.au> <20250130083330.917030-4-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cf4dGvReHTnYRzalUYwmyoHWrppt4mzoGXOw9y_Z1II_1738629755 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: SOBG6JDGDWZVN7WLTCFIHESN3QE44VLP X-Message-ID-Hash: SOBG6JDGDWZVN7WLTCFIHESN3QE44VLP X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 30 Jan 2025 19:33:28 +1100 David Gibson wrote: > Currently we call repair_sock_init() immediately before > tap_sock_unix_init(). However, this means it will be skipped if the > vhost-user control fd is passed with --fd instead of being created at a > specific path. That's intended, because we might not have a path in that case. See conf_open_files(). I know it's not perfectly consistent, but it's practical at the moment. The alternative opens up complicated questions such as: should we have a --fd-repair option? What should be the default path if only --fd is given? This is really unnecessary right now. -- Stefano