From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 1/3] migrate: Fix several errors with passt-repair
Date: Tue, 4 Feb 2025 16:42:13 +1100 [thread overview]
Message-ID: <20250204054215.644811-2-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20250204054215.644811-1-david@gibson.dropbear.id.au>
The passt-repair helper is now merged, but alas it contains several small
bugs:
* close() is not in the seccomp profile, meaning it will immediately
SIGSYS when you make a request of it
* The generated header, seccomp_repair.h isn't listed in .gitignore or
removed by "make clean"
Fixes: 8c24301462c3 ("Introduce passt-repair")
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
.gitignore | 1 +
Makefile | 2 +-
passt-repair.c | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/.gitignore b/.gitignore
index 5824a71e..3c16adc7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,5 +7,6 @@
/qrap
/pasta.1
/seccomp.h
+/seccomp_repair.h
/c*.json
README.plain.md
diff --git a/Makefile b/Makefile
index fde66701..d4e10967 100644
--- a/Makefile
+++ b/Makefile
@@ -117,7 +117,7 @@ valgrind: all
.PHONY: clean
clean:
- $(RM) $(BIN) *~ *.o seccomp.h pasta.1 \
+ $(RM) $(BIN) *~ *.o seccomp.h seccomp_repair.h pasta.1 \
passt.tar passt.tar.gz *.deb *.rpm \
passt.pid README.plain.md
diff --git a/passt-repair.c b/passt-repair.c
index 767a8211..dd8578f5 100644
--- a/passt-repair.c
+++ b/passt-repair.c
@@ -46,7 +46,7 @@
*
* Return: 0 on success (EOF), 1 on error, 2 on usage error
*
- * #syscalls:repair connect setsockopt write exit_group
+ * #syscalls:repair connect setsockopt write close exit_group
* #syscalls:repair socket s390x:socketcall i686:socketcall
* #syscalls:repair recvfrom recvmsg arm:recv ppc64le:recv
* #syscalls:repair sendto sendmsg arm:send ppc64le:send
--
@@ -46,7 +46,7 @@
*
* Return: 0 on success (EOF), 1 on error, 2 on usage error
*
- * #syscalls:repair connect setsockopt write exit_group
+ * #syscalls:repair connect setsockopt write close exit_group
* #syscalls:repair socket s390x:socketcall i686:socketcall
* #syscalls:repair recvfrom recvmsg arm:recv ppc64le:recv
* #syscalls:repair sendto sendmsg arm:send ppc64le:send
--
2.48.1
next prev parent reply other threads:[~2025-02-04 5:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 5:42 [PATCH v2 0/3] Further migration fixes David Gibson
2025-02-04 5:42 ` David Gibson [this message]
2025-02-04 8:36 ` [PATCH v2 1/3] migrate: Fix several errors with passt-repair Stefano Brivio
2025-02-04 5:42 ` [PATCH v2 2/3] migrate, tcp: Report more error conditions during connection repair David Gibson
2025-02-04 5:42 ` [PATCH v2 3/3] tcp: Simplify handling of getsockname() David Gibson
2025-02-04 7:50 ` Stefano Brivio
2025-02-04 8:36 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204054215.644811-2-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).