From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=kKN6gtIU; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 2A3E85A0274 for ; Tue, 04 Feb 2025 06:42:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1738647727; bh=Tk7S5Pe4TU097TfCK2A2DvPnrXygt4CdQfEJ87w6MSE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kKN6gtIUyemH51+Dc72SEpXcumthEvrI8YrFgEK/vh8DzNUDshsZLfJroB3x+iw27 7yUPAPzYnxIaVhOSQYyKc7tFNOsubmFcngZv67Ud80t+o8M4VPKoPPB8+RiHe/JaGN 806hkhf2zgf3rDYrWqFt4LjURgOMpE+UbypCoDp9kuaywV2dE9BYYJ4wJCyik1mu1w oURj12mv54eiUsZ+eObBK8Oi/3eRacDDVg4NATMx1k/3T92p4bWmTeCda4PRVtQP4W H/5lVj/ME6jt5GtXeggC66YoqcDCgOM92X6SxWQptXGYGXFcTdAYUHlJtUTrP5oqne CUbyzHqtnFynQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4YnC1C299mz4wxm; Tue, 4 Feb 2025 16:42:07 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v2 1/3] migrate: Fix several errors with passt-repair Date: Tue, 4 Feb 2025 16:42:13 +1100 Message-ID: <20250204054215.644811-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250204054215.644811-1-david@gibson.dropbear.id.au> References: <20250204054215.644811-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: PC2SLB7CYHR7YV6JDKZ7LTN7GT74IMN7 X-Message-ID-Hash: PC2SLB7CYHR7YV6JDKZ7LTN7GT74IMN7 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The passt-repair helper is now merged, but alas it contains several small bugs: * close() is not in the seccomp profile, meaning it will immediately SIGSYS when you make a request of it * The generated header, seccomp_repair.h isn't listed in .gitignore or removed by "make clean" Fixes: 8c24301462c3 ("Introduce passt-repair") Signed-off-by: David Gibson --- .gitignore | 1 + Makefile | 2 +- passt-repair.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 5824a71e..3c16adc7 100644 --- a/.gitignore +++ b/.gitignore @@ -7,5 +7,6 @@ /qrap /pasta.1 /seccomp.h +/seccomp_repair.h /c*.json README.plain.md diff --git a/Makefile b/Makefile index fde66701..d4e10967 100644 --- a/Makefile +++ b/Makefile @@ -117,7 +117,7 @@ valgrind: all .PHONY: clean clean: - $(RM) $(BIN) *~ *.o seccomp.h pasta.1 \ + $(RM) $(BIN) *~ *.o seccomp.h seccomp_repair.h pasta.1 \ passt.tar passt.tar.gz *.deb *.rpm \ passt.pid README.plain.md diff --git a/passt-repair.c b/passt-repair.c index 767a8211..dd8578f5 100644 --- a/passt-repair.c +++ b/passt-repair.c @@ -46,7 +46,7 @@ * * Return: 0 on success (EOF), 1 on error, 2 on usage error * - * #syscalls:repair connect setsockopt write exit_group + * #syscalls:repair connect setsockopt write close exit_group * #syscalls:repair socket s390x:socketcall i686:socketcall * #syscalls:repair recvfrom recvmsg arm:recv ppc64le:recv * #syscalls:repair sendto sendmsg arm:send ppc64le:send -- 2.48.1